From: Jouni Malinen <j@w1.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: vnaralas@codeaurora.org, linux-wireless@vger.kernel.org,
Arend Van Spriel <arend.vanspriel@broadcom.com>,
Kalle Valo <kvalo@codeaurora.org>,
ath11k@lists.infradead.org
Subject: Re: [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save
Date: Wed, 23 Dec 2020 14:46:22 +0200 [thread overview]
Message-ID: <20201223124622.GA12620@w1.fi> (raw)
In-Reply-To: <60c779b7c17b8ea40c2bba08d8fca98e83581580.camel@sipsolutions.net>
On Fri, Nov 06, 2020 at 11:41:06AM +0100, Johannes Berg wrote:
> I suspect that SET_POWERSAVE might be confusing.
Why? Isn't the use case here very similar to the existing station mode
use of power save even if the power saving mechanism is more of a vendor
specific extension that applies while there are no associated stations?
> Perhaps just with an attribute used in START_AP (and CHANGE_BEACON if
> needed) would be sufficient?
NL80211_CMD_START_AP with a new attribute (or even re-use of
NL80211_ATTR_PS_STATE) might work for a case where this does not need to
be changed dynamically during the lifetime of the BSS.
NL80211_CMD_SET_BEACON (which maps to the change_beacon() callback)
feels like something that is currently limited to Beacon data updates
with its use of struct cfg80211_beacon_data instead of struct
cfg80211_ap_settings..
That SET_BEACON name is still from the old NEW/SET/DEL_BEACON time.
Should that be renamed to NL80211_CMD_UPDATE_AP if we extend this to
changes that are not really targeting the Beacon frame payload itself?
And should the cfg80211_beacon_data argument be replaced with
cfg80211_ap_settings? It looks like we already have some struct
cfg80211_ap_settings values like inactivity_timeout and beacon_rate (and
maybe some HE parameters?) that one might want to update during the
lifetime of the BSS..
--
Jouni Malinen PGP id EFC895FA
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Jouni Malinen <j@w1.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Kalle Valo <kvalo@codeaurora.org>,
vnaralas@codeaurora.org,
Arend Van Spriel <arend.vanspriel@broadcom.com>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save
Date: Wed, 23 Dec 2020 14:46:22 +0200 [thread overview]
Message-ID: <20201223124622.GA12620@w1.fi> (raw)
In-Reply-To: <60c779b7c17b8ea40c2bba08d8fca98e83581580.camel@sipsolutions.net>
On Fri, Nov 06, 2020 at 11:41:06AM +0100, Johannes Berg wrote:
> I suspect that SET_POWERSAVE might be confusing.
Why? Isn't the use case here very similar to the existing station mode
use of power save even if the power saving mechanism is more of a vendor
specific extension that applies while there are no associated stations?
> Perhaps just with an attribute used in START_AP (and CHANGE_BEACON if
> needed) would be sufficient?
NL80211_CMD_START_AP with a new attribute (or even re-use of
NL80211_ATTR_PS_STATE) might work for a case where this does not need to
be changed dynamically during the lifetime of the BSS.
NL80211_CMD_SET_BEACON (which maps to the change_beacon() callback)
feels like something that is currently limited to Beacon data updates
with its use of struct cfg80211_beacon_data instead of struct
cfg80211_ap_settings..
That SET_BEACON name is still from the old NEW/SET/DEL_BEACON time.
Should that be renamed to NL80211_CMD_UPDATE_AP if we extend this to
changes that are not really targeting the Beacon frame payload itself?
And should the cfg80211_beacon_data argument be replaced with
cfg80211_ap_settings? It looks like we already have some struct
cfg80211_ap_settings values like inactivity_timeout and beacon_rate (and
maybe some HE parameters?) that one might want to update during the
lifetime of the BSS..
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2020-12-23 12:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 8:26 [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save Venkateswara Naralasetty
2020-08-24 8:26 ` Venkateswara Naralasetty
2020-08-24 8:26 ` [PATCHv2 2/2] ath11k: Add ap power save support Venkateswara Naralasetty
2020-08-24 8:26 ` Venkateswara Naralasetty
2021-01-27 18:02 ` Kalle Valo
2021-01-27 18:02 ` Kalle Valo
2021-01-27 18:14 ` Kalle Valo
2021-01-27 18:14 ` Kalle Valo
2020-09-28 11:24 ` [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save Johannes Berg
2020-09-28 11:24 ` Johannes Berg
2020-09-29 7:40 ` Kalle Valo
2020-09-29 7:40 ` Kalle Valo
2020-09-29 8:04 ` Johannes Berg
2020-09-29 8:04 ` Johannes Berg
2020-09-29 12:39 ` vnaralas
2020-09-29 12:39 ` vnaralas
2020-10-21 17:19 ` Kalle Valo
2020-10-21 17:19 ` Kalle Valo
2020-10-22 8:00 ` Arend Van Spriel
2020-10-22 8:00 ` Arend Van Spriel
2020-10-22 8:05 ` Arend Van Spriel
2020-10-22 8:05 ` Arend Van Spriel
2020-10-23 3:47 ` vnaralas
2020-10-23 3:47 ` vnaralas
2020-11-02 19:44 ` Kalle Valo
2020-11-02 19:44 ` Kalle Valo
2020-11-06 10:41 ` Johannes Berg
2020-11-06 10:41 ` Johannes Berg
2020-11-17 11:23 ` vnaralas
2020-11-17 11:23 ` vnaralas
2020-12-23 12:46 ` Jouni Malinen [this message]
2020-12-23 12:46 ` Jouni Malinen
2021-01-15 10:10 ` Johannes Berg
2021-01-15 10:10 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223124622.GA12620@w1.fi \
--to=j@w1.fi \
--cc=arend.vanspriel@broadcom.com \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vnaralas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.