All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: vnaralas@codeaurora.org
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save
Date: Wed, 21 Oct 2020 20:19:10 +0300	[thread overview]
Message-ID: <87eelr1oq9.fsf@codeaurora.org> (raw)
In-Reply-To: <dbaa655c3f15f800f73b7c19f2b1a054@codeaurora.org> (vnaralas@codeaurora.org's message of "Tue, 29 Sep 2020 18:09:44 +0530")

vnaralas@codeaurora.org writes:

> On 2020-09-29 13:10, Kalle Valo wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>>> On Mon, 2020-08-24 at 13:56 +0530, Venkateswara Naralasetty wrote:
>>>> AP power save feature is to save power in AP mode, where AP goes
>>>> to power save mode when no stations associate to it and comes out
>>>> of power save when any station associate to AP.
>>>
>>> Why do you think this requires a vendor command? I mean, that seems
>>> like
>>> fairly reasonable - even by default - behaviour?
>>
>> I have not studied the details, but doesn't AP power save break normal
>> functionality? For example, I would guess probe requests from clients
>> would be lost. So there's a major drawback when enabling this, right?
>
> This AP power save feature will not break any functionality, Since one
> chain is always active and all other chains will be disabled when this
> feature is enabled. AP can still be able to beacon and receive probe
> request from the clients. The only drawback is reduced network range
> when this feature is enabled. Hence, we don't want to enable it by
> default.

Yeah, we really would not want to enable that by default. But what
should be the path forward, a vendor command or a proper nl80211
command? Any opinions?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: vnaralas@codeaurora.org
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save
Date: Wed, 21 Oct 2020 20:19:10 +0300	[thread overview]
Message-ID: <87eelr1oq9.fsf@codeaurora.org> (raw)
In-Reply-To: <dbaa655c3f15f800f73b7c19f2b1a054@codeaurora.org> (vnaralas@codeaurora.org's message of "Tue, 29 Sep 2020 18:09:44 +0530")

vnaralas@codeaurora.org writes:

> On 2020-09-29 13:10, Kalle Valo wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>>> On Mon, 2020-08-24 at 13:56 +0530, Venkateswara Naralasetty wrote:
>>>> AP power save feature is to save power in AP mode, where AP goes
>>>> to power save mode when no stations associate to it and comes out
>>>> of power save when any station associate to AP.
>>>
>>> Why do you think this requires a vendor command? I mean, that seems
>>> like
>>> fairly reasonable - even by default - behaviour?
>>
>> I have not studied the details, but doesn't AP power save break normal
>> functionality? For example, I would guess probe requests from clients
>> would be lost. So there's a major drawback when enabling this, right?
>
> This AP power save feature will not break any functionality, Since one
> chain is always active and all other chains will be disabled when this
> feature is enabled. AP can still be able to beacon and receive probe
> request from the clients. The only drawback is reduced network range
> when this feature is enabled. Hence, we don't want to enable it by
> default.

Yeah, we really would not want to enable that by default. But what
should be the path forward, a vendor command or a proper nl80211
command? Any opinions?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2020-10-21 17:19 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24  8:26 [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save Venkateswara Naralasetty
2020-08-24  8:26 ` Venkateswara Naralasetty
2020-08-24  8:26 ` [PATCHv2 2/2] ath11k: Add ap power save support Venkateswara Naralasetty
2020-08-24  8:26   ` Venkateswara Naralasetty
2021-01-27 18:02   ` Kalle Valo
2021-01-27 18:02     ` Kalle Valo
2021-01-27 18:14     ` Kalle Valo
2021-01-27 18:14       ` Kalle Valo
2020-09-28 11:24 ` [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save Johannes Berg
2020-09-28 11:24   ` Johannes Berg
2020-09-29  7:40   ` Kalle Valo
2020-09-29  7:40     ` Kalle Valo
2020-09-29  8:04     ` Johannes Berg
2020-09-29  8:04       ` Johannes Berg
2020-09-29 12:39     ` vnaralas
2020-09-29 12:39       ` vnaralas
2020-10-21 17:19       ` Kalle Valo [this message]
2020-10-21 17:19         ` Kalle Valo
2020-10-22  8:00         ` Arend Van Spriel
2020-10-22  8:00           ` Arend Van Spriel
2020-10-22  8:05           ` Arend Van Spriel
2020-10-22  8:05             ` Arend Van Spriel
2020-10-23  3:47           ` vnaralas
2020-10-23  3:47             ` vnaralas
2020-11-02 19:44             ` Kalle Valo
2020-11-02 19:44               ` Kalle Valo
2020-11-06 10:41               ` Johannes Berg
2020-11-06 10:41                 ` Johannes Berg
2020-11-17 11:23                 ` vnaralas
2020-11-17 11:23                   ` vnaralas
2020-12-23 12:46                 ` Jouni Malinen
2020-12-23 12:46                   ` Jouni Malinen
2021-01-15 10:10                   ` Johannes Berg
2021-01-15 10:10                     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eelr1oq9.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=vnaralas@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.