* [PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM
@ 2020-12-24 6:24 Marek Vasut
2021-01-14 17:18 ` Alexandre TORGUE
0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2020-12-24 6:24 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Alexandre Torgue, Patrice Chotard, Patrick Delaunay,
Maxime Coquelin, linux-stm32
The GPIO hog node name should match regex '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$',
make it so and fix the following two make dtbs_check warnings:
arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dt.yaml: hog-usb-port-power: $nodename:0: 'hog-usb-port-power' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: hog-usb-hub: $nodename:0: 'hog-usb-hub' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi | 4 ++--
arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
index 62ab23824a3e..cb68afbbea68 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
@@ -33,7 +33,7 @@ &gpiob {
* during TX anyway and that it only controls drive enable DE
* line. Hence, the RX is always enabled here.
*/
- rs485-rx-en {
+ rs485-rx-en-hog {
gpio-hog;
gpios = <8 GPIO_ACTIVE_HIGH>;
output-low;
@@ -61,7 +61,7 @@ &gpioi {
* order to reset the Hub when USB bus is powered down, but
* so far there is no such functionality.
*/
- usb-hub {
+ usb-hub-hog {
gpio-hog;
gpios = <2 GPIO_ACTIVE_HIGH>;
output-high;
diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
index 356150d28c42..b99f2b891629 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
@@ -43,7 +43,7 @@ &gpioa {
* in order to turn on port power when USB bus is powered up, but so
* far there is no such functionality.
*/
- usb-port-power {
+ usb-port-power-hog {
gpio-hog;
gpios = <13 GPIO_ACTIVE_LOW>;
output-low;
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM
2020-12-24 6:24 [PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM Marek Vasut
@ 2021-01-14 17:18 ` Alexandre TORGUE
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre TORGUE @ 2021-01-14 17:18 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Patrick Delaunay, linux-stm32, Alexandre Torgue, Maxime Coquelin,
Patrice Chotard
Hi Marek
On 12/24/20 7:24 AM, Marek Vasut wrote:
> The GPIO hog node name should match regex '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$',
> make it so and fix the following two make dtbs_check warnings:
>
> arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dt.yaml: hog-usb-port-power: $nodename:0: 'hog-usb-port-power' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
> arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: hog-usb-hub: $nodename:0: 'hog-usb-hub' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi | 4 ++--
> arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
> index 62ab23824a3e..cb68afbbea68 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
> @@ -33,7 +33,7 @@ &gpiob {
> * during TX anyway and that it only controls drive enable DE
> * line. Hence, the RX is always enabled here.
> */
> - rs485-rx-en {
> + rs485-rx-en-hog {
> gpio-hog;
> gpios = <8 GPIO_ACTIVE_HIGH>;
> output-low;
> @@ -61,7 +61,7 @@ &gpioi {
> * order to reset the Hub when USB bus is powered down, but
> * so far there is no such functionality.
> */
> - usb-hub {
> + usb-hub-hog {
> gpio-hog;
> gpios = <2 GPIO_ACTIVE_HIGH>;
> output-high;
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> index 356150d28c42..b99f2b891629 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> @@ -43,7 +43,7 @@ &gpioa {
> * in order to turn on port power when USB bus is powered up, but so
> * far there is no such functionality.
> */
> - usb-port-power {
> + usb-port-power-hog {
> gpio-hog;
> gpios = <13 GPIO_ACTIVE_LOW>;
> output-low;
>
Applied on stm32-fixes with a Fixes tag added.
Thanks.
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-14 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-24 6:24 [PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM Marek Vasut
2021-01-14 17:18 ` Alexandre TORGUE
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.