From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Nadeem Athani <nadeem@cadence.com>
Cc: <tjoseph@cadence.com>, <lorenzo.pieralisi@arm.com>,
<robh@kernel.org>, <bhelgaas@google.com>, <kishon@ti.com>,
<linux-omap@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
mparab@cadence.com, pthombar@cadence.com, sjakhade@cadence.com
Subject: Re: [PATCH v6 1/2] PCI: cadence: Retrain Link to work around Gen2 training defect.
Date: Tue, 29 Dec 2020 22:22:05 +0100 [thread overview]
Message-ID: <20201229222205.576549d1@windsurf> (raw)
In-Reply-To: <20201228140510.14641-2-nadeem@cadence.com>
Hello,
The commit title is incorrect, it doesn't match what the patch is doing.
On Mon, 28 Dec 2020 15:05:09 +0100
Nadeem Athani <nadeem@cadence.com> wrote:
> Moving the function above to remove compilation error.
> No changes in function.
Which compilation error? I guess there is no compilation error, except
after your apply your PATCH 2/2. Is this correct ?
If so, this should be explained in this commit log: "Move the function
cdns_pcie_host_wait_for_link() further up in the file, as it's going to
be used by upcoming additional code in the driver."
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Nadeem Athani <nadeem@cadence.com>
Cc: lorenzo.pieralisi@arm.com, mparab@cadence.com,
linux-pci@vger.kernel.org, pthombar@cadence.com,
linux-kernel@vger.kernel.org, kishon@ti.com, tjoseph@cadence.com,
sjakhade@cadence.com, bhelgaas@google.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/2] PCI: cadence: Retrain Link to work around Gen2 training defect.
Date: Tue, 29 Dec 2020 22:22:05 +0100 [thread overview]
Message-ID: <20201229222205.576549d1@windsurf> (raw)
In-Reply-To: <20201228140510.14641-2-nadeem@cadence.com>
Hello,
The commit title is incorrect, it doesn't match what the patch is doing.
On Mon, 28 Dec 2020 15:05:09 +0100
Nadeem Athani <nadeem@cadence.com> wrote:
> Moving the function above to remove compilation error.
> No changes in function.
Which compilation error? I guess there is no compilation error, except
after your apply your PATCH 2/2. Is this correct ?
If so, this should be explained in this commit log: "Move the function
cdns_pcie_host_wait_for_link() further up in the file, as it's going to
be used by upcoming additional code in the driver."
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-29 21:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 14:05 [PATCH v6 0/2] PCI: cadence: Retrain Link to work around Gen2 Nadeem Athani
2020-12-28 14:05 ` Nadeem Athani
2020-12-28 14:05 ` [PATCH v6 1/2] PCI: cadence: Retrain Link to work around Gen2 training defect Nadeem Athani
2020-12-28 14:05 ` Nadeem Athani
2020-12-29 21:22 ` Thomas Petazzoni [this message]
2020-12-29 21:22 ` Thomas Petazzoni
2020-12-28 14:05 ` [PATCH v6 2/2] " Nadeem Athani
2020-12-28 14:05 ` Nadeem Athani
2020-12-29 21:31 ` Thomas Petazzoni
2020-12-29 21:31 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229222205.576549d1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mparab@cadence.com \
--cc=nadeem@cadence.com \
--cc=pthombar@cadence.com \
--cc=robh@kernel.org \
--cc=sjakhade@cadence.com \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.