From: Borislav Petkov <bp@alien8.de>
To: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Cc: will@kernel.org, konrad.wilk@oracle.com, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
mingo@redhat.com, joe@perches.com, tglx@linutronix.de,
zhongjiang@huawei.com
Subject: Re: [PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries()
Date: Wed, 30 Dec 2020 08:02:44 +0100 [thread overview]
Message-ID: <20201230070244.GA22022@zn.tnic> (raw)
In-Reply-To: <20201223062412.343-1-zhenzhong.duan@gmail.com>
On Wed, Dec 23, 2020 at 02:24:12PM +0800, Zhenzhong Duan wrote:
> check_iommu_entries() checks for cyclic dependency in iommu entries
> and fixes the cyclic dependency by setting x->depend to NULL. But
> this repairing isn't correct if q is in front of p, there will be
> "EXECUTION ORDER INVALID!" report following. Fix it by NULLing
> whichever in the front.
When does "q is in front of p" happen? How does it happen?
> The second issue is about the report of exectuion order reverse,
> the order is reversed incorrectly in the report, fix it.
I have no clue what that means.
Plese structure your commit message something like this:
Problem is A.
It happens because of B.
Fix it by doing C.
(Potentially do D).
For more detailed info, see
Documentation/process/submitting-patches.rst, Section "2) Describe your
changes".
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Cc: linux-kernel@vger.kernel.org, zhongjiang@huawei.com,
joe@perches.com, konrad.wilk@oracle.com, tglx@linutronix.de,
mingo@redhat.com, iommu@lists.linux-foundation.org,
dwmw2@infradead.org, baolu.lu@linux.intel.com, joro@8bytes.org,
will@kernel.org
Subject: Re: [PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries()
Date: Wed, 30 Dec 2020 08:02:44 +0100 [thread overview]
Message-ID: <20201230070244.GA22022@zn.tnic> (raw)
In-Reply-To: <20201223062412.343-1-zhenzhong.duan@gmail.com>
On Wed, Dec 23, 2020 at 02:24:12PM +0800, Zhenzhong Duan wrote:
> check_iommu_entries() checks for cyclic dependency in iommu entries
> and fixes the cyclic dependency by setting x->depend to NULL. But
> this repairing isn't correct if q is in front of p, there will be
> "EXECUTION ORDER INVALID!" report following. Fix it by NULLing
> whichever in the front.
When does "q is in front of p" happen? How does it happen?
> The second issue is about the report of exectuion order reverse,
> the order is reversed incorrectly in the report, fix it.
I have no clue what that means.
Plese structure your commit message something like this:
Problem is A.
It happens because of B.
Fix it by doing C.
(Potentially do D).
For more detailed info, see
Documentation/process/submitting-patches.rst, Section "2) Describe your
changes".
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-12-30 7:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 6:24 [PATCH] x86/iommu: Fix two minimal issues in check_iommu_entries() Zhenzhong Duan
2020-12-23 6:24 ` Zhenzhong Duan
2020-12-30 7:02 ` Borislav Petkov [this message]
2020-12-30 7:02 ` Borislav Petkov
2021-01-04 5:43 ` Zhenzhong Duan
2021-01-04 5:43 ` Zhenzhong Duan
2021-01-04 19:02 ` Konrad Rzeszutek Wilk
2021-01-04 19:02 ` Konrad Rzeszutek Wilk
2021-01-07 2:51 ` Zhenzhong Duan
2021-01-07 2:51 ` Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201230070244.GA22022@zn.tnic \
--to=bp@alien8.de \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joe@perches.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=zhenzhong.duan@gmail.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.