All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: shahafs@mellanox.com, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH V2 00/19] vDPA driver for virtio-pci device
Date: Sun, 3 Jan 2021 07:37:02 -0500	[thread overview]
Message-ID: <20210103073629-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <3a3fa2f5-d5d8-e8dd-71d1-cb81a3276658@redhat.com>

On Thu, Dec 31, 2020 at 11:52:14AM +0800, Jason Wang wrote:
> 
> On 2020/12/4 下午12:03, Jason Wang wrote:
> > Hi all:
> > 
> > This series tries to implement a vDPA driver for virtio-pci device
> > which will bridge between vDPA bus and virtio-pci device.
> > 
> > This could be used for future feature prototyping and testing.
> > 
> > Please review
> > 
> > Changes from V2:
> > 
> > - don't try to use devres for virtio-pci core
> > - tweak the commit log
> > - split the patches furtherly to ease the reviewing
> > 
> > Changes from V1:
> > 
> > - Split common codes from virito-pci and share it with vDPA driver
> > - Use dynamic id in order to be less confusing with virtio-pci driver
> > - No feature whitelist, supporting any features (mq, config etc)
> > 
> > Thanks
> 
> 
> Michael, any comment for this series?
> 
> It's needed for testing doorbell mapping and config interrupt support.
> 
> Thanks

I saw you got some comments back in december so was expecting another
version. If you'd rather I reviewed this one, let me know.

-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, shahafs@mellanox.com
Subject: Re: [PATCH V2 00/19] vDPA driver for virtio-pci device
Date: Sun, 3 Jan 2021 07:37:02 -0500	[thread overview]
Message-ID: <20210103073629-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <3a3fa2f5-d5d8-e8dd-71d1-cb81a3276658@redhat.com>

On Thu, Dec 31, 2020 at 11:52:14AM +0800, Jason Wang wrote:
> 
> On 2020/12/4 下午12:03, Jason Wang wrote:
> > Hi all:
> > 
> > This series tries to implement a vDPA driver for virtio-pci device
> > which will bridge between vDPA bus and virtio-pci device.
> > 
> > This could be used for future feature prototyping and testing.
> > 
> > Please review
> > 
> > Changes from V2:
> > 
> > - don't try to use devres for virtio-pci core
> > - tweak the commit log
> > - split the patches furtherly to ease the reviewing
> > 
> > Changes from V1:
> > 
> > - Split common codes from virito-pci and share it with vDPA driver
> > - Use dynamic id in order to be less confusing with virtio-pci driver
> > - No feature whitelist, supporting any features (mq, config etc)
> > 
> > Thanks
> 
> 
> Michael, any comment for this series?
> 
> It's needed for testing doorbell mapping and config interrupt support.
> 
> Thanks

I saw you got some comments back in december so was expecting another
version. If you'd rather I reviewed this one, let me know.

-- 
MST


  reply	other threads:[~2021-01-03 12:37 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04  4:03 [PATCH V2 00/19] vDPA driver for virtio-pci device Jason Wang
2020-12-04  4:03 ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 01/19] virtio-pci: do not access iomem via struct virtio_pci_device directly Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 02/19] virtio-pci: split out modern device Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 03/19] virtio-pci-modern: factor out modern device initialization logic Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 04/19] virtio-pci-modern: introduce vp_modern_remove() Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 05/19] virtio-pci-modern: introduce helper to set config vector Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 06/19] virtio-pci-modern: introduce helpers for setting and getting status Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 07/19] virtio-pci-modern: introduce helpers for setting and getting features Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 08/19] virtio-pci-modern: introduce vp_modern_generation() Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 09/19] virtio-pci-modern: introduce vp_modern_set_queue_vector() Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 10/19] virtio-pci-modern: introduce vp_modern_queue_address() Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 11/19] virtio-pci-modern: introduce helper to set/get queue_enable Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 12/19] virtio-pci-modern: introduce helper for setting/geting queue size Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 13/19] virtio-pci-modern: introduce helper for getting queue nums Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 14/19] virtio-pci-modern: introduce helper to get notification offset Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 15/19] virito-pci-modern: rename map_capability() to vp_modern_map_capability() Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 16/19] virtio-pci: introduce modern device module Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04 17:10   ` Randy Dunlap
2020-12-04 17:10     ` Randy Dunlap
2021-01-04  3:22     ` Jason Wang
2021-01-04  3:22       ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 17/19] vdpa: set the virtqueue num during register Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04 14:30   ` Stefano Garzarella
2020-12-04 14:30     ` Stefano Garzarella
2020-12-04  4:03 ` [PATCH V2 18/19] virtio_vdpa: don't warn when fail to disable vq Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04  4:03 ` [PATCH V2 19/19] vdpa: introduce virtio pci driver Jason Wang
2020-12-04  4:03   ` Jason Wang
2020-12-04 15:20   ` Stefano Garzarella
2020-12-04 15:20     ` Stefano Garzarella
2020-12-04 17:12     ` Randy Dunlap
2020-12-04 17:12       ` Randy Dunlap
2020-12-07  3:29       ` Jason Wang
2020-12-07  3:29         ` Jason Wang
2021-01-04  3:28     ` Jason Wang
2021-01-04  3:28       ` Jason Wang
2020-12-31  3:52 ` [PATCH V2 00/19] vDPA driver for virtio-pci device Jason Wang
2020-12-31  3:52   ` Jason Wang
2021-01-03 12:37   ` Michael S. Tsirkin [this message]
2021-01-03 12:37     ` Michael S. Tsirkin
2021-01-04  6:58     ` Jason Wang
2021-01-04  6:58       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210103073629-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shahafs@mellanox.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.