From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: shahafs@mellanox.com, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, mst@redhat.com
Subject: Re: [PATCH V2 19/19] vdpa: introduce virtio pci driver
Date: Mon, 4 Jan 2021 11:28:05 +0800 [thread overview]
Message-ID: <a17bd160-eda2-af4f-e465-23d29ca0580a@redhat.com> (raw)
In-Reply-To: <20201204152043.ewqlwviaf33wwiyx@steredhat>
On 2020/12/4 下午11:20, Stefano Garzarella wrote:
>> +#define VP_VDPA_QUEUE_MAX 256
>> +#define VP_VDPA_DRIVER_NAME "vp_vdpa"
>> +
>> +struct vp_vring {
>> + void __iomem *notify;
>> + char msix_name[256];
>
> Can we use a macro for the msix_name size, since we use 256 in
> multiple places?
Yes, will switch to use a macro.
>
>> + struct vdpa_callback cb;
>> + int irq;
>> +};
>> +
>> +struct vp_vdpa {
>> + struct vdpa_device vdpa;
>> + struct virtio_pci_modern_device mdev;
>> + struct vp_vring *vring;
>> + struct vdpa_callback cb;
> ^
> It is not relevant, but 'config_cb' is maybe clearer to read.
>
Will change to config_cb.
> The rest looks good.
Thanks
>
> Thanks,
> Stefano
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: mst@redhat.com, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, shahafs@mellanox.com
Subject: Re: [PATCH V2 19/19] vdpa: introduce virtio pci driver
Date: Mon, 4 Jan 2021 11:28:05 +0800 [thread overview]
Message-ID: <a17bd160-eda2-af4f-e465-23d29ca0580a@redhat.com> (raw)
In-Reply-To: <20201204152043.ewqlwviaf33wwiyx@steredhat>
On 2020/12/4 下午11:20, Stefano Garzarella wrote:
>> +#define VP_VDPA_QUEUE_MAX 256
>> +#define VP_VDPA_DRIVER_NAME "vp_vdpa"
>> +
>> +struct vp_vring {
>> + void __iomem *notify;
>> + char msix_name[256];
>
> Can we use a macro for the msix_name size, since we use 256 in
> multiple places?
Yes, will switch to use a macro.
>
>> + struct vdpa_callback cb;
>> + int irq;
>> +};
>> +
>> +struct vp_vdpa {
>> + struct vdpa_device vdpa;
>> + struct virtio_pci_modern_device mdev;
>> + struct vp_vring *vring;
>> + struct vdpa_callback cb;
> ^
> It is not relevant, but 'config_cb' is maybe clearer to read.
>
Will change to config_cb.
> The rest looks good.
Thanks
>
> Thanks,
> Stefano
next prev parent reply other threads:[~2021-01-04 3:28 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 4:03 [PATCH V2 00/19] vDPA driver for virtio-pci device Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 01/19] virtio-pci: do not access iomem via struct virtio_pci_device directly Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 02/19] virtio-pci: split out modern device Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 03/19] virtio-pci-modern: factor out modern device initialization logic Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 04/19] virtio-pci-modern: introduce vp_modern_remove() Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 05/19] virtio-pci-modern: introduce helper to set config vector Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 06/19] virtio-pci-modern: introduce helpers for setting and getting status Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 07/19] virtio-pci-modern: introduce helpers for setting and getting features Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 08/19] virtio-pci-modern: introduce vp_modern_generation() Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 09/19] virtio-pci-modern: introduce vp_modern_set_queue_vector() Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 10/19] virtio-pci-modern: introduce vp_modern_queue_address() Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 11/19] virtio-pci-modern: introduce helper to set/get queue_enable Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 12/19] virtio-pci-modern: introduce helper for setting/geting queue size Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 13/19] virtio-pci-modern: introduce helper for getting queue nums Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 14/19] virtio-pci-modern: introduce helper to get notification offset Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 15/19] virito-pci-modern: rename map_capability() to vp_modern_map_capability() Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 16/19] virtio-pci: introduce modern device module Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 17:10 ` Randy Dunlap
2020-12-04 17:10 ` Randy Dunlap
2021-01-04 3:22 ` Jason Wang
2021-01-04 3:22 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 17/19] vdpa: set the virtqueue num during register Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 14:30 ` Stefano Garzarella
2020-12-04 14:30 ` Stefano Garzarella
2020-12-04 4:03 ` [PATCH V2 18/19] virtio_vdpa: don't warn when fail to disable vq Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 4:03 ` [PATCH V2 19/19] vdpa: introduce virtio pci driver Jason Wang
2020-12-04 4:03 ` Jason Wang
2020-12-04 15:20 ` Stefano Garzarella
2020-12-04 15:20 ` Stefano Garzarella
2020-12-04 17:12 ` Randy Dunlap
2020-12-04 17:12 ` Randy Dunlap
2020-12-07 3:29 ` Jason Wang
2020-12-07 3:29 ` Jason Wang
2021-01-04 3:28 ` Jason Wang [this message]
2021-01-04 3:28 ` Jason Wang
2020-12-31 3:52 ` [PATCH V2 00/19] vDPA driver for virtio-pci device Jason Wang
2020-12-31 3:52 ` Jason Wang
2021-01-03 12:37 ` Michael S. Tsirkin
2021-01-03 12:37 ` Michael S. Tsirkin
2021-01-04 6:58 ` Jason Wang
2021-01-04 6:58 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a17bd160-eda2-af4f-e465-23d29ca0580a@redhat.com \
--to=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@mellanox.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.