From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY
Date: Wed, 13 Jan 2021 14:49:23 +0800 [thread overview]
Message-ID: <202101131413.Adz6ZgYL-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5991 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210111125337.36513-1-marex@denx.de>
References: <20210111125337.36513-1-marex@denx.de>
TO: Marek Vasut <marex@denx.de>
TO: netdev(a)vger.kernel.org
CC: Marek Vasut <marex@denx.de>
CC: Andrew Lunn <andrew@lunn.ch>
CC: Heiner Kallweit <hkallweit1@gmail.com>
CC: Lukas Wunner <lukas@wunner.de>
Hi Marek,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Marek-Vasut/net-ks8851-Connect-and-start-stop-the-internal-PHY/20210111-210055
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 73b7a6047971aa6ce4a70fc4901964d14f077171
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-m001-20210113 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/ethernet/micrel/ks8851_common.c:1129 ks8851_register_mdiobus() warn: missing error code 'ret'
vim +/ret +1129 drivers/net/ethernet/micrel/ks8851_common.c
d5b40921aa09a0cc drivers/net/ethernet/micrel/ks8851.c Lars-Peter Clausen 2013-04-06 1104
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1105 static int ks8851_register_mdiobus(struct ks8851_net *ks, struct device *dev)
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1106 {
c135c36e0a3639c9 drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-11 1107 struct phy_device *phy_dev;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1108 struct mii_bus *mii_bus;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1109 int ret;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1110
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1111 mii_bus = mdiobus_alloc();
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1112 if (!mii_bus)
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1113 return -ENOMEM;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1114
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1115 mii_bus->name = "ks8851_eth_mii";
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1116 mii_bus->read = ks8851_mdio_read;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1117 mii_bus->write = ks8851_mdio_write;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1118 mii_bus->priv = ks;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1119 mii_bus->parent = dev;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1120 mii_bus->phy_mask = ~((u32)BIT(0));
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1121 snprintf(mii_bus->id, MII_BUS_ID_SIZE, "%s", dev_name(dev));
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1122
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1123 ret = mdiobus_register(mii_bus);
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1124 if (ret)
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1125 goto err_mdiobus_register;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1126
c135c36e0a3639c9 drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-11 1127 phy_dev = phy_find_first(mii_bus);
c135c36e0a3639c9 drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-11 1128 if (!phy_dev)
c135c36e0a3639c9 drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-11 @1129 goto err_find_phy;
c135c36e0a3639c9 drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-11 1130
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1131 ks->mii_bus = mii_bus;
c135c36e0a3639c9 drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-11 1132 ks->phy_dev = phy_dev;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1133
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1134 return 0;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1135
c135c36e0a3639c9 drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-11 1136 err_find_phy:
c135c36e0a3639c9 drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-11 1137 mdiobus_unregister(mii_bus);
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1138 err_mdiobus_register:
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1139 mdiobus_free(mii_bus);
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1140 return ret;
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1141 }
ef3631220d2b3d8d drivers/net/ethernet/micrel/ks8851_common.c Marek Vasut 2021-01-05 1142
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32434 bytes --]
next reply other threads:[~2021-01-13 6:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 6:49 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-11 12:53 [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY Marek Vasut
2021-01-11 13:26 ` Heiner Kallweit
2021-01-11 13:38 ` Marek Vasut
2021-01-11 13:50 ` Heiner Kallweit
2021-01-11 14:10 ` Marek Vasut
2021-01-11 14:43 ` Heiner Kallweit
2021-01-12 22:28 ` Marek Vasut
2021-01-11 14:47 ` Andrew Lunn
2021-01-12 22:28 ` Marek Vasut
2021-01-14 13:54 ` Andrew Lunn
2021-01-15 12:45 ` Marek Vasut
2021-01-15 14:55 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101131413.Adz6ZgYL-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.