From: Marek Vasut <marex@denx.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY
Date: Tue, 12 Jan 2021 23:28:00 +0100 [thread overview]
Message-ID: <dd43881e-edff-74fd-dbcb-26c5ca5b6e72@denx.de> (raw)
In-Reply-To: <X/xlDTUQTLgVoaUE@lunn.ch>
On 1/11/21 3:47 PM, Andrew Lunn wrote:
> On Mon, Jan 11, 2021 at 01:53:37PM +0100, Marek Vasut wrote:
>> Unless the internal PHY is connected and started, the phylib will not
>> poll the PHY for state and produce state updates. Connect the PHY and
>> start/stop it.
>
> Hi Marek
>
> Please continue the conversion and remove all mii_calls.
>
> ks8851_set_link_ksettings() calling mii_ethtool_set_link_ksettings()
> is not good, phylib will not know about changes which we made to the
> PHY etc.
Hi,
I noticed a couple of drivers implement both the mii and mdiobus
options, I was pondering why is that. Is there some legacy backward
compatibility reason for keeping both or is it safe to remove the mii
support completely from the driver?
Either way, I will do that in a separate patch, so it could be reverted
if it breaks something.
next prev parent reply other threads:[~2021-01-12 22:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 12:53 [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY Marek Vasut
2021-01-11 13:26 ` Heiner Kallweit
2021-01-11 13:38 ` Marek Vasut
2021-01-11 13:50 ` Heiner Kallweit
2021-01-11 14:10 ` Marek Vasut
2021-01-11 14:43 ` Heiner Kallweit
2021-01-12 22:28 ` Marek Vasut
2021-01-11 14:47 ` Andrew Lunn
2021-01-12 22:28 ` Marek Vasut [this message]
2021-01-14 13:54 ` Andrew Lunn
2021-01-15 12:45 ` Marek Vasut
2021-01-15 14:55 ` Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2021-01-13 6:49 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd43881e-edff-74fd-dbcb-26c5ca5b6e72@denx.de \
--to=marex@denx.de \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.