All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
	Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY
Date: Fri, 15 Jan 2021 15:55:06 +0100	[thread overview]
Message-ID: <YAGsynozCNzyGfnI@lunn.ch> (raw)
In-Reply-To: <268090ca-06dd-d7e2-c06b-b9282f3cbe67@denx.de>

> > > I noticed a couple of drivers implement both the mii and mdiobus options.
> > 
> > Which ones?
> 
> boardcom b44.c and bcm63xx_enet.c for example

Thanks. I will take a look at those and maybe ask Florian.

> > Simply getting the link status might be safe, but if
> > set_link_ksettings() or get_link_ksettings() is used, phylib is going
> > to get confused when the PHY is changed without it knowing.. So please
> > do remove all the mii calls as part of the patchset.
> 
> Isn't that gonna break some ABI ?

I guess not, but i have no definitive answer. It should add more
features, not take any away.

> Also, is separate patch OK ?

It obviously works well enough that you have not run into issues. So i
guess anybody doing a git bisect will be O.K. if they land on the
state with both phydev and mii. So yes, a separate patch is O.K.

      Andrew

  reply	other threads:[~2021-01-15 14:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 12:53 [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY Marek Vasut
2021-01-11 13:26 ` Heiner Kallweit
2021-01-11 13:38   ` Marek Vasut
2021-01-11 13:50     ` Heiner Kallweit
2021-01-11 14:10       ` Marek Vasut
2021-01-11 14:43         ` Heiner Kallweit
2021-01-12 22:28           ` Marek Vasut
2021-01-11 14:47 ` Andrew Lunn
2021-01-12 22:28   ` Marek Vasut
2021-01-14 13:54     ` Andrew Lunn
2021-01-15 12:45       ` Marek Vasut
2021-01-15 14:55         ` Andrew Lunn [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-01-13  6:49 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAGsynozCNzyGfnI@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=hkallweit1@gmail.com \
    --cc=lukas@wunner.de \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.