* [PATCH] hw/block/nvme: add zoned I/O commands to nvme_io_opc_str()
@ 2021-01-15 13:48 Minwoo Im
2021-01-15 14:00 ` Klaus Jensen
0 siblings, 1 reply; 3+ messages in thread
From: Minwoo Im @ 2021-01-15 13:48 UTC (permalink / raw)
To: qemu-devel, qemu-block
Cc: Keith Busch, Klaus Jensen, Minwoo Im, Kevin Wolf, Max Reitz
Currently, Zoned I/O commands are parsed as unknown:
pci_nvme_io_cmd cid 768 nsid 1 sqid 4 opc 0x79 opname 'NVME_NVM_CMD_UNKNOWN'
Parse zoned I/O commands along with other I/O commands to print.
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
---
hw/block/nvme.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/block/nvme.h b/hw/block/nvme.h
index b7fbcca39d9f..0c1cb6fd2549 100644
--- a/hw/block/nvme.h
+++ b/hw/block/nvme.h
@@ -66,6 +66,9 @@ static inline const char *nvme_io_opc_str(uint8_t opc)
case NVME_CMD_READ: return "NVME_NVM_CMD_READ";
case NVME_CMD_WRITE_ZEROES: return "NVME_NVM_CMD_WRITE_ZEROES";
case NVME_CMD_DSM: return "NVME_NVM_CMD_DSM";
+ case NVME_CMD_ZONE_MGMT_SEND: return "NVME_NVM_CMD_ZONE_MGMT_SEND";
+ case NVME_CMD_ZONE_MGMT_RECV: return "NVME_NVM_CMD_ZONE_MGMT_RECV";
+ case NVME_CMD_ZONE_APPEND: return "NVME_NVM_CMD_ZONE_APPEND";
default: return "NVME_NVM_CMD_UNKNOWN";
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/block/nvme: add zoned I/O commands to nvme_io_opc_str()
2021-01-15 13:48 [PATCH] hw/block/nvme: add zoned I/O commands to nvme_io_opc_str() Minwoo Im
@ 2021-01-15 14:00 ` Klaus Jensen
2021-01-15 14:21 ` Minwoo Im
0 siblings, 1 reply; 3+ messages in thread
From: Klaus Jensen @ 2021-01-15 14:00 UTC (permalink / raw)
To: Minwoo Im; +Cc: Keith Busch, Kevin Wolf, qemu-devel, qemu-block, Max Reitz
[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]
On Jan 15 22:48, Minwoo Im wrote:
> Currently, Zoned I/O commands are parsed as unknown:
> pci_nvme_io_cmd cid 768 nsid 1 sqid 4 opc 0x79 opname 'NVME_NVM_CMD_UNKNOWN'
>
> Parse zoned I/O commands along with other I/O commands to print.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
> hw/block/nvme.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/block/nvme.h b/hw/block/nvme.h
> index b7fbcca39d9f..0c1cb6fd2549 100644
> --- a/hw/block/nvme.h
> +++ b/hw/block/nvme.h
> @@ -66,6 +66,9 @@ static inline const char *nvme_io_opc_str(uint8_t opc)
> case NVME_CMD_READ: return "NVME_NVM_CMD_READ";
> case NVME_CMD_WRITE_ZEROES: return "NVME_NVM_CMD_WRITE_ZEROES";
> case NVME_CMD_DSM: return "NVME_NVM_CMD_DSM";
> + case NVME_CMD_ZONE_MGMT_SEND: return "NVME_NVM_CMD_ZONE_MGMT_SEND";
> + case NVME_CMD_ZONE_MGMT_RECV: return "NVME_NVM_CMD_ZONE_MGMT_RECV";
> + case NVME_CMD_ZONE_APPEND: return "NVME_NVM_CMD_ZONE_APPEND";
> default: return "NVME_NVM_CMD_UNKNOWN";
> }
> }
> --
> 2.17.1
>
I have this in a series under review. Compare is also missing ;)
"[PATCH 5/6] hw/block/nvme: add missing string representations for commands"
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/block/nvme: add zoned I/O commands to nvme_io_opc_str()
2021-01-15 14:00 ` Klaus Jensen
@ 2021-01-15 14:21 ` Minwoo Im
0 siblings, 0 replies; 3+ messages in thread
From: Minwoo Im @ 2021-01-15 14:21 UTC (permalink / raw)
To: Klaus Jensen; +Cc: Keith Busch, Kevin Wolf, qemu-devel, qemu-block, Max Reitz
Oh, I think I missed that one :-).
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-15 14:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-15 13:48 [PATCH] hw/block/nvme: add zoned I/O commands to nvme_io_opc_str() Minwoo Im
2021-01-15 14:00 ` Klaus Jensen
2021-01-15 14:21 ` Minwoo Im
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.