* [PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL
@ 2020-11-20 4:10 ` Nishanth Menon
2020-11-23 4:26 ` Jaehoon Chung
2021-01-18 13:00 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Nishanth Menon @ 2020-11-20 4:10 UTC (permalink / raw)
To: u-boot
power/regulator will not be built if just CONFIG_SPL_DM_REGULATOR is
enabled. It needs CONFIG_SPL_POWER_SUPPORT to be enabled as well.
For example, if we just need a GPIO regulator in SPL:
CONFIG_DM_REGULATOR=y
CONFIG_SPL_DM_REGULATOR=y
CONFIG_DM_REGULATOR_GPIO=y
CONFIG_SPL_DM_REGULATOR_GPIO=y
Will not suffice, since the entire regulator build for SPL depends on
CONFIG_SPL_POWER_SUPPORT. Elaborate that information in the Kconfig
dependency.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
drivers/power/regulator/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/regulator/Kconfig b/drivers/power/regulator/Kconfig
index d431102462a8..fbbea18c7d1b 100644
--- a/drivers/power/regulator/Kconfig
+++ b/drivers/power/regulator/Kconfig
@@ -18,7 +18,7 @@ config DM_REGULATOR
config SPL_DM_REGULATOR
bool "Enable regulators for SPL"
- depends on DM_REGULATOR
+ depends on DM_REGULATOR && SPL_POWER_SUPPORT
---help---
Regulators are seldom needed in SPL. Even if they are accessed, some
code space can be saved by accessing the PMIC registers directly.
--
2.25.1.377.g2d2118b814c1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL
2020-11-20 4:10 ` [PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL Nishanth Menon
@ 2020-11-23 4:26 ` Jaehoon Chung
2021-01-18 13:00 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2020-11-23 4:26 UTC (permalink / raw)
To: u-boot
On 11/20/20 1:10 PM, Nishanth Menon wrote:
> power/regulator will not be built if just CONFIG_SPL_DM_REGULATOR is
> enabled. It needs CONFIG_SPL_POWER_SUPPORT to be enabled as well.
>
> For example, if we just need a GPIO regulator in SPL:
> CONFIG_DM_REGULATOR=y
> CONFIG_SPL_DM_REGULATOR=y
> CONFIG_DM_REGULATOR_GPIO=y
> CONFIG_SPL_DM_REGULATOR_GPIO=y
>
> Will not suffice, since the entire regulator build for SPL depends on
> CONFIG_SPL_POWER_SUPPORT. Elaborate that information in the Kconfig
> dependency.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> drivers/power/regulator/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/regulator/Kconfig b/drivers/power/regulator/Kconfig
> index d431102462a8..fbbea18c7d1b 100644
> --- a/drivers/power/regulator/Kconfig
> +++ b/drivers/power/regulator/Kconfig
> @@ -18,7 +18,7 @@ config DM_REGULATOR
>
> config SPL_DM_REGULATOR
> bool "Enable regulators for SPL"
> - depends on DM_REGULATOR
> + depends on DM_REGULATOR && SPL_POWER_SUPPORT
> ---help---
> Regulators are seldom needed in SPL. Even if they are accessed, some
> code space can be saved by accessing the PMIC registers directly.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL
2020-11-20 4:10 ` [PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL Nishanth Menon
2020-11-23 4:26 ` Jaehoon Chung
@ 2021-01-18 13:00 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-01-18 13:00 UTC (permalink / raw)
To: u-boot
On Thu, Nov 19, 2020 at 10:10:54PM -0600, Nishanth Menon wrote:
> power/regulator will not be built if just CONFIG_SPL_DM_REGULATOR is
> enabled. It needs CONFIG_SPL_POWER_SUPPORT to be enabled as well.
>
> For example, if we just need a GPIO regulator in SPL:
> CONFIG_DM_REGULATOR=y
> CONFIG_SPL_DM_REGULATOR=y
> CONFIG_DM_REGULATOR_GPIO=y
> CONFIG_SPL_DM_REGULATOR_GPIO=y
>
> Will not suffice, since the entire regulator build for SPL depends on
> CONFIG_SPL_POWER_SUPPORT. Elaborate that information in the Kconfig
> dependency.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/6d9aba40/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-18 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20201120041108epcas1p3de40e40d1d61f094d375f26fdd09a85b@epcas1p3.samsung.com>
2020-11-20 4:10 ` [PATCH] power: regulator: Kconfig: add a dependency for POWER_SUPPORT for SPL Nishanth Menon
2020-11-23 4:26 ` Jaehoon Chung
2021-01-18 13:00 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.