All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathew McBride <matt@traverse.com.au>
To: u-boot@lists.denx.de
Subject: [PATCH 3/3] spi: fsl_qspi: apply the same settings for LS1088 as LS208x
Date: Mon, 18 Jan 2021 23:52:56 +0000	[thread overview]
Message-ID: <20210118235256.29748-4-matt@traverse.com.au> (raw)
In-Reply-To: <20210118235256.29748-1-matt@traverse.com.au>

The LS1088 requires the same QUADSPI_QURIK_BASE_INTERNAL
workaround as the LS208x and also has a 64 byte TX buffer.

With the previous settings SPI-NAND reads over AHB were
corrupted.

Fixes: 91afd36f3802 ("spi: Transform the FSL QuadSPI driver to use the SPI MEM API")
Signed-off-by: Mathew McBride <matt@traverse.com.au>
---
 drivers/spi/fsl_qspi.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c
index 2a1f3a0c44..f965301d6a 100644
--- a/drivers/spi/fsl_qspi.c
+++ b/drivers/spi/fsl_qspi.c
@@ -259,14 +259,6 @@ static const struct fsl_qspi_devtype_data ls1021a_data = {
 	.little_endian = false,
 };
 
-static const struct fsl_qspi_devtype_data ls1088a_data = {
-	.rxfifo = SZ_128,
-	.txfifo = SZ_128,
-	.ahb_buf_size = SZ_1K,
-	.quirks = QUADSPI_QUIRK_TKT253890,
-	.little_endian = true,
-};
-
 static const struct fsl_qspi_devtype_data ls2080a_data = {
 	.rxfifo = SZ_128,
 	.txfifo = SZ_64,
@@ -877,7 +869,7 @@ static const struct udevice_id fsl_qspi_ids[] = {
 	{ .compatible = "fsl,imx7d-qspi", .data = (ulong)&imx7d_data, },
 	{ .compatible = "fsl,imx7ulp-qspi", .data = (ulong)&imx7ulp_data, },
 	{ .compatible = "fsl,ls1021a-qspi", .data = (ulong)&ls1021a_data, },
-	{ .compatible = "fsl,ls1088a-qspi", .data = (ulong)&ls1088a_data, },
+	{ .compatible = "fsl,ls1088a-qspi", .data = (ulong)&ls2080a_data, },
 	{ .compatible = "fsl,ls2080a-qspi", .data = (ulong)&ls2080a_data, },
 	{ }
 };
-- 
2.30.0

  parent reply	other threads:[~2021-01-18 23:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 23:52 [PATCH 0/3] Fixes for SPI-NAND issues on LS1088A Mathew McBride
2021-01-18 23:52 ` [PATCH 1/3] mem: spi-mem: define spi_mem_default_supports_op Mathew McBride
2021-01-19 12:06   ` Pratyush Yadav
2021-01-25  4:00     ` Mathew McBride
2021-01-18 23:52 ` [PATCH 2/3] spi: fsl_qspi: Ensure width is respected in spi-mem operations Mathew McBride
2021-01-18 23:52 ` Mathew McBride [this message]
2021-01-25  3:55 ` [PATCH v2 0/3] Fixes for SPI-NAND issues on LS1088A Mathew McBride
2021-01-25  3:55 ` [PATCH v2 1/3] mem: spi-mem: add declaration for spi_mem_default_supports_op Mathew McBride
2021-01-25  8:50   ` Pratyush Yadav
2021-01-25  3:55 ` [PATCH v2 2/3] spi: fsl_qspi: Ensure width is respected in spi-mem operations Mathew McBride
2021-01-25  3:55 ` [PATCH v2 3/3] spi: fsl_qspi: apply the same settings for LS1088 as LS208x Mathew McBride

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210118235256.29748-4-matt@traverse.com.au \
    --to=matt@traverse.com.au \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.