All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathew McBride <matt@traverse.com.au>
To: u-boot@lists.denx.de
Subject: [PATCH v2 0/3] Fixes for SPI-NAND issues on LS1088A
Date: Mon, 25 Jan 2021 03:55:19 +0000	[thread overview]
Message-ID: <20210125035521.23466-1-matt@traverse.com.au> (raw)
In-Reply-To: <20210118235256.29748-1-matt@traverse.com.au>

This patchset resolves issues seen when using SPI-NAND with the
LS1088A's qspi controller.

The main issue seen is data corruption when reading SPI-NAND, due to a
controller quirk not being applied.
Using the same settings as the LS2088A (the bigger brother of LS1088A) solves this issue.

In the course of debugging the above issue, it was found that the fsl_qspi
driver was not correctly reporting the operation width (single/dual/quad)
configured for the device in DTS.
(e.g I configured my device for single-lane reads only but quad operations were being issued)

A fix for this issue is already present in Linux and can be adapted for U-Boot,
providing a missing declaration for spi_mem_default_supports_op is added.

Changes in v2:
* Correct addition of declration for spi_mem_default_supports_op
The previous patch attempted to mirror how it was added to the Linux
kernel, which is not relevant to U-Boot

Mathew McBride (3):
  mem: spi-mem: add declaration for spi_mem_default_supports_op
  spi: fsl_qspi: Ensure width is respected in spi-mem operations
  spi: fsl_qspi: apply the same settings for LS1088 as LS208x

 drivers/spi/fsl_qspi.c | 12 ++----------
 include/spi-mem.h      |  3 +++
 2 files changed, 5 insertions(+), 10 deletions(-)

-- 
2.30.0

  parent reply	other threads:[~2021-01-25  3:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 23:52 [PATCH 0/3] Fixes for SPI-NAND issues on LS1088A Mathew McBride
2021-01-18 23:52 ` [PATCH 1/3] mem: spi-mem: define spi_mem_default_supports_op Mathew McBride
2021-01-19 12:06   ` Pratyush Yadav
2021-01-25  4:00     ` Mathew McBride
2021-01-18 23:52 ` [PATCH 2/3] spi: fsl_qspi: Ensure width is respected in spi-mem operations Mathew McBride
2021-01-18 23:52 ` [PATCH 3/3] spi: fsl_qspi: apply the same settings for LS1088 as LS208x Mathew McBride
2021-01-25  3:55 ` Mathew McBride [this message]
2021-01-25  3:55 ` [PATCH v2 1/3] mem: spi-mem: add declaration for spi_mem_default_supports_op Mathew McBride
2021-01-25  8:50   ` Pratyush Yadav
2021-01-25  3:55 ` [PATCH v2 2/3] spi: fsl_qspi: Ensure width is respected in spi-mem operations Mathew McBride
2021-01-25  3:55 ` [PATCH v2 3/3] spi: fsl_qspi: apply the same settings for LS1088 as LS208x Mathew McBride

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125035521.23466-1-matt@traverse.com.au \
    --to=matt@traverse.com.au \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.