From: Mathew McBride <matt@traverse.com.au>
To: u-boot@lists.denx.de
Subject: [PATCH v2 2/3] spi: fsl_qspi: Ensure width is respected in spi-mem operations
Date: Mon, 25 Jan 2021 03:55:21 +0000 [thread overview]
Message-ID: <20210125035521.23466-3-matt@traverse.com.au> (raw)
In-Reply-To: <20210118235256.29748-1-matt@traverse.com.au>
Adapted from kernel commit b0177aca7aea
From: Michael Walle <michael@walle.cc>
Make use of a core helper to ensure the desired width is respected
when calling spi-mem operators.
Otherwise only the SPI controller will be matched with the flash chip,
which might lead to wrong widths. Also consider the width specified by
the user in the device tree.
Fixes: 91afd36f38 ("spi: Add a driver for the Freescale/NXP QuadSPI controller")
Signed-off-by: Michael Walle <michael@walle.cc>
Link: https://lore.kernel.org/r/20200114154613.8195-1-michael at walle.cc
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Mathew McBride <matt@traverse.com.au> [adapt for U-Boot]
---
drivers/spi/fsl_qspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c
index 8bc7038a82..2a1f3a0c44 100644
--- a/drivers/spi/fsl_qspi.c
+++ b/drivers/spi/fsl_qspi.c
@@ -409,7 +409,7 @@ static bool fsl_qspi_supports_op(struct spi_slave *slave,
op->data.nbytes > q->devtype_data->txfifo)
return false;
- return true;
+ return spi_mem_default_supports_op(slave, op);
}
static void fsl_qspi_prepare_lut(struct fsl_qspi *q,
--
2.30.0
next prev parent reply other threads:[~2021-01-25 3:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 23:52 [PATCH 0/3] Fixes for SPI-NAND issues on LS1088A Mathew McBride
2021-01-18 23:52 ` [PATCH 1/3] mem: spi-mem: define spi_mem_default_supports_op Mathew McBride
2021-01-19 12:06 ` Pratyush Yadav
2021-01-25 4:00 ` Mathew McBride
2021-01-18 23:52 ` [PATCH 2/3] spi: fsl_qspi: Ensure width is respected in spi-mem operations Mathew McBride
2021-01-18 23:52 ` [PATCH 3/3] spi: fsl_qspi: apply the same settings for LS1088 as LS208x Mathew McBride
2021-01-25 3:55 ` [PATCH v2 0/3] Fixes for SPI-NAND issues on LS1088A Mathew McBride
2021-01-25 3:55 ` [PATCH v2 1/3] mem: spi-mem: add declaration for spi_mem_default_supports_op Mathew McBride
2021-01-25 8:50 ` Pratyush Yadav
2021-01-25 3:55 ` Mathew McBride [this message]
2021-01-25 3:55 ` [PATCH v2 3/3] spi: fsl_qspi: apply the same settings for LS1088 as LS208x Mathew McBride
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125035521.23466-3-matt@traverse.com.au \
--to=matt@traverse.com.au \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.