From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Steen Hegelund <steen.hegelund@microchip.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
linux-kernel@vger.kernel.org,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] reset: mchp: sparx5: add switch reset driver
Date: Tue, 19 Jan 2021 21:39:38 +0100 [thread overview]
Message-ID: <20210119203938.GQ3666@piout.net> (raw)
In-Reply-To: <20210119203710.GP3666@piout.net>
On 19/01/2021 21:37:16+0100, Alexandre Belloni wrote:
> On 14/01/2021 17:24:31+0100, Steen Hegelund wrote:
> > +static int sparx5_switch_reset(struct reset_controller_dev *rcdev,
> > + unsigned long id)
> > +{
> > + struct mchp_reset_context *ctx =
> > + container_of(rcdev, struct mchp_reset_context, rcdev);
> > + u32 val;
> > +
>
> I would ensure the reset only happens once here else I'm not sure how
> you could do it from the individual drivers.
>
Ok, the core is taking care of that, nice.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Steen Hegelund <steen.hegelund@microchip.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Gregory Clement <gregory.clement@bootlin.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] reset: mchp: sparx5: add switch reset driver
Date: Tue, 19 Jan 2021 21:39:38 +0100 [thread overview]
Message-ID: <20210119203938.GQ3666@piout.net> (raw)
In-Reply-To: <20210119203710.GP3666@piout.net>
On 19/01/2021 21:37:16+0100, Alexandre Belloni wrote:
> On 14/01/2021 17:24:31+0100, Steen Hegelund wrote:
> > +static int sparx5_switch_reset(struct reset_controller_dev *rcdev,
> > + unsigned long id)
> > +{
> > + struct mchp_reset_context *ctx =
> > + container_of(rcdev, struct mchp_reset_context, rcdev);
> > + u32 val;
> > +
>
> I would ensure the reset only happens once here else I'm not sure how
> you could do it from the individual drivers.
>
Ok, the core is taking care of that, nice.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-01-19 20:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 16:24 [PATCH v3 0/3] Adding the Sparx5 Switch Reset Driver Steen Hegelund
2021-01-14 16:24 ` Steen Hegelund
2021-01-14 16:24 ` [PATCH v3 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings Steen Hegelund
2021-01-14 16:24 ` Steen Hegelund
2021-01-19 20:35 ` Alexandre Belloni
2021-01-19 20:35 ` Alexandre Belloni
2021-01-20 7:51 ` Steen.Hegelund
2021-01-20 7:51 ` Steen.Hegelund
2021-01-14 16:24 ` [PATCH v3 2/3] reset: mchp: sparx5: add switch reset driver Steen Hegelund
2021-01-14 16:24 ` Steen Hegelund
2021-01-19 20:37 ` Alexandre Belloni
2021-01-19 20:37 ` Alexandre Belloni
2021-01-19 20:39 ` Alexandre Belloni [this message]
2021-01-19 20:39 ` Alexandre Belloni
2021-01-20 7:53 ` Steen Hegelund
2021-01-20 7:53 ` Steen Hegelund
2021-01-14 16:24 ` [PATCH v3 3/3] arm64: dts: reset: add microchip sparx5 " Steen Hegelund
2021-01-14 16:24 ` Steen Hegelund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119203938.GQ3666@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=steen.hegelund@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.