From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
Jie Yang <yang.jie@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
linux-kernel@vger.kernel.org,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v3 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data()
Date: Wed, 20 Jan 2021 10:02:51 +0000 [thread overview]
Message-ID: <20210120100251.GC106851@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20210117212252.206115-3-hdegoede@redhat.com>
On Sun, Jan 17, 2021 at 10:22:49PM +0100, Hans de Goede wrote:
> Replace the custom arizona_of_get_type() function with the generic
> device_get_match_data() helper. Besides being a nice cleanup this
> also makes it easier to add support for binding to ACPI enumerated
> devices.
>
> While at it also fix a possible NULL pointer deref of the id
> argument to the probe functions (this could happen on e.g. manual
> driver binding through sysfs).
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, <patches@opensource.cirrus.com>,
<linux-kernel@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
<alsa-devel@alsa-project.org>
Subject: Re: [PATCH v3 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data()
Date: Wed, 20 Jan 2021 10:02:51 +0000 [thread overview]
Message-ID: <20210120100251.GC106851@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20210117212252.206115-3-hdegoede@redhat.com>
On Sun, Jan 17, 2021 at 10:22:49PM +0100, Hans de Goede wrote:
> Replace the custom arizona_of_get_type() function with the generic
> device_get_match_data() helper. Besides being a nice cleanup this
> also makes it easier to add support for binding to ACPI enumerated
> devices.
>
> While at it also fix a possible NULL pointer deref of the id
> argument to the probe functions (this could happen on e.g. manual
> driver binding through sysfs).
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2021-01-20 10:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 21:22 [PATCH v3 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec Hans de Goede
2021-01-17 21:22 ` Hans de Goede
2021-01-17 21:22 ` [PATCH v3 1/5] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1") Hans de Goede
2021-01-17 21:22 ` Hans de Goede
2021-01-17 21:22 ` [PATCH v3 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data() Hans de Goede
2021-01-17 21:22 ` Hans de Goede
2021-01-18 11:51 ` Andy Shevchenko
2021-01-18 11:51 ` Andy Shevchenko
2021-01-20 10:02 ` Charles Keepax [this message]
2021-01-20 10:02 ` Charles Keepax
2021-01-17 21:22 ` [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI Hans de Goede
2021-01-17 21:22 ` Hans de Goede
2021-01-18 13:02 ` Mark Brown
2021-01-18 13:02 ` Mark Brown
2021-01-18 13:13 ` Hans de Goede
2021-01-18 13:13 ` Hans de Goede
2021-01-18 13:34 ` Mark Brown
2021-01-18 13:34 ` Mark Brown
2021-01-18 13:38 ` Hans de Goede
2021-01-18 13:38 ` Hans de Goede
2021-01-20 19:18 ` Hans de Goede
2021-01-20 19:18 ` Hans de Goede
2021-01-20 19:59 ` Andy Shevchenko
2021-01-20 19:59 ` Andy Shevchenko
2021-01-20 21:38 ` Hans de Goede
2021-01-20 21:38 ` Hans de Goede
2021-01-17 21:22 ` [PATCH v3 4/5] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr() Hans de Goede
2021-01-17 21:22 ` Hans de Goede
2021-01-17 21:22 ` [PATCH v3 5/5] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102 Hans de Goede
2021-01-17 21:22 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120100251.GC106851@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.