From: Hans de Goede <hdegoede@redhat.com>
To: Mark Brown <broonie@kernel.org>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Christian Hartmann <cornogle@googlemail.com>,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
Jie Yang <yang.jie@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
linux-kernel@vger.kernel.org,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI
Date: Mon, 18 Jan 2021 14:38:47 +0100 [thread overview]
Message-ID: <45a5de45-d7d9-8505-9009-3774a444f70f@redhat.com> (raw)
In-Reply-To: <20210118133449.GL4455@sirena.org.uk>
Hi,
On 1/18/21 2:34 PM, Mark Brown wrote:
> On Mon, Jan 18, 2021 at 02:13:50PM +0100, Hans de Goede wrote:
>
>> More in general I'm not aware of any (recent-ish) x86 GPIO controllers
>> not being able to do active low interrupts. In theory we could hit this
>> code path on ARM devices using ACPI enumeration, but I don't think it
>> is likely we will see a combination of ARM + ACPI enumeration +
>> WM5102 + GPIO controller not capable of active-low interrupts.
>
> I've not seen this issue on any ARM based systems.
>
>> This overriding of the flags definitely is necessary on the Lenovo
>> devices in question. I could add a
>> "if (dmi_name_in_vendors("LENOVO"))" guard around it, but that
>> seems unnecessary.
>
> Possibly just an update to the comment to make it clear that some
> firmwares might legitimately set the flag
That seems sensible, I will wait a bit to so if you (or someone)
has any more review remarks to this series and then send out
a v4 with the comment updated.
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Mark Brown <broonie@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
alsa-devel@alsa-project.org,
Christian Hartmann <cornogle@googlemail.com>
Subject: Re: [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI
Date: Mon, 18 Jan 2021 14:38:47 +0100 [thread overview]
Message-ID: <45a5de45-d7d9-8505-9009-3774a444f70f@redhat.com> (raw)
In-Reply-To: <20210118133449.GL4455@sirena.org.uk>
Hi,
On 1/18/21 2:34 PM, Mark Brown wrote:
> On Mon, Jan 18, 2021 at 02:13:50PM +0100, Hans de Goede wrote:
>
>> More in general I'm not aware of any (recent-ish) x86 GPIO controllers
>> not being able to do active low interrupts. In theory we could hit this
>> code path on ARM devices using ACPI enumeration, but I don't think it
>> is likely we will see a combination of ARM + ACPI enumeration +
>> WM5102 + GPIO controller not capable of active-low interrupts.
>
> I've not seen this issue on any ARM based systems.
>
>> This overriding of the flags definitely is necessary on the Lenovo
>> devices in question. I could add a
>> "if (dmi_name_in_vendors("LENOVO"))" guard around it, but that
>> seems unnecessary.
>
> Possibly just an update to the comment to make it clear that some
> firmwares might legitimately set the flag
That seems sensible, I will wait a bit to so if you (or someone)
has any more review remarks to this series and then send out
a v4 with the comment updated.
Regards,
Hans
next prev parent reply other threads:[~2021-01-18 13:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 21:22 [PATCH v3 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec Hans de Goede
2021-01-17 21:22 ` Hans de Goede
2021-01-17 21:22 ` [PATCH v3 1/5] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1") Hans de Goede
2021-01-17 21:22 ` Hans de Goede
2021-01-17 21:22 ` [PATCH v3 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data() Hans de Goede
2021-01-17 21:22 ` Hans de Goede
2021-01-18 11:51 ` Andy Shevchenko
2021-01-18 11:51 ` Andy Shevchenko
2021-01-20 10:02 ` Charles Keepax
2021-01-20 10:02 ` Charles Keepax
2021-01-17 21:22 ` [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI Hans de Goede
2021-01-17 21:22 ` Hans de Goede
2021-01-18 13:02 ` Mark Brown
2021-01-18 13:02 ` Mark Brown
2021-01-18 13:13 ` Hans de Goede
2021-01-18 13:13 ` Hans de Goede
2021-01-18 13:34 ` Mark Brown
2021-01-18 13:34 ` Mark Brown
2021-01-18 13:38 ` Hans de Goede [this message]
2021-01-18 13:38 ` Hans de Goede
2021-01-20 19:18 ` Hans de Goede
2021-01-20 19:18 ` Hans de Goede
2021-01-20 19:59 ` Andy Shevchenko
2021-01-20 19:59 ` Andy Shevchenko
2021-01-20 21:38 ` Hans de Goede
2021-01-20 21:38 ` Hans de Goede
2021-01-17 21:22 ` [PATCH v3 4/5] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr() Hans de Goede
2021-01-17 21:22 ` Hans de Goede
2021-01-17 21:22 ` [PATCH v3 5/5] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102 Hans de Goede
2021-01-17 21:22 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45a5de45-d7d9-8505-9009-3774a444f70f@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=cornogle@googlemail.com \
--cc=lee.jones@linaro.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.