[linux-platform-drivers-x86:review-hans 37/37] drivers/platform/x86/thinkpad_acpi.c:9999:27: sparse: sparse: symbol 'keyboard_lang_data' was not declared. Should it be

[linux-platform-drivers-x86:review-hans 37/37] drivers/platform/x86/thinkpad_acpi.c:9999:27: sparse: sparse: symbol 'keyboard_lang_data' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1469 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
head:   d7cbe2773aed0b636d48bb6795637eb486ecba6d
commit: d7cbe2773aed0b636d48bb6795637eb486ecba6d [37/37] platform/x86: thinkpad_acpi: set keyboard language
config: i386-randconfig-s001-20210125 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-20) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-212-g56dbccf5-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=d7cbe2773aed0b636d48bb6795637eb486ecba6d
        git remote add linux-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
        git fetch --no-tags linux-platform-drivers-x86 review-hans
        git checkout d7cbe2773aed0b636d48bb6795637eb486ecba6d
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> drivers/platform/x86/thinkpad_acpi.c:9999:27: sparse: sparse: symbol 'keyboard_lang_data' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32550 bytes --]

[RFC PATCH linux-platform-drivers-x86] platform/x86: thinkpad_acpi: keyboard_lang_data[] can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]


Fixes: d7cbe2773aed ("platform/x86: thinkpad_acpi: set keyboard language")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 thinkpad_acpi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 81f8ad6bb6886..85383b943a133 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -9996,7 +9996,7 @@ struct keyboard_lang_data {
  * When adding new entries to keyboard_lang_data, please check that
  * the select_lang[] buffer in keyboard_lang_show() is still large enough.
  */
-struct keyboard_lang_data keyboard_lang_data[] = {
+static struct keyboard_lang_data keyboard_lang_data[] = {
 	{"en", 0},
 	{"be", 0x080c},
 	{"cz", 0x0405},