From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Mike Rapoport <rppt@kernel.org>, Michal Hocko <mhocko@kernel.org>,
Wei Yang <richard.weiyang@linux.alibaba.com>
Subject: Re: [PATCH v1 2/2] mm: simplify free_highmem_page() and free_reserved_page()
Date: Wed, 27 Jan 2021 12:51:27 +0100 [thread overview]
Message-ID: <20210127115122.GA28728@linux> (raw)
In-Reply-To: <20210126182113.19892-3-david@redhat.com>
On Tue, Jan 26, 2021 at 07:21:13PM +0100, David Hildenbrand wrote:
> adjust_managed_page_count() as called by free_reserved_page() properly
> handles pages in a highmem zone, so we can reuse it for
> free_highmem_page().
>
> We can now get rid of totalhigh_pages_inc() and simplify
> free_reserved_page().
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Oscar Salvador <osalvador@suse.de>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
> +#define free_highmem_page(page) free_reserved_page(page)
Should we place that under #ifdef CONFIG_HIGHMEM to make clear
that it is only used on that config?
Maybe the #ifdefery ugliness does not pay off.
--
Oscar Salvador
SUSE L3
WARNING: multiple messages have this Message-ID (diff)
From: Oscar Salvador <osalvador@suse.de>
To: David Hildenbrand <david@redhat.com>
Cc: linux-fbdev@vger.kernel.org,
Wei Yang <richard.weiyang@linux.alibaba.com>,
"Peter Zijlstra \(Intel\)" <peterz@infradead.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v1 2/2] mm: simplify free_highmem_page() and free_reserved_page()
Date: Wed, 27 Jan 2021 12:51:27 +0100 [thread overview]
Message-ID: <20210127115122.GA28728@linux> (raw)
In-Reply-To: <20210126182113.19892-3-david@redhat.com>
On Tue, Jan 26, 2021 at 07:21:13PM +0100, David Hildenbrand wrote:
> adjust_managed_page_count() as called by free_reserved_page() properly
> handles pages in a highmem zone, so we can reuse it for
> free_highmem_page().
>
> We can now get rid of totalhigh_pages_inc() and simplify
> free_reserved_page().
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Oscar Salvador <osalvador@suse.de>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
> +#define free_highmem_page(page) free_reserved_page(page)
Should we place that under #ifdef CONFIG_HIGHMEM to make clear
that it is only used on that config?
Maybe the #ifdefery ugliness does not pay off.
--
Oscar Salvador
SUSE L3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-27 11:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 18:21 [PATCH v1 0/2] mm: simplify free_highmem_page() and free_reserved_page() David Hildenbrand
2021-01-26 18:21 ` David Hildenbrand
2021-01-26 18:21 ` [PATCH v1 1/2] video: fbdev: acornfb: remove free_unused_pages() David Hildenbrand
2021-01-26 18:21 ` David Hildenbrand
2021-01-27 8:44 ` Geert Uytterhoeven
2021-01-27 8:44 ` Geert Uytterhoeven
2021-01-27 11:53 ` Oscar Salvador
2021-01-27 11:53 ` Oscar Salvador
2021-01-28 3:54 ` Anshuman Khandual
2021-01-28 3:54 ` Anshuman Khandual
2021-01-26 18:21 ` [PATCH v1 2/2] mm: simplify free_highmem_page() and free_reserved_page() David Hildenbrand
2021-01-26 18:21 ` David Hildenbrand
2021-01-27 11:51 ` Oscar Salvador [this message]
2021-01-27 11:51 ` Oscar Salvador
2021-01-27 12:24 ` David Hildenbrand
2021-01-27 12:24 ` David Hildenbrand
2021-01-28 4:12 ` Anshuman Khandual
2021-01-28 4:12 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127115122.GA28728@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=peterz@infradead.org \
--cc=richard.weiyang@linux.alibaba.com \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.