From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net-next 12/12] net: dsa: tag_ocelot_8021q: add support for PTP timestamping
Date: Sat, 13 Feb 2021 15:42:46 +0800 [thread overview]
Message-ID: <202102131509.tNiKQPgX-lkp@intel.com> (raw)
In-Reply-To: <20210213001412.4154051-13-olteanv@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2127 bytes --]
Hi Vladimir,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3c5a2fd042d0bfac71a2dfb99515723d318df47b
config: i386-randconfig-a011-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/252148a7a654decce0740262c5425991fd53156e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857
git checkout 252148a7a654decce0740262c5425991fd53156e
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
ld: net/dsa/tag_ocelot_8021q.o: in function `ocelot_xmit_ptp':
>> net/dsa/tag_ocelot_8021q.c:34: undefined reference to `ocelot_port_inject_frame'
vim +34 net/dsa/tag_ocelot_8021q.c
15
16 static struct sk_buff *ocelot_xmit_ptp(struct dsa_port *dp,
17 struct sk_buff *skb,
18 struct sk_buff *clone)
19 {
20 struct ocelot *ocelot = dp->ds->priv;
21 struct ocelot_port *ocelot_port;
22 int port = dp->index;
23 u32 rew_op;
24
25 ocelot_port = ocelot->ports[port];
26 rew_op = ocelot_port->ptp_cmd;
27
28 /* Retrieve timestamp ID populated inside skb->cb[0] of the
29 * clone by ocelot_port_add_txtstamp_skb
30 */
31 if (ocelot_port->ptp_cmd == IFH_REW_OP_TWO_STEP_PTP)
32 rew_op |= clone->cb[0] << 3;
33
> 34 ocelot_port_inject_frame(ocelot, port, 0, rew_op, skb);
35
36 return NULL;
37 }
38
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39785 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net-next 12/12] net: dsa: tag_ocelot_8021q: add support for PTP timestamping
Date: Sat, 13 Feb 2021 15:42:46 +0800 [thread overview]
Message-ID: <202102131509.tNiKQPgX-lkp@intel.com> (raw)
In-Reply-To: <20210213001412.4154051-13-olteanv@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2068 bytes --]
Hi Vladimir,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3c5a2fd042d0bfac71a2dfb99515723d318df47b
config: i386-randconfig-a011-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/252148a7a654decce0740262c5425991fd53156e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857
git checkout 252148a7a654decce0740262c5425991fd53156e
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
ld: net/dsa/tag_ocelot_8021q.o: in function `ocelot_xmit_ptp':
>> net/dsa/tag_ocelot_8021q.c:34: undefined reference to `ocelot_port_inject_frame'
vim +34 net/dsa/tag_ocelot_8021q.c
15
16 static struct sk_buff *ocelot_xmit_ptp(struct dsa_port *dp,
17 struct sk_buff *skb,
18 struct sk_buff *clone)
19 {
20 struct ocelot *ocelot = dp->ds->priv;
21 struct ocelot_port *ocelot_port;
22 int port = dp->index;
23 u32 rew_op;
24
25 ocelot_port = ocelot->ports[port];
26 rew_op = ocelot_port->ptp_cmd;
27
28 /* Retrieve timestamp ID populated inside skb->cb[0] of the
29 * clone by ocelot_port_add_txtstamp_skb
30 */
31 if (ocelot_port->ptp_cmd == IFH_REW_OP_TWO_STEP_PTP)
32 rew_op |= clone->cb[0] << 3;
33
> 34 ocelot_port_inject_frame(ocelot, port, 0, rew_op, skb);
35
36 return NULL;
37 }
38
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39785 bytes --]
next prev parent reply other threads:[~2021-02-13 7:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 0:14 [PATCH net-next 00/12] PTP for DSA tag_ocelot_8021q Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 01/12] net: mscc: ocelot: stop returning IRQ_NONE in ocelot_xtr_irq_handler Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 02/12] net: mscc: ocelot: only drain extraction queue on error Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 03/12] net: mscc: ocelot: better error handling in ocelot_xtr_irq_handler Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 04/12] net: mscc: ocelot: use DIV_ROUND_UP helper in ocelot_port_inject_frame Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 05/12] net: mscc: ocelot: refactor ocelot_port_inject_frame out of ocelot_port_xmit Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 06/12] net: dsa: tag_ocelot: avoid accessing ds->priv in ocelot_rcv Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 07/12] net: mscc: ocelot: use common tag parsing code with DSA Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 08/12] net: dsa: tag_ocelot: single out PTP-related transmit tag processing Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville Vladimir Oltean
2021-02-15 13:00 ` Dan Carpenter
2021-02-15 13:00 ` Dan Carpenter
2021-02-15 13:00 ` Dan Carpenter
2021-02-15 13:19 ` Vladimir Oltean
2021-02-15 14:15 ` Dan Carpenter
2021-02-15 14:15 ` Dan Carpenter
2021-02-15 14:15 ` Dan Carpenter
2021-02-15 14:49 ` Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 10/12] net: mscc: ocelot: refactor ocelot_xtr_irq_handler into ocelot_xtr_poll Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 11/12] net: dsa: felix: setup MMIO filtering rules for PTP when using tag_8021q Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 12/12] net: dsa: tag_ocelot_8021q: add support for PTP timestamping Vladimir Oltean
2021-02-13 7:42 ` kernel test robot [this message]
2021-02-13 7:42 ` kernel test robot
2021-02-13 11:14 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102131509.tNiKQPgX-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.