From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville
Date: Mon, 15 Feb 2021 16:00:04 +0300 [thread overview]
Message-ID: <20210215130003.GL2087@kadam> (raw)
In-Reply-To: <20210213001412.4154051-10-olteanv@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2828 bytes --]
Hi Vladimir,
url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3c5a2fd042d0bfac71a2dfb99515723d318df47b
config: i386-randconfig-m031-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
net/dsa/tag_ocelot.c:59 ocelot_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type?
net/dsa/tag_ocelot.c:71 seville_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type?
vim +59 net/dsa/tag_ocelot.c
9d88a16c0fc930 Vladimir Oltean 2021-02-13 52 static struct sk_buff *ocelot_xmit(struct sk_buff *skb,
9d88a16c0fc930 Vladimir Oltean 2021-02-13 53 struct net_device *netdev)
9d88a16c0fc930 Vladimir Oltean 2021-02-13 54 {
9d88a16c0fc930 Vladimir Oltean 2021-02-13 55 struct dsa_port *dp = dsa_slave_to_port(netdev);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 56 void *injection;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 57
9d88a16c0fc930 Vladimir Oltean 2021-02-13 58 ocelot_xmit_common(skb, netdev, cpu_to_be32(0x8880000a), &injection);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 @59 ocelot_ifh_set_dest(injection, BIT(dp->index));
db->index is less than db->num_ports which 32 or less but sometimes it
comes from the device tree so who knows. The ocelot_ifh_set_dest()
function takes a u64 though and that suggests that BIT() should be
changed to BIT_ULL().
9d88a16c0fc930 Vladimir Oltean 2021-02-13 60
9d88a16c0fc930 Vladimir Oltean 2021-02-13 61 return skb;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 62 }
9d88a16c0fc930 Vladimir Oltean 2021-02-13 63
9d88a16c0fc930 Vladimir Oltean 2021-02-13 64 static struct sk_buff *seville_xmit(struct sk_buff *skb,
9d88a16c0fc930 Vladimir Oltean 2021-02-13 65 struct net_device *netdev)
9d88a16c0fc930 Vladimir Oltean 2021-02-13 66 {
9d88a16c0fc930 Vladimir Oltean 2021-02-13 67 struct dsa_port *dp = dsa_slave_to_port(netdev);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 68 void *injection;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 69
9d88a16c0fc930 Vladimir Oltean 2021-02-13 70 ocelot_xmit_common(skb, netdev, cpu_to_be32(0x88800005), &injection);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 @71 seville_ifh_set_dest(injection, BIT(dp->index));
Same.
9d88a16c0fc930 Vladimir Oltean 2021-02-13 72
8dce89aa5f3274 Vladimir Oltean 2019-11-14 73 return skb;
8dce89aa5f3274 Vladimir Oltean 2019-11-14 74 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42328 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville
Date: Mon, 15 Feb 2021 16:00:04 +0300 [thread overview]
Message-ID: <20210215130003.GL2087@kadam> (raw)
In-Reply-To: <20210213001412.4154051-10-olteanv@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2828 bytes --]
Hi Vladimir,
url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3c5a2fd042d0bfac71a2dfb99515723d318df47b
config: i386-randconfig-m031-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
net/dsa/tag_ocelot.c:59 ocelot_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type?
net/dsa/tag_ocelot.c:71 seville_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type?
vim +59 net/dsa/tag_ocelot.c
9d88a16c0fc930 Vladimir Oltean 2021-02-13 52 static struct sk_buff *ocelot_xmit(struct sk_buff *skb,
9d88a16c0fc930 Vladimir Oltean 2021-02-13 53 struct net_device *netdev)
9d88a16c0fc930 Vladimir Oltean 2021-02-13 54 {
9d88a16c0fc930 Vladimir Oltean 2021-02-13 55 struct dsa_port *dp = dsa_slave_to_port(netdev);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 56 void *injection;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 57
9d88a16c0fc930 Vladimir Oltean 2021-02-13 58 ocelot_xmit_common(skb, netdev, cpu_to_be32(0x8880000a), &injection);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 @59 ocelot_ifh_set_dest(injection, BIT(dp->index));
db->index is less than db->num_ports which 32 or less but sometimes it
comes from the device tree so who knows. The ocelot_ifh_set_dest()
function takes a u64 though and that suggests that BIT() should be
changed to BIT_ULL().
9d88a16c0fc930 Vladimir Oltean 2021-02-13 60
9d88a16c0fc930 Vladimir Oltean 2021-02-13 61 return skb;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 62 }
9d88a16c0fc930 Vladimir Oltean 2021-02-13 63
9d88a16c0fc930 Vladimir Oltean 2021-02-13 64 static struct sk_buff *seville_xmit(struct sk_buff *skb,
9d88a16c0fc930 Vladimir Oltean 2021-02-13 65 struct net_device *netdev)
9d88a16c0fc930 Vladimir Oltean 2021-02-13 66 {
9d88a16c0fc930 Vladimir Oltean 2021-02-13 67 struct dsa_port *dp = dsa_slave_to_port(netdev);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 68 void *injection;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 69
9d88a16c0fc930 Vladimir Oltean 2021-02-13 70 ocelot_xmit_common(skb, netdev, cpu_to_be32(0x88800005), &injection);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 @71 seville_ifh_set_dest(injection, BIT(dp->index));
Same.
9d88a16c0fc930 Vladimir Oltean 2021-02-13 72
8dce89aa5f3274 Vladimir Oltean 2019-11-14 73 return skb;
8dce89aa5f3274 Vladimir Oltean 2019-11-14 74 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42328 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville
Date: Mon, 15 Feb 2021 16:00:04 +0300 [thread overview]
Message-ID: <20210215130003.GL2087@kadam> (raw)
In-Reply-To: <20210213001412.4154051-10-olteanv@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2773 bytes --]
Hi Vladimir,
url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/PTP-for-DSA-tag_ocelot_8021q/20210213-081857
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3c5a2fd042d0bfac71a2dfb99515723d318df47b
config: i386-randconfig-m031-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
net/dsa/tag_ocelot.c:59 ocelot_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type?
net/dsa/tag_ocelot.c:71 seville_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type?
vim +59 net/dsa/tag_ocelot.c
9d88a16c0fc930 Vladimir Oltean 2021-02-13 52 static struct sk_buff *ocelot_xmit(struct sk_buff *skb,
9d88a16c0fc930 Vladimir Oltean 2021-02-13 53 struct net_device *netdev)
9d88a16c0fc930 Vladimir Oltean 2021-02-13 54 {
9d88a16c0fc930 Vladimir Oltean 2021-02-13 55 struct dsa_port *dp = dsa_slave_to_port(netdev);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 56 void *injection;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 57
9d88a16c0fc930 Vladimir Oltean 2021-02-13 58 ocelot_xmit_common(skb, netdev, cpu_to_be32(0x8880000a), &injection);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 @59 ocelot_ifh_set_dest(injection, BIT(dp->index));
db->index is less than db->num_ports which 32 or less but sometimes it
comes from the device tree so who knows. The ocelot_ifh_set_dest()
function takes a u64 though and that suggests that BIT() should be
changed to BIT_ULL().
9d88a16c0fc930 Vladimir Oltean 2021-02-13 60
9d88a16c0fc930 Vladimir Oltean 2021-02-13 61 return skb;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 62 }
9d88a16c0fc930 Vladimir Oltean 2021-02-13 63
9d88a16c0fc930 Vladimir Oltean 2021-02-13 64 static struct sk_buff *seville_xmit(struct sk_buff *skb,
9d88a16c0fc930 Vladimir Oltean 2021-02-13 65 struct net_device *netdev)
9d88a16c0fc930 Vladimir Oltean 2021-02-13 66 {
9d88a16c0fc930 Vladimir Oltean 2021-02-13 67 struct dsa_port *dp = dsa_slave_to_port(netdev);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 68 void *injection;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 69
9d88a16c0fc930 Vladimir Oltean 2021-02-13 70 ocelot_xmit_common(skb, netdev, cpu_to_be32(0x88800005), &injection);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 @71 seville_ifh_set_dest(injection, BIT(dp->index));
Same.
9d88a16c0fc930 Vladimir Oltean 2021-02-13 72
8dce89aa5f3274 Vladimir Oltean 2019-11-14 73 return skb;
8dce89aa5f3274 Vladimir Oltean 2019-11-14 74 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42328 bytes --]
next prev parent reply other threads:[~2021-02-15 13:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 0:14 [PATCH net-next 00/12] PTP for DSA tag_ocelot_8021q Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 01/12] net: mscc: ocelot: stop returning IRQ_NONE in ocelot_xtr_irq_handler Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 02/12] net: mscc: ocelot: only drain extraction queue on error Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 03/12] net: mscc: ocelot: better error handling in ocelot_xtr_irq_handler Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 04/12] net: mscc: ocelot: use DIV_ROUND_UP helper in ocelot_port_inject_frame Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 05/12] net: mscc: ocelot: refactor ocelot_port_inject_frame out of ocelot_port_xmit Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 06/12] net: dsa: tag_ocelot: avoid accessing ds->priv in ocelot_rcv Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 07/12] net: mscc: ocelot: use common tag parsing code with DSA Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 08/12] net: dsa: tag_ocelot: single out PTP-related transmit tag processing Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville Vladimir Oltean
2021-02-15 13:00 ` Dan Carpenter [this message]
2021-02-15 13:00 ` Dan Carpenter
2021-02-15 13:00 ` Dan Carpenter
2021-02-15 13:19 ` Vladimir Oltean
2021-02-15 14:15 ` Dan Carpenter
2021-02-15 14:15 ` Dan Carpenter
2021-02-15 14:15 ` Dan Carpenter
2021-02-15 14:49 ` Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 10/12] net: mscc: ocelot: refactor ocelot_xtr_irq_handler into ocelot_xtr_poll Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 11/12] net: dsa: felix: setup MMIO filtering rules for PTP when using tag_8021q Vladimir Oltean
2021-02-13 0:14 ` [PATCH net-next 12/12] net: dsa: tag_ocelot_8021q: add support for PTP timestamping Vladimir Oltean
2021-02-13 7:42 ` kernel test robot
2021-02-13 7:42 ` kernel test robot
2021-02-13 11:14 ` Vladimir Oltean
-- strict thread matches above, loose matches on Subject: below --
2021-02-13 2:32 [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215130003.GL2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.