From: Pavel Machek <pavel@ucw.cz>
To: kernel test robot <lkp@intel.com>, linux-leds@vger.kernel.org
Cc: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>,
kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
Date: Sun, 28 Feb 2021 09:29:13 +0100 [thread overview]
Message-ID: <20210228082913.GA27151@amd> (raw)
In-Reply-To: <202102280329.hv7RoHLA-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
Hi!
> >> drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
> gpiod_set_value(led->gpiod, val);
> ^
> drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean
> 'gpio_set_value'?
It looks like missing #include?
While at it, can you do something with Kconfig help text? Move
existing one into comment in the driver, add something useful for end-users.
Thank you,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: kbuild-all@lists.01.org
Subject: Re: drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
Date: Sun, 28 Feb 2021 09:29:13 +0100 [thread overview]
Message-ID: <20210228082913.GA27151@amd> (raw)
In-Reply-To: <202102280329.hv7RoHLA-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
Hi!
> >> drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
> gpiod_set_value(led->gpiod, val);
> ^
> drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean
> 'gpio_set_value'?
It looks like missing #include?
While at it, can you do something with Kconfig help text? Move
existing one into comment in the driver, add something useful for end-users.
Thank you,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-02-28 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 19:17 drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip' kernel test robot
2021-02-27 19:17 ` kernel test robot
2021-02-28 8:29 ` Pavel Machek [this message]
2021-02-28 8:29 ` Pavel Machek
2021-03-02 7:57 ` Randy Dunlap
2021-03-02 7:57 ` Randy Dunlap
2021-03-02 8:11 ` Pavel Machek
2021-03-02 8:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210228082913.GA27151@amd \
--to=pavel@ucw.cz \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mallikarjunax.reddy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.