* [PATCH bpf-next] selftests/bpf: fix compiler warning in BPF_KPROBE definition in loop6.c
@ 2021-03-09 4:43 Andrii Nakryiko
2021-03-09 5:29 ` Yonghong Song
0 siblings, 1 reply; 2+ messages in thread
From: Andrii Nakryiko @ 2021-03-09 4:43 UTC (permalink / raw)
To: bpf, netdev, ast, daniel; +Cc: andrii, kernel-team
Add missing return type to BPF_KPROBE definition. Without it, compiler
generates the following warning:
progs/loop6.c:68:12: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
BPF_KPROBE(trace_virtqueue_add_sgs, void *unused, struct scatterlist **sgs,
^
1 warning generated.
Fixes: 86a35af628e5 ("selftests/bpf: Add a verifier scale test with unknown bounded loop")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
tools/testing/selftests/bpf/progs/loop6.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/loop6.c b/tools/testing/selftests/bpf/progs/loop6.c
index 2a7141ac1656..38de0331e6b4 100644
--- a/tools/testing/selftests/bpf/progs/loop6.c
+++ b/tools/testing/selftests/bpf/progs/loop6.c
@@ -65,8 +65,8 @@ int config = 0;
int result = 0;
SEC("kprobe/virtqueue_add_sgs")
-BPF_KPROBE(trace_virtqueue_add_sgs, void *unused, struct scatterlist **sgs,
- unsigned int out_sgs, unsigned int in_sgs)
+int BPF_KPROBE(trace_virtqueue_add_sgs, void *unused, struct scatterlist **sgs,
+ unsigned int out_sgs, unsigned int in_sgs)
{
struct scatterlist *sgp = NULL;
__u64 length1 = 0, length2 = 0;
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH bpf-next] selftests/bpf: fix compiler warning in BPF_KPROBE definition in loop6.c
2021-03-09 4:43 [PATCH bpf-next] selftests/bpf: fix compiler warning in BPF_KPROBE definition in loop6.c Andrii Nakryiko
@ 2021-03-09 5:29 ` Yonghong Song
0 siblings, 0 replies; 2+ messages in thread
From: Yonghong Song @ 2021-03-09 5:29 UTC (permalink / raw)
To: Andrii Nakryiko, bpf, netdev, ast, daniel; +Cc: kernel-team
On 3/8/21 8:43 PM, Andrii Nakryiko wrote:
> Add missing return type to BPF_KPROBE definition. Without it, compiler
> generates the following warning:
>
> progs/loop6.c:68:12: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
> BPF_KPROBE(trace_virtqueue_add_sgs, void *unused, struct scatterlist **sgs,
> ^
> 1 warning generated.
>
> Fixes: 86a35af628e5 ("selftests/bpf: Add a verifier scale test with unknown bounded loop")
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Oh, my bad. Thanks for fixing it!
Acked-by: Yonghong Song <yhs@fb.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-09 5:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-09 4:43 [PATCH bpf-next] selftests/bpf: fix compiler warning in BPF_KPROBE definition in loop6.c Andrii Nakryiko
2021-03-09 5:29 ` Yonghong Song
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.