From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: [agd5f:amd-staging-drm-next 1823/1993] drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
Date: Wed, 10 Mar 2021 14:13:43 +0300 [thread overview]
Message-ID: <20210310111343.GK2087@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]
tree: https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head: dec2310256916626e4356af784822e02fb807cad
commit: 3387daae08120c05a9d6a0e37cfd792c638f0a92 [1823/1993] drm/amdgpu: support get xgmi information for Aldebaran
config: x86_64-randconfig-m001-20210309 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:97 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
vim +90 drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c
86 /* PF_MAX_REGION=0 means xgmi is disabled */
87 if (max_region || adev->gmc.xgmi.connected_to_cpu) {
88 adev->gmc.xgmi.num_physical_nodes = max_region + 1;
89
90 if (adev->gmc.xgmi.num_physical_nodes > max_num_physical_nodes)
91 return -EINVAL;
^^^^^^^^^^^^^^^
Missing tab
92
93 adev->gmc.xgmi.physical_node_id =
94 REG_GET_FIELD(xgmi_lfb_cntl, MC_VM_XGMI_LFB_CNTL,
95 PF_LFB_REGION);
96
97 if (adev->gmc.xgmi.physical_node_id > max_physical_node_id)
98 return -EINVAL;
^^^^^^^^^^^^^^^
Missing tab
99
100 adev->gmc.xgmi.node_segment_size = seg_size;
101 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41143 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [agd5f:amd-staging-drm-next 1823/1993] drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
Date: Wed, 10 Mar 2021 14:13:43 +0300 [thread overview]
Message-ID: <20210310111343.GK2087@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]
tree: https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head: dec2310256916626e4356af784822e02fb807cad
commit: 3387daae08120c05a9d6a0e37cfd792c638f0a92 [1823/1993] drm/amdgpu: support get xgmi information for Aldebaran
config: x86_64-randconfig-m001-20210309 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:97 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
vim +90 drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c
86 /* PF_MAX_REGION=0 means xgmi is disabled */
87 if (max_region || adev->gmc.xgmi.connected_to_cpu) {
88 adev->gmc.xgmi.num_physical_nodes = max_region + 1;
89
90 if (adev->gmc.xgmi.num_physical_nodes > max_num_physical_nodes)
91 return -EINVAL;
^^^^^^^^^^^^^^^
Missing tab
92
93 adev->gmc.xgmi.physical_node_id =
94 REG_GET_FIELD(xgmi_lfb_cntl, MC_VM_XGMI_LFB_CNTL,
95 PF_LFB_REGION);
96
97 if (adev->gmc.xgmi.physical_node_id > max_physical_node_id)
98 return -EINVAL;
^^^^^^^^^^^^^^^
Missing tab
99
100 adev->gmc.xgmi.node_segment_size = seg_size;
101 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41143 bytes --]
next reply other threads:[~2021-03-10 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 11:13 Dan Carpenter [this message]
2021-03-10 11:13 ` [agd5f:amd-staging-drm-next 1823/1993] drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2021-03-10 10:59 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310111343.GK2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.