* [agd5f:amd-staging-drm-next 1823/1993] drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
@ 2021-03-10 11:13 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-03-10 11:13 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]
tree: https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head: dec2310256916626e4356af784822e02fb807cad
commit: 3387daae08120c05a9d6a0e37cfd792c638f0a92 [1823/1993] drm/amdgpu: support get xgmi information for Aldebaran
config: x86_64-randconfig-m001-20210309 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:97 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
vim +90 drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c
86 /* PF_MAX_REGION=0 means xgmi is disabled */
87 if (max_region || adev->gmc.xgmi.connected_to_cpu) {
88 adev->gmc.xgmi.num_physical_nodes = max_region + 1;
89
90 if (adev->gmc.xgmi.num_physical_nodes > max_num_physical_nodes)
91 return -EINVAL;
^^^^^^^^^^^^^^^
Missing tab
92
93 adev->gmc.xgmi.physical_node_id =
94 REG_GET_FIELD(xgmi_lfb_cntl, MC_VM_XGMI_LFB_CNTL,
95 PF_LFB_REGION);
96
97 if (adev->gmc.xgmi.physical_node_id > max_physical_node_id)
98 return -EINVAL;
^^^^^^^^^^^^^^^
Missing tab
99
100 adev->gmc.xgmi.node_segment_size = seg_size;
101 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41143 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* [agd5f:amd-staging-drm-next 1823/1993] drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
@ 2021-03-10 11:13 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-03-10 11:13 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]
tree: https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head: dec2310256916626e4356af784822e02fb807cad
commit: 3387daae08120c05a9d6a0e37cfd792c638f0a92 [1823/1993] drm/amdgpu: support get xgmi information for Aldebaran
config: x86_64-randconfig-m001-20210309 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:97 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
vim +90 drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c
86 /* PF_MAX_REGION=0 means xgmi is disabled */
87 if (max_region || adev->gmc.xgmi.connected_to_cpu) {
88 adev->gmc.xgmi.num_physical_nodes = max_region + 1;
89
90 if (adev->gmc.xgmi.num_physical_nodes > max_num_physical_nodes)
91 return -EINVAL;
^^^^^^^^^^^^^^^
Missing tab
92
93 adev->gmc.xgmi.physical_node_id =
94 REG_GET_FIELD(xgmi_lfb_cntl, MC_VM_XGMI_LFB_CNTL,
95 PF_LFB_REGION);
96
97 if (adev->gmc.xgmi.physical_node_id > max_physical_node_id)
98 return -EINVAL;
^^^^^^^^^^^^^^^
Missing tab
99
100 adev->gmc.xgmi.node_segment_size = seg_size;
101 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41143 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [agd5f:amd-staging-drm-next 1823/1993] drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
@ 2021-03-10 10:59 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-03-10 10:59 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5180 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
CC: Alex Deucher <alexander.deucher@amd.com>
CC: Hawking Zhang <Hawking.Zhang@amd.com>
tree: https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head: dec2310256916626e4356af784822e02fb807cad
commit: 3387daae08120c05a9d6a0e37cfd792c638f0a92 [1823/1993] drm/amdgpu: support get xgmi information for Aldebaran
:::::: branch date: 9 hours ago
:::::: commit date: 5 days ago
config: x86_64-randconfig-m001-20210309 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:97 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented
vim +90 drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c
3387daae08120c Rajneesh Bhardwaj 2020-04-30 43
21470d97c9f8bb Kevin Wang 2020-10-14 44 int gfxhub_v1_1_get_xgmi_info(struct amdgpu_device *adev)
bf0a60b78b61a7 Alex Deucher 2018-06-19 45 {
3387daae08120c Rajneesh Bhardwaj 2020-04-30 46 u32 max_num_physical_nodes;
3387daae08120c Rajneesh Bhardwaj 2020-04-30 47 u32 max_physical_node_id;
3387daae08120c Rajneesh Bhardwaj 2020-04-30 48 u32 xgmi_lfb_cntl;
3387daae08120c Rajneesh Bhardwaj 2020-04-30 49 u32 max_region;
3387daae08120c Rajneesh Bhardwaj 2020-04-30 50 u64 seg_size;
3387daae08120c Rajneesh Bhardwaj 2020-04-30 51
3387daae08120c Rajneesh Bhardwaj 2020-04-30 52 if (adev->asic_type == CHIP_ALDEBARAN) {
3387daae08120c Rajneesh Bhardwaj 2020-04-30 53 xgmi_lfb_cntl = RREG32_SOC15(GC, 0, mmMC_VM_XGMI_LFB_CNTL_ALDE);
3387daae08120c Rajneesh Bhardwaj 2020-04-30 54 seg_size = REG_GET_FIELD(
3387daae08120c Rajneesh Bhardwaj 2020-04-30 55 RREG32_SOC15(GC, 0, mmMC_VM_XGMI_LFB_SIZE_ALDE),
3387daae08120c Rajneesh Bhardwaj 2020-04-30 56 MC_VM_XGMI_LFB_SIZE, PF_LFB_SIZE) << 24;
3387daae08120c Rajneesh Bhardwaj 2020-04-30 57 } else {
3387daae08120c Rajneesh Bhardwaj 2020-04-30 58 xgmi_lfb_cntl = RREG32_SOC15(GC, 0, mmMC_VM_XGMI_LFB_CNTL);
3387daae08120c Rajneesh Bhardwaj 2020-04-30 59 seg_size = REG_GET_FIELD(
3387daae08120c Rajneesh Bhardwaj 2020-04-30 60 RREG32_SOC15(GC, 0, mmMC_VM_XGMI_LFB_SIZE),
3387daae08120c Rajneesh Bhardwaj 2020-04-30 61 MC_VM_XGMI_LFB_SIZE, PF_LFB_SIZE) << 24;
3387daae08120c Rajneesh Bhardwaj 2020-04-30 62 }
3387daae08120c Rajneesh Bhardwaj 2020-04-30 63
3387daae08120c Rajneesh Bhardwaj 2020-04-30 64 max_region =
bf0a60b78b61a7 Alex Deucher 2018-06-19 65 REG_GET_FIELD(xgmi_lfb_cntl, MC_VM_XGMI_LFB_CNTL, PF_MAX_REGION);
3387daae08120c Rajneesh Bhardwaj 2020-04-30 66
f0312f45a0540a John Clements 2019-12-02 67
f0312f45a0540a John Clements 2019-12-02 68 switch (adev->asic_type) {
f0312f45a0540a John Clements 2019-12-02 69 case CHIP_VEGA20:
f0312f45a0540a John Clements 2019-12-02 70 max_num_physical_nodes = 4;
f0312f45a0540a John Clements 2019-12-02 71 max_physical_node_id = 3;
f0312f45a0540a John Clements 2019-12-02 72 break;
f0312f45a0540a John Clements 2019-12-02 73 case CHIP_ARCTURUS:
f0312f45a0540a John Clements 2019-12-02 74 max_num_physical_nodes = 8;
f0312f45a0540a John Clements 2019-12-02 75 max_physical_node_id = 7;
f0312f45a0540a John Clements 2019-12-02 76 break;
3387daae08120c Rajneesh Bhardwaj 2020-04-30 77 case CHIP_ALDEBARAN:
3387daae08120c Rajneesh Bhardwaj 2020-04-30 78 /* just using duplicates for Aldebaran support, revisit later */
3387daae08120c Rajneesh Bhardwaj 2020-04-30 79 max_num_physical_nodes = 8;
3387daae08120c Rajneesh Bhardwaj 2020-04-30 80 max_physical_node_id = 7;
3387daae08120c Rajneesh Bhardwaj 2020-04-30 81 break;
f0312f45a0540a John Clements 2019-12-02 82 default:
f0312f45a0540a John Clements 2019-12-02 83 return -EINVAL;
f0312f45a0540a John Clements 2019-12-02 84 }
bf0a60b78b61a7 Alex Deucher 2018-06-19 85
bf0a60b78b61a7 Alex Deucher 2018-06-19 86 /* PF_MAX_REGION=0 means xgmi is disabled */
3387daae08120c Rajneesh Bhardwaj 2020-04-30 87 if (max_region || adev->gmc.xgmi.connected_to_cpu) {
bf0a60b78b61a7 Alex Deucher 2018-06-19 88 adev->gmc.xgmi.num_physical_nodes = max_region + 1;
3387daae08120c Rajneesh Bhardwaj 2020-04-30 89
f0312f45a0540a John Clements 2019-12-02 @90 if (adev->gmc.xgmi.num_physical_nodes > max_num_physical_nodes)
:::::: The code at line 90 was first introduced by commit
:::::: f0312f45a0540a1551ca4644ff2461250520111a drm/amdgpu: Added ASIC specific checks in gfxhub V1.1 get XGMI info
:::::: TO: John Clements <john.clements@amd.com>
:::::: CC: Alex Deucher <alexander.deucher@amd.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41143 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-10 11:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-10 11:13 [agd5f:amd-staging-drm-next 1823/1993] drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c:90 gfxhub_v1_1_get_xgmi_info() warn: if statement not indented Dan Carpenter
2021-03-10 11:13 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2021-03-10 10:59 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.