All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	jonathanh@nvidia.com, thierry.reding@gmail.com,
	linux-tegra@vger.kernel.org, will@kernel.org
Subject: Re: [PATCH v2] iommu/tegra-smmu: Add pagetable mappings to debugfs
Date: Wed, 10 Mar 2021 14:08:09 -0800	[thread overview]
Message-ID: <20210310220808.GA10431@Asurada-Nvidia> (raw)
In-Reply-To: <cc5dca8f-e9b0-a845-1af4-e762782d5441@gmail.com>

On Wed, Mar 10, 2021 at 11:38:47PM +0300, Dmitry Osipenko wrote:
> 10.03.2021 06:36, Nicolin Chen пишет:
> > This patch dumps all active mapping entries from pagetable
> > to a debugfs directory named "mappings".
> > 
> > Ataching an example:
> > 
> > SWGROUP: hc
> > ASID: 0
> > reg: 0x250
> > PTB_ASID: 0xe0080004
> > as->pd_dma: 0x80004000
> > {
> >         [1023] 0xf0080013 (1)
> >         {
> >                 PTE RANGE       PHYS           IOVA        SIZE        ATTR
> >                 #1023 - #1023   0x122e5e000    0xfffff000  0x1000      0x5
> >         }
> > }
> > Total PDE count: 1
> > Total PTE count: 1
> 
> Addresses are 32bit on ARM32, please fix the formatting. The phys_addr_t
> and dma_addr_t have special printk specifiers [1].
> 
> [1]
> https://www.kernel.org/doc/html/latest/core-api/printk-formats.html?highlight=printk#physical-address-types-phys-addr-t
> 
> as->pd_dma: 0xc026e81b0000026c
> {
>         [0] 0xf0082848 (1024)
>         {
>                 PTE RANGE       PHYS           IOVA        SIZE
> ATTR
>                 #0    - #15     0xc0f9fc40bfde0000 0x0         0x10000

Thanks for the feedback! I will send v3.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: joro@8bytes.org, thierry.reding@gmail.com, will@kernel.org,
	vdumpa@nvidia.com, jonathanh@nvidia.com,
	linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iommu/tegra-smmu: Add pagetable mappings to debugfs
Date: Wed, 10 Mar 2021 14:08:09 -0800	[thread overview]
Message-ID: <20210310220808.GA10431@Asurada-Nvidia> (raw)
In-Reply-To: <cc5dca8f-e9b0-a845-1af4-e762782d5441@gmail.com>

On Wed, Mar 10, 2021 at 11:38:47PM +0300, Dmitry Osipenko wrote:
> 10.03.2021 06:36, Nicolin Chen пишет:
> > This patch dumps all active mapping entries from pagetable
> > to a debugfs directory named "mappings".
> > 
> > Ataching an example:
> > 
> > SWGROUP: hc
> > ASID: 0
> > reg: 0x250
> > PTB_ASID: 0xe0080004
> > as->pd_dma: 0x80004000
> > {
> >         [1023] 0xf0080013 (1)
> >         {
> >                 PTE RANGE       PHYS           IOVA        SIZE        ATTR
> >                 #1023 - #1023   0x122e5e000    0xfffff000  0x1000      0x5
> >         }
> > }
> > Total PDE count: 1
> > Total PTE count: 1
> 
> Addresses are 32bit on ARM32, please fix the formatting. The phys_addr_t
> and dma_addr_t have special printk specifiers [1].
> 
> [1]
> https://www.kernel.org/doc/html/latest/core-api/printk-formats.html?highlight=printk#physical-address-types-phys-addr-t
> 
> as->pd_dma: 0xc026e81b0000026c
> {
>         [0] 0xf0082848 (1024)
>         {
>                 PTE RANGE       PHYS           IOVA        SIZE
> ATTR
>                 #0    - #15     0xc0f9fc40bfde0000 0x0         0x10000

Thanks for the feedback! I will send v3.

  reply	other threads:[~2021-03-10 22:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10  3:36 [PATCH v2] iommu/tegra-smmu: Add pagetable mappings to debugfs Nicolin Chen
2021-03-10  3:36 ` Nicolin Chen
2021-03-10 20:38 ` Dmitry Osipenko
2021-03-10 20:38   ` Dmitry Osipenko
2021-03-10 22:08   ` Nicolin Chen [this message]
2021-03-10 22:08     ` Nicolin Chen
2021-03-11 14:04 ` Dmitry Osipenko
2021-03-11 14:04   ` Dmitry Osipenko
2021-03-12  1:09   ` Nicolin Chen
2021-03-12  1:09     ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210310220808.GA10431@Asurada-Nvidia \
    --to=nicoleotsuka@gmail.com \
    --cc=digetx@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.