From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
jonathanh@nvidia.com, thierry.reding@gmail.com,
linux-tegra@vger.kernel.org, will@kernel.org
Subject: Re: [PATCH v2] iommu/tegra-smmu: Add pagetable mappings to debugfs
Date: Thu, 11 Mar 2021 17:09:33 -0800 [thread overview]
Message-ID: <20210312010932.GB29926@Asurada-Nvidia> (raw)
In-Reply-To: <abcedfa6-fbad-b34d-fba1-d3a778fbf5b4@gmail.com>
On Thu, Mar 11, 2021 at 05:04:06PM +0300, Dmitry Osipenko wrote:
> 10.03.2021 06:36, Nicolin Chen пишет:
> ...
> > +static int tegra_smmu_mappings_show(struct seq_file *s, void *data)
> > +{
> > + struct tegra_smmu_group_debug *group_debug = s->private;
> > + const struct tegra_smmu_swgroup *group;
> > + struct tegra_smmu_as *as;
> > + struct tegra_smmu *smmu;
> > + int pd_index, pt_index;
>
> > +DEFINE_SHOW_ATTRIBUTE(tegra_smmu_mappings);
> > +
> > static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu)
> > {
> > + const struct tegra_smmu_soc *soc = smmu->soc;
> > + struct tegra_smmu_group_debug *group_debug;
> > + struct device *dev = smmu->dev;
> > + struct dentry *d;
> > + int i;
>
> You should use unsigned types for everything that isn't signed.
Okay. Will fix. Thanks!
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: joro@8bytes.org, thierry.reding@gmail.com, will@kernel.org,
vdumpa@nvidia.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iommu/tegra-smmu: Add pagetable mappings to debugfs
Date: Thu, 11 Mar 2021 17:09:33 -0800 [thread overview]
Message-ID: <20210312010932.GB29926@Asurada-Nvidia> (raw)
In-Reply-To: <abcedfa6-fbad-b34d-fba1-d3a778fbf5b4@gmail.com>
On Thu, Mar 11, 2021 at 05:04:06PM +0300, Dmitry Osipenko wrote:
> 10.03.2021 06:36, Nicolin Chen пишет:
> ...
> > +static int tegra_smmu_mappings_show(struct seq_file *s, void *data)
> > +{
> > + struct tegra_smmu_group_debug *group_debug = s->private;
> > + const struct tegra_smmu_swgroup *group;
> > + struct tegra_smmu_as *as;
> > + struct tegra_smmu *smmu;
> > + int pd_index, pt_index;
>
> > +DEFINE_SHOW_ATTRIBUTE(tegra_smmu_mappings);
> > +
> > static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu)
> > {
> > + const struct tegra_smmu_soc *soc = smmu->soc;
> > + struct tegra_smmu_group_debug *group_debug;
> > + struct device *dev = smmu->dev;
> > + struct dentry *d;
> > + int i;
>
> You should use unsigned types for everything that isn't signed.
Okay. Will fix. Thanks!
next prev parent reply other threads:[~2021-03-12 1:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 3:36 [PATCH v2] iommu/tegra-smmu: Add pagetable mappings to debugfs Nicolin Chen
2021-03-10 3:36 ` Nicolin Chen
2021-03-10 20:38 ` Dmitry Osipenko
2021-03-10 20:38 ` Dmitry Osipenko
2021-03-10 22:08 ` Nicolin Chen
2021-03-10 22:08 ` Nicolin Chen
2021-03-11 14:04 ` Dmitry Osipenko
2021-03-11 14:04 ` Dmitry Osipenko
2021-03-12 1:09 ` Nicolin Chen [this message]
2021-03-12 1:09 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312010932.GB29926@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=digetx@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.