All of lore.kernel.org
 help / color / mirror / Atom feed
* staging: rtl8723bs: remove unused code blocks completed?
@ 2021-03-17  9:59 Fabio Aiuto
  2021-03-17 10:02 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Aiuto @ 2021-03-17  9:59 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel

Hi,

I'm trying to search other unused code blocks:

grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_' drivers/staging/rtl8723bs/

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM)
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM)
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:#if defined(CONFIG_WEXT_PRIV)
drivers/staging/rtl8723bs/include/drv_conf.h:#ifndef CONFIG_RTW_HIQ_FILTER
drivers/staging/rtl8723bs/include/autoconf.h:#ifndef CONFIG_WIRELESS_EXT

all blocks left are checked by existing defines.
Could we apply this?

thank you,

fabio

diff --git a/drivers/staging/rtl8723bs/TODO b/drivers/staging/rtl8723bs/TODO
index 45065fd3fd5d..afa620ceb2d8 100644
--- a/drivers/staging/rtl8723bs/TODO
+++ b/drivers/staging/rtl8723bs/TODO
@@ -1,5 +1,4 @@
 TODO:
-- find and remove code blocks guarded by never set CONFIG_FOO defines
 - find and remove remaining code valid only for 5 GHz. Most of the obvious
   ones have been removed, but things like channel > 14 still exist.
 - find and remove any code for other chips that is left over

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: staging: rtl8723bs: remove unused code blocks completed?
  2021-03-17  9:59 staging: rtl8723bs: remove unused code blocks completed? Fabio Aiuto
@ 2021-03-17 10:02 ` Greg KH
  2021-03-17 10:51   ` [PATCH] staging: rtl8723bs: remove unused code blocks completed Fabio Aiuto
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2021-03-17 10:02 UTC (permalink / raw)
  To: Fabio Aiuto; +Cc: devel, linux-kernel

On Wed, Mar 17, 2021 at 10:59:32AM +0100, Fabio Aiuto wrote:
> Hi,
> 
> I'm trying to search other unused code blocks:
> 
> grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_' drivers/staging/rtl8723bs/
> 
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM)
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM)
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:#if defined(CONFIG_WEXT_PRIV)
> drivers/staging/rtl8723bs/include/drv_conf.h:#ifndef CONFIG_RTW_HIQ_FILTER
> drivers/staging/rtl8723bs/include/autoconf.h:#ifndef CONFIG_WIRELESS_EXT
> 
> all blocks left are checked by existing defines.
> Could we apply this?

Sure, looks good, submit this as a real patch with this information in
the changelog and I"ll be glad to take it.

thanks,
greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH] staging: rtl8723bs: remove unused code blocks completed
  2021-03-17 10:02 ` Greg KH
@ 2021-03-17 10:51   ` Fabio Aiuto
  0 siblings, 0 replies; 3+ messages in thread
From: Fabio Aiuto @ 2021-03-17 10:51 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel, Fabio Aiuto

Remove related item in TODO list

-------------------------------------------------------

searched for other unused code blocks:

grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_' \
drivers/staging/rtl8723bs/

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM)
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM)
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:#if defined(CONFIG_WEXT_PRIV)
drivers/staging/rtl8723bs/include/drv_conf.h:#ifndef CONFIG_RTW_HIQ_FILTER
drivers/staging/rtl8723bs/include/autoconf.h:#ifndef CONFIG_WIRELESS_EXT

all blocks left are checked by existing defines.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/TODO | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/TODO b/drivers/staging/rtl8723bs/TODO
index 45065fd3fd5d..afa620ceb2d8 100644
--- a/drivers/staging/rtl8723bs/TODO
+++ b/drivers/staging/rtl8723bs/TODO
@@ -1,5 +1,4 @@
 TODO:
-- find and remove code blocks guarded by never set CONFIG_FOO defines
 - find and remove remaining code valid only for 5 GHz. Most of the obvious
   ones have been removed, but things like channel > 14 still exist.
 - find and remove any code for other chips that is left over
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-17 10:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-17  9:59 staging: rtl8723bs: remove unused code blocks completed? Fabio Aiuto
2021-03-17 10:02 ` Greg KH
2021-03-17 10:51   ` [PATCH] staging: rtl8723bs: remove unused code blocks completed Fabio Aiuto

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.