All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alain Volmat <alain.volmat@foss.st.com>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: <pierre-yves.mordret@foss.st.com>, <mcoquelin.stm32@gmail.com>,
	<alexandre.torgue@foss.st.com>, <p.zabel@pengutronix.de>,
	<sumit.semwal@linaro.org>, <christian.koenig@amd.com>,
	<linux-i2c@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] i2c: stm32f7: Remove useless error message
Date: Thu, 25 Mar 2021 13:46:47 +0100	[thread overview]
Message-ID: <20210325124647.GA29312@gnbcxd0016.gnb.st.com> (raw)
In-Reply-To: <1616673872-4382-1-git-send-email-tiantao6@hisilicon.com>

Hello,

Thanks for the patch.

Reviewed-by: Alain Volmat <alain.volmat@foss.st.com>

Alain

On Thu, Mar 25, 2021 at 08:04:32PM +0800, Tian Tao wrote:
> Fix the following coccicheck report:
> 
> drivers/i2c/busses/i2c-stm32f7.c:2032:3-10 : platform_get_irq :
> line 2032 is redundant because platform_get_irq() already prints an error
> 
> Remove dev_err() messages after platform_get_irq() failures.
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
> ---
>  drivers/i2c/busses/i2c-stm32f7.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 162a3b0..9fbcbd1 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -2035,12 +2035,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
>  	phy_addr = (dma_addr_t)res->start;
>  
>  	irq_event = platform_get_irq(pdev, 0);
> -	if (irq_event <= 0) {
> -		if (irq_event != -EPROBE_DEFER)
> -			dev_err(&pdev->dev, "Failed to get IRQ event: %d\n",
> -				irq_event);
> +	if (irq_event <= 0)
>  		return irq_event ? : -ENOENT;
> -	}
>  
>  	irq_error = platform_get_irq(pdev, 1);
>  	if (irq_error <= 0)
> -- 
> 2.7.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: Alain Volmat <alain.volmat@foss.st.com>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: <pierre-yves.mordret@foss.st.com>, <mcoquelin.stm32@gmail.com>,
	<alexandre.torgue@foss.st.com>, <p.zabel@pengutronix.de>,
	<sumit.semwal@linaro.org>, <christian.koenig@amd.com>,
	<linux-i2c@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] i2c: stm32f7: Remove useless error message
Date: Thu, 25 Mar 2021 13:46:47 +0100	[thread overview]
Message-ID: <20210325124647.GA29312@gnbcxd0016.gnb.st.com> (raw)
In-Reply-To: <1616673872-4382-1-git-send-email-tiantao6@hisilicon.com>

Hello,

Thanks for the patch.

Reviewed-by: Alain Volmat <alain.volmat@foss.st.com>

Alain

On Thu, Mar 25, 2021 at 08:04:32PM +0800, Tian Tao wrote:
> Fix the following coccicheck report:
> 
> drivers/i2c/busses/i2c-stm32f7.c:2032:3-10 : platform_get_irq :
> line 2032 is redundant because platform_get_irq() already prints an error
> 
> Remove dev_err() messages after platform_get_irq() failures.
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
> ---
>  drivers/i2c/busses/i2c-stm32f7.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 162a3b0..9fbcbd1 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -2035,12 +2035,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
>  	phy_addr = (dma_addr_t)res->start;
>  
>  	irq_event = platform_get_irq(pdev, 0);
> -	if (irq_event <= 0) {
> -		if (irq_event != -EPROBE_DEFER)
> -			dev_err(&pdev->dev, "Failed to get IRQ event: %d\n",
> -				irq_event);
> +	if (irq_event <= 0)
>  		return irq_event ? : -ENOENT;
> -	}
>  
>  	irq_error = platform_get_irq(pdev, 1);
>  	if (irq_error <= 0)
> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-25 12:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25 12:04 [PATCH] i2c: stm32f7: Remove useless error message Tian Tao
2021-03-25 12:04 ` Tian Tao
2021-03-25 12:46 ` Alain Volmat [this message]
2021-03-25 12:46   ` Alain Volmat
2021-03-31  7:58 ` Wolfram Sang
2021-03-31  7:58   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210325124647.GA29312@gnbcxd0016.gnb.st.com \
    --to=alain.volmat@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=christian.koenig@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pierre-yves.mordret@foss.st.com \
    --cc=sumit.semwal@linaro.org \
    --cc=tiantao6@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.