All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Chen Lifu <chenlifu@huawei.com>
Cc: will@kernel.org, valentin.schneider@arm.com, maz@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, heying24@huawei.com,
	yuehaibing@huawei.com, weiyongjun1@huawei.com,
	johnny.chenyi@huawei.com
Subject: Re: [PATCH -next] arm64: smp: Add missing prototype for some smp.c functions
Date: Sun, 28 Mar 2021 18:21:48 +0100	[thread overview]
Message-ID: <20210328172147.GA19252@arm.com> (raw)
In-Reply-To: <20210327070651.70773-1-chenlifu@huawei.com>

On Sat, Mar 27, 2021 at 03:06:51PM +0800, Chen Lifu wrote:
> In commit eb631bb5bf5b
> ("arm64: Support arch_irq_work_raise() via self IPIs") a new
> function "arch_irq_work_raise" was added without a prototype
> in header irq_work.h
> 
> In commit d914d4d49745
> ("arm64: Implement panic_smp_self_stop()") a new
> function "panic_smp_self_stop" was added without a prototype
> in header irq_work.h
> 
> We get the following warnings on W=1:
> arch/arm64/kernel/smp.c:842:6: warning: no previous prototype
> for ‘arch_irq_work_raise’ [-Wmissing-prototypes]
> arch/arm64/kernel/smp.c:862:6: warning: no previous prototype
> for ‘panic_smp_self_stop’ [-Wmissing-prototypes]
> 
> Fix the same by adding the missing prototype in header irq_work.h
> 
> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
> ---
>  arch/arm64/include/asm/irq_work.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h
> index a1020285ea75..f766e2190e7c 100644
> --- a/arch/arm64/include/asm/irq_work.h
> +++ b/arch/arm64/include/asm/irq_work.h
> @@ -2,6 +2,9 @@
>  #ifndef __ASM_IRQ_WORK_H
>  #define __ASM_IRQ_WORK_H
>  
> +extern void arch_irq_work_raise(void);
> +extern void panic_smp_self_stop(void);

The second prototype makes more sense in arch/arm64/include/asm/smp.h
where we already have crash_smp_send_stop().

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Chen Lifu <chenlifu@huawei.com>
Cc: will@kernel.org, valentin.schneider@arm.com, maz@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, heying24@huawei.com,
	yuehaibing@huawei.com, weiyongjun1@huawei.com,
	johnny.chenyi@huawei.com
Subject: Re: [PATCH -next] arm64: smp: Add missing prototype for some smp.c functions
Date: Sun, 28 Mar 2021 18:21:48 +0100	[thread overview]
Message-ID: <20210328172147.GA19252@arm.com> (raw)
In-Reply-To: <20210327070651.70773-1-chenlifu@huawei.com>

On Sat, Mar 27, 2021 at 03:06:51PM +0800, Chen Lifu wrote:
> In commit eb631bb5bf5b
> ("arm64: Support arch_irq_work_raise() via self IPIs") a new
> function "arch_irq_work_raise" was added without a prototype
> in header irq_work.h
> 
> In commit d914d4d49745
> ("arm64: Implement panic_smp_self_stop()") a new
> function "panic_smp_self_stop" was added without a prototype
> in header irq_work.h
> 
> We get the following warnings on W=1:
> arch/arm64/kernel/smp.c:842:6: warning: no previous prototype
> for ‘arch_irq_work_raise’ [-Wmissing-prototypes]
> arch/arm64/kernel/smp.c:862:6: warning: no previous prototype
> for ‘panic_smp_self_stop’ [-Wmissing-prototypes]
> 
> Fix the same by adding the missing prototype in header irq_work.h
> 
> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
> ---
>  arch/arm64/include/asm/irq_work.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h
> index a1020285ea75..f766e2190e7c 100644
> --- a/arch/arm64/include/asm/irq_work.h
> +++ b/arch/arm64/include/asm/irq_work.h
> @@ -2,6 +2,9 @@
>  #ifndef __ASM_IRQ_WORK_H
>  #define __ASM_IRQ_WORK_H
>  
> +extern void arch_irq_work_raise(void);
> +extern void panic_smp_self_stop(void);

The second prototype makes more sense in arch/arm64/include/asm/smp.h
where we already have crash_smp_send_stop().

-- 
Catalin

  reply	other threads:[~2021-03-29 21:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27  7:06 [PATCH -next] arm64: smp: Add missing prototype for some smp.c functions Chen Lifu
2021-03-27  7:06 ` Chen Lifu
2021-03-28 17:21 ` Catalin Marinas [this message]
2021-03-28 17:21   ` Catalin Marinas
2021-03-29  3:43   ` [PATCH v2 " Chen Lifu
2021-03-29  3:43     ` Chen Lifu
2021-03-29 12:28     ` Catalin Marinas
2021-03-29 12:28       ` Catalin Marinas
2021-03-30  1:37       ` chenlifu
2021-03-30  1:37         ` chenlifu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210328172147.GA19252@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=chenlifu@huawei.com \
    --cc=heying24@huawei.com \
    --cc=johnny.chenyi@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=valentin.schneider@arm.com \
    --cc=weiyongjun1@huawei.com \
    --cc=will@kernel.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.