All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
To: catalin.marinas@arm.com, will@kernel.org, avagin@gmail.com,
	0x7f454c46@gmail.com, mark.rutland@arm.com, maz@kernel.org,
	tglx@linutronix.de, linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org,
	Edmundo Carmona Antoranz <eantoranz@gmail.com>
Subject: [PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok
Date: Sat, 10 Apr 2021 12:11:17 -0600	[thread overview]
Message-ID: <20210410181117.23967-1-eantoranz@gmail.com> (raw)

The macro vdso_clocksource_ok is shadowing a function with the same
name and so it actually makes no difference to have the macro defined
or not. Take a hint from x86, rename the function to have the
arch_ prefix and correct the definition of the macro.

Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
---
 arch/arm64/include/asm/vdso/compat_gettimeofday.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/include/asm/vdso/compat_gettimeofday.h b/arch/arm64/include/asm/vdso/compat_gettimeofday.h
index 7508b0ac1d21..055d9e42a05d 100644
--- a/arch/arm64/include/asm/vdso/compat_gettimeofday.h
+++ b/arch/arm64/include/asm/vdso/compat_gettimeofday.h
@@ -166,11 +166,11 @@ static __always_inline const struct vdso_data *__arch_get_timens_vdso_data(void)
 }
 #endif
 
-static inline bool vdso_clocksource_ok(const struct vdso_data *vd)
+static inline bool arch_vdso_clocksource_ok(const struct vdso_data *vd)
 {
 	return vd->clock_mode == VDSO_CLOCKMODE_ARCHTIMER;
 }
-#define vdso_clocksource_ok	vdso_clocksource_ok
+#define vdso_clocksource_ok arch_vdso_clocksource_ok
 
 #endif /* !__ASSEMBLY__ */
 
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
To: catalin.marinas@arm.com, will@kernel.org, avagin@gmail.com,
	0x7f454c46@gmail.com, mark.rutland@arm.com, maz@kernel.org,
	tglx@linutronix.de, linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org,
	Edmundo Carmona Antoranz <eantoranz@gmail.com>
Subject: [PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok
Date: Sat, 10 Apr 2021 12:11:17 -0600	[thread overview]
Message-ID: <20210410181117.23967-1-eantoranz@gmail.com> (raw)

The macro vdso_clocksource_ok is shadowing a function with the same
name and so it actually makes no difference to have the macro defined
or not. Take a hint from x86, rename the function to have the
arch_ prefix and correct the definition of the macro.

Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
---
 arch/arm64/include/asm/vdso/compat_gettimeofday.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/include/asm/vdso/compat_gettimeofday.h b/arch/arm64/include/asm/vdso/compat_gettimeofday.h
index 7508b0ac1d21..055d9e42a05d 100644
--- a/arch/arm64/include/asm/vdso/compat_gettimeofday.h
+++ b/arch/arm64/include/asm/vdso/compat_gettimeofday.h
@@ -166,11 +166,11 @@ static __always_inline const struct vdso_data *__arch_get_timens_vdso_data(void)
 }
 #endif
 
-static inline bool vdso_clocksource_ok(const struct vdso_data *vd)
+static inline bool arch_vdso_clocksource_ok(const struct vdso_data *vd)
 {
 	return vd->clock_mode == VDSO_CLOCKMODE_ARCHTIMER;
 }
-#define vdso_clocksource_ok	vdso_clocksource_ok
+#define vdso_clocksource_ok arch_vdso_clocksource_ok
 
 #endif /* !__ASSEMBLY__ */
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2021-04-10 18:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 18:11 Edmundo Carmona Antoranz [this message]
2021-04-10 18:11 ` [PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok Edmundo Carmona Antoranz
2021-04-10 19:03 ` Marc Zyngier
2021-04-10 19:03   ` Marc Zyngier
2021-04-10 19:58   ` Edmundo Carmona Antoranz
2021-04-10 19:58     ` Edmundo Carmona Antoranz
2021-04-10 22:18     ` Marc Zyngier
2021-04-10 22:18       ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210410181117.23967-1-eantoranz@gmail.com \
    --to=eantoranz@gmail.com \
    --cc=0x7f454c46@gmail.com \
    --cc=avagin@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.