All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Cc: catalin.marinas@arm.com, will@kernel.org, avagin@gmail.com,
	0x7f454c46@gmail.com, mark.rutland@arm.com, tglx@linutronix.de,
	linux-arm-kernel@lists.infradead.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok
Date: Sat, 10 Apr 2021 20:03:53 +0100	[thread overview]
Message-ID: <874kgeezc6.wl-maz@kernel.org> (raw)
In-Reply-To: <20210410181117.23967-1-eantoranz@gmail.com>

Hi Edmundo,

On Sat, 10 Apr 2021 19:11:17 +0100,
Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:
> 
> The macro vdso_clocksource_ok is shadowing a function with the same
> name and so it actually makes no difference to have the macro defined
> or not.

No difference? Have you simply tried removing the macro and witness
the effect? If it made no difference, why have the macro at all then?

Also, run this, for example:

git grep '^\#define' arch/arm64/include/asm/| awk '$2 == $3 { print }'

Are you going to "fix" these too?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Cc: catalin.marinas@arm.com, will@kernel.org, avagin@gmail.com,
	0x7f454c46@gmail.com, mark.rutland@arm.com, tglx@linutronix.de,
	linux-arm-kernel@lists.infradead.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok
Date: Sat, 10 Apr 2021 20:03:53 +0100	[thread overview]
Message-ID: <874kgeezc6.wl-maz@kernel.org> (raw)
In-Reply-To: <20210410181117.23967-1-eantoranz@gmail.com>

Hi Edmundo,

On Sat, 10 Apr 2021 19:11:17 +0100,
Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:
> 
> The macro vdso_clocksource_ok is shadowing a function with the same
> name and so it actually makes no difference to have the macro defined
> or not.

No difference? Have you simply tried removing the macro and witness
the effect? If it made no difference, why have the macro at all then?

Also, run this, for example:

git grep '^\#define' arch/arm64/include/asm/| awk '$2 == $3 { print }'

Are you going to "fix" these too?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-10 19:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 18:11 [PATCH -next] arm64: vdso: correct definition of macro vdso_clocksource_ok Edmundo Carmona Antoranz
2021-04-10 18:11 ` Edmundo Carmona Antoranz
2021-04-10 19:03 ` Marc Zyngier [this message]
2021-04-10 19:03   ` Marc Zyngier
2021-04-10 19:58   ` Edmundo Carmona Antoranz
2021-04-10 19:58     ` Edmundo Carmona Antoranz
2021-04-10 22:18     ` Marc Zyngier
2021-04-10 22:18       ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kgeezc6.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=0x7f454c46@gmail.com \
    --cc=avagin@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=eantoranz@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.