From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>, Vineet Gupta <vgupta@synopsys.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-snps-arc@lists.infradead.org, sparclinux@vger.kernel.org
Subject: [PATCH v3 0/3] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE
Date: Wed, 21 Apr 2021 13:17:56 +0200 [thread overview]
Message-ID: <20210421111759.2059976-1-schnelle@linux.ibm.com> (raw)
Hi,
This is version 3 of my attempt to get rid of a clang -Wnull-pointer-arithmetic
warning for the use of PCI_IOBASE in asm-generic/io.h. This was originally
found on s390 but should apply to all platforms leaving PCI_IOBASE undefined
while making use of the inb() and friends helpers from asm-generic/io.h.
This applies cleanly and was compile tested on top of v5.12-rc8 for the
previously broken ARC and nds32 architectures.
I did boot test this only on x86_64 and s390x the former implements inb()
itself while the latter would emit a WARN_ONCE() but no drivers using inb().
Thanks,
Niklas
Changes since v2:
- Improved comment for SPARC PCI_IOBASE definition as suggested by David Laight
- Added a patch for ARC which is missing the asm/bug.h include for WARN_ONCE()
(kernel test robot)
- Added ifdefs to ioport_map() and __pci_ioport_map() since apparently at least
test configs enable CONFIG_HAS_IOPORT_MAP even on architectures which leave
PCI_IOBASE unset (kernel test robot for nds32 and ARC).
Changes since v1:
- Added patch to explicitly set PCI_IOBASE to 0 on sparc as suggested by Arnd
Bergmann
- Instead of working around the warning with a uintptr_t PCI_IOBASE make inb()
and friends explicitly WARN_ONCE() and return 0xff... (Arnd Bergmann)
Niklas Schnelle (3):
sparc: explicitly set PCI_IOBASE to 0
ARC: io.h: Include asm/bug.h
asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on
PCI_IOBASE
arch/arc/include/asm/io.h | 1 +
arch/sparc/include/asm/io.h | 8 +++++
include/asm-generic/io.h | 64 ++++++++++++++++++++++++++++++++++---
3 files changed, 69 insertions(+), 4 deletions(-)
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>, Vineet Gupta <vgupta@synopsys.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-snps-arc@lists.infradead.org, sparclinux@vger.kernel.org
Subject: [PATCH v3 0/3] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE
Date: Wed, 21 Apr 2021 13:17:56 +0200 [thread overview]
Message-ID: <20210421111759.2059976-1-schnelle@linux.ibm.com> (raw)
Hi,
This is version 3 of my attempt to get rid of a clang -Wnull-pointer-arithmetic
warning for the use of PCI_IOBASE in asm-generic/io.h. This was originally
found on s390 but should apply to all platforms leaving PCI_IOBASE undefined
while making use of the inb() and friends helpers from asm-generic/io.h.
This applies cleanly and was compile tested on top of v5.12-rc8 for the
previously broken ARC and nds32 architectures.
I did boot test this only on x86_64 and s390x the former implements inb()
itself while the latter would emit a WARN_ONCE() but no drivers using inb().
Thanks,
Niklas
Changes since v2:
- Improved comment for SPARC PCI_IOBASE definition as suggested by David Laight
- Added a patch for ARC which is missing the asm/bug.h include for WARN_ONCE()
(kernel test robot)
- Added ifdefs to ioport_map() and __pci_ioport_map() since apparently at least
test configs enable CONFIG_HAS_IOPORT_MAP even on architectures which leave
PCI_IOBASE unset (kernel test robot for nds32 and ARC).
Changes since v1:
- Added patch to explicitly set PCI_IOBASE to 0 on sparc as suggested by Arnd
Bergmann
- Instead of working around the warning with a uintptr_t PCI_IOBASE make inb()
and friends explicitly WARN_ONCE() and return 0xff... (Arnd Bergmann)
Niklas Schnelle (3):
sparc: explicitly set PCI_IOBASE to 0
ARC: io.h: Include asm/bug.h
asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on
PCI_IOBASE
arch/arc/include/asm/io.h | 1 +
arch/sparc/include/asm/io.h | 8 +++++
include/asm-generic/io.h | 64 ++++++++++++++++++++++++++++++++++---
3 files changed, 69 insertions(+), 4 deletions(-)
--
2.25.1
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next reply other threads:[~2021-04-21 11:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 11:17 Niklas Schnelle [this message]
2021-04-21 11:17 ` [PATCH v3 0/3] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE Niklas Schnelle
2021-04-21 11:17 ` [PATCH v3 1/3] sparc: explicitly set PCI_IOBASE to 0 Niklas Schnelle
2021-04-21 11:17 ` Niklas Schnelle
2021-04-21 11:17 ` [PATCH v3 2/3] ARC: io.h: Include asm/bug.h Niklas Schnelle
2021-04-21 11:17 ` Niklas Schnelle
2021-04-21 11:17 ` [PATCH v3 3/3] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE Niklas Schnelle
2021-04-21 11:17 ` Niklas Schnelle
2021-04-21 11:24 ` David Laight
2021-04-21 11:24 ` David Laight
2021-04-21 11:50 ` Niklas Schnelle
2021-04-21 11:50 ` Niklas Schnelle
2021-04-21 11:57 ` Arnd Bergmann
2021-04-21 11:57 ` Arnd Bergmann
2021-04-21 15:19 ` kernel test robot
2021-04-21 15:19 ` kernel test robot
2021-04-21 15:38 ` Niklas Schnelle
2021-04-21 15:38 ` Niklas Schnelle
2021-04-21 16:59 ` kernel test robot
2021-04-21 16:59 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421111759.2059976-1-schnelle@linux.ibm.com \
--to=schnelle@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sparclinux@vger.kernel.org \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.