All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Niklas Schnelle <schnelle@linux.ibm.com>,
	Arnd Bergmann <arnd@arndb.de>, Vineet Gupta <vgupta@synopsys.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v3 3/3] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE
Date: Thu, 22 Apr 2021 00:59:57 +0800	[thread overview]
Message-ID: <202104220057.CBInGIZK-lkp@intel.com> (raw)
In-Reply-To: <20210421111759.2059976-4-schnelle@linux.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 2761 bytes --]

Hi Niklas,

I love your patch! Yet something to improve:

[auto build test ERROR on soc/for-next]
[also build test ERROR on asm-generic/master v5.12-rc8 next-20210421]
[cannot apply to arc/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Niklas-Schnelle/asm-generic-io-h-Silence-Wnull-pointer-arithmetic-warning-on-PCI_IOBASE/20210421-192025
base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: h8300-randconfig-r025-20210421 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/05bc9b9b640336015712d139ebc42830d12a82da
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Niklas-Schnelle/asm-generic-io-h-Silence-Wnull-pointer-arithmetic-warning-on-PCI_IOBASE/20210421-192025
        git checkout 05bc9b9b640336015712d139ebc42830d12a82da
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/h8300/include/asm/io.h:63,
                    from drivers/input/gameport/lightning.c:13:
   include/asm-generic/io.h: In function '_inb':
>> include/asm-generic/io.h:465:2: error: implicit declaration of function 'WARN_ONCE' [-Werror=implicit-function-declaration]
     465 |  WARN_ONCE(1, "No I/O port support\n");
         |  ^~~~~~~~~
   cc1: some warnings being treated as errors


vim +/WARN_ONCE +465 include/asm-generic/io.h

   446	
   447	/*
   448	 * {in,out}{b,w,l}() access little endian I/O. {in,out}{b,w,l}_p() can be
   449	 * implemented on hardware that needs an additional delay for I/O accesses to
   450	 * take effect.
   451	 */
   452	
   453	#if !defined(inb) && !defined(_inb)
   454	#define _inb _inb
   455	static inline u8 _inb(unsigned long addr)
   456	{
   457	#ifdef PCI_IOBASE
   458		u8 val;
   459	
   460		__io_pbr();
   461		val = __raw_readb(PCI_IOBASE + addr);
   462		__io_par(val);
   463		return val;
   464	#else
 > 465		WARN_ONCE(1, "No I/O port support\n");
   466		return ~0;
   467	#endif
   468	}
   469	#endif
   470	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28679 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 3/3] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE
Date: Thu, 22 Apr 2021 00:59:57 +0800	[thread overview]
Message-ID: <202104220057.CBInGIZK-lkp@intel.com> (raw)
In-Reply-To: <20210421111759.2059976-4-schnelle@linux.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 2833 bytes --]

Hi Niklas,

I love your patch! Yet something to improve:

[auto build test ERROR on soc/for-next]
[also build test ERROR on asm-generic/master v5.12-rc8 next-20210421]
[cannot apply to arc/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Niklas-Schnelle/asm-generic-io-h-Silence-Wnull-pointer-arithmetic-warning-on-PCI_IOBASE/20210421-192025
base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: h8300-randconfig-r025-20210421 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/05bc9b9b640336015712d139ebc42830d12a82da
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Niklas-Schnelle/asm-generic-io-h-Silence-Wnull-pointer-arithmetic-warning-on-PCI_IOBASE/20210421-192025
        git checkout 05bc9b9b640336015712d139ebc42830d12a82da
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/h8300/include/asm/io.h:63,
                    from drivers/input/gameport/lightning.c:13:
   include/asm-generic/io.h: In function '_inb':
>> include/asm-generic/io.h:465:2: error: implicit declaration of function 'WARN_ONCE' [-Werror=implicit-function-declaration]
     465 |  WARN_ONCE(1, "No I/O port support\n");
         |  ^~~~~~~~~
   cc1: some warnings being treated as errors


vim +/WARN_ONCE +465 include/asm-generic/io.h

   446	
   447	/*
   448	 * {in,out}{b,w,l}() access little endian I/O. {in,out}{b,w,l}_p() can be
   449	 * implemented on hardware that needs an additional delay for I/O accesses to
   450	 * take effect.
   451	 */
   452	
   453	#if !defined(inb) && !defined(_inb)
   454	#define _inb _inb
   455	static inline u8 _inb(unsigned long addr)
   456	{
   457	#ifdef PCI_IOBASE
   458		u8 val;
   459	
   460		__io_pbr();
   461		val = __raw_readb(PCI_IOBASE + addr);
   462		__io_par(val);
   463		return val;
   464	#else
 > 465		WARN_ONCE(1, "No I/O port support\n");
   466		return ~0;
   467	#endif
   468	}
   469	#endif
   470	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28679 bytes --]

  parent reply	other threads:[~2021-04-21 17:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 11:17 [PATCH v3 0/3] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE Niklas Schnelle
2021-04-21 11:17 ` Niklas Schnelle
2021-04-21 11:17 ` [PATCH v3 1/3] sparc: explicitly set PCI_IOBASE to 0 Niklas Schnelle
2021-04-21 11:17   ` Niklas Schnelle
2021-04-21 11:17 ` [PATCH v3 2/3] ARC: io.h: Include asm/bug.h Niklas Schnelle
2021-04-21 11:17   ` Niklas Schnelle
2021-04-21 11:17 ` [PATCH v3 3/3] asm-generic/io.h: Silence -Wnull-pointer-arithmetic warning on PCI_IOBASE Niklas Schnelle
2021-04-21 11:17   ` Niklas Schnelle
2021-04-21 11:24   ` David Laight
2021-04-21 11:24     ` David Laight
2021-04-21 11:50     ` Niklas Schnelle
2021-04-21 11:50       ` Niklas Schnelle
2021-04-21 11:57       ` Arnd Bergmann
2021-04-21 11:57         ` Arnd Bergmann
2021-04-21 15:19   ` kernel test robot
2021-04-21 15:19     ` kernel test robot
2021-04-21 15:38     ` Niklas Schnelle
2021-04-21 15:38       ` Niklas Schnelle
2021-04-21 16:59   ` kernel test robot [this message]
2021-04-21 16:59     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202104220057.CBInGIZK-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=arnd@arndb.de \
    --cc=clang-built-linux@googlegroups.com \
    --cc=davem@davemloft.net \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=schnelle@linux.ibm.com \
    --cc=vgupta@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.