From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <maxime@cerno.tech>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>,
Dom Cobley <dom@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Emma Anholt <emma@anholt.net>, Phil Elwell <phil@raspberrypi.com>
Subject: [PATCH v5 06/10] drm/vc4: crtc: Add some logging
Date: Mon, 28 Jun 2021 14:42:53 +0200 [thread overview]
Message-ID: <20210628124257.140453-7-maxime@cerno.tech> (raw)
In-Reply-To: <20210628124257.140453-1-maxime@cerno.tech>
The encoder retrieval code has been a source of bugs and glitches in the
past and the crtc <-> encoder association been wrong in a number of
different ways.
Add some logging to quickly spot issues if they occur.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/vc4/vc4_crtc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
index c88ce31ec90f..073b7e528175 100644
--- a/drivers/gpu/drm/vc4/vc4_crtc.c
+++ b/drivers/gpu/drm/vc4/vc4_crtc.c
@@ -524,6 +524,9 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *crtc,
struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, old_state);
struct drm_device *dev = crtc->dev;
+ drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)",
+ crtc->name, crtc->base.id, encoder->name, encoder->base.id);
+
require_hvs_enabled(dev);
/* Disable vblank irq handling before crtc is disabled. */
@@ -555,6 +558,9 @@ static void vc4_crtc_atomic_enable(struct drm_crtc *crtc,
struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, new_state);
struct vc4_encoder *vc4_encoder = to_vc4_encoder(encoder);
+ drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)",
+ crtc->name, crtc->base.id, encoder->name, encoder->base.id);
+
require_hvs_enabled(dev);
/* Enable vblank irq handling before crtc is started otherwise
--
2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <maxime@cerno.tech>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dom Cobley <dom@raspberrypi.com>,
linux-rpi-kernel@lists.infradead.org,
Maxime Ripard <mripard@kernel.org>, Emma Anholt <emma@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Eric Anholt <eric@anholt.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH v5 06/10] drm/vc4: crtc: Add some logging
Date: Mon, 28 Jun 2021 14:42:53 +0200 [thread overview]
Message-ID: <20210628124257.140453-7-maxime@cerno.tech> (raw)
In-Reply-To: <20210628124257.140453-1-maxime@cerno.tech>
The encoder retrieval code has been a source of bugs and glitches in the
past and the crtc <-> encoder association been wrong in a number of
different ways.
Add some logging to quickly spot issues if they occur.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/vc4/vc4_crtc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
index c88ce31ec90f..073b7e528175 100644
--- a/drivers/gpu/drm/vc4/vc4_crtc.c
+++ b/drivers/gpu/drm/vc4/vc4_crtc.c
@@ -524,6 +524,9 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *crtc,
struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, old_state);
struct drm_device *dev = crtc->dev;
+ drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)",
+ crtc->name, crtc->base.id, encoder->name, encoder->base.id);
+
require_hvs_enabled(dev);
/* Disable vblank irq handling before crtc is disabled. */
@@ -555,6 +558,9 @@ static void vc4_crtc_atomic_enable(struct drm_crtc *crtc,
struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, new_state);
struct vc4_encoder *vc4_encoder = to_vc4_encoder(encoder);
+ drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)",
+ crtc->name, crtc->base.id, encoder->name, encoder->base.id);
+
require_hvs_enabled(dev);
/* Enable vblank irq handling before crtc is started otherwise
--
2.31.1
next prev parent reply other threads:[~2021-06-28 12:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 12:42 [PATCH v5 00/10] drm/vc4: hdmi: Support the 4k @ 60Hz modes Maxime Ripard
2021-06-28 12:42 ` Maxime Ripard
2021-06-28 12:42 ` [PATCH v5 01/10] drm/vc4: hdmi: Remove the DDC probing for status detection Maxime Ripard
2021-06-28 12:42 ` Maxime Ripard
2021-06-28 12:42 ` [PATCH v5 02/10] drm/vc4: hdmi: Fix HPD GPIO detection Maxime Ripard
2021-06-28 12:42 ` Maxime Ripard
2021-06-28 12:42 ` [PATCH v5 03/10] drm/vc4: Make vc4_crtc_get_encoder public Maxime Ripard
2021-06-28 12:42 ` Maxime Ripard
2021-06-28 12:42 ` [PATCH v5 04/10] drm/vc4: crtc: Add encoder to vc4_crtc_config_pv prototype Maxime Ripard
2021-06-28 12:42 ` Maxime Ripard
2021-06-28 12:42 ` [PATCH v5 05/10] drm/vc4: crtc: Rework the encoder retrieval code (again) Maxime Ripard
2021-06-28 12:42 ` Maxime Ripard
2021-06-28 12:42 ` Maxime Ripard [this message]
2021-06-28 12:42 ` [PATCH v5 06/10] drm/vc4: crtc: Add some logging Maxime Ripard
2021-06-28 12:42 ` [PATCH v5 07/10] drm/vc4: Leverage the load tracker on the BCM2711 Maxime Ripard
2021-06-28 12:42 ` Maxime Ripard
2021-06-28 17:01 ` kernel test robot
2021-06-28 17:01 ` kernel test robot
2021-06-28 20:42 ` kernel test robot
2021-06-28 20:42 ` kernel test robot
2021-06-28 12:42 ` [PATCH v5 08/10] drm/vc4: hdmi: Raise the maximum clock rate Maxime Ripard
2021-06-28 12:42 ` Maxime Ripard
2021-06-28 12:42 ` [PATCH v5 09/10] drm/vc4: hdmi: Enable the scrambler on reconnection Maxime Ripard
2021-06-28 12:42 ` Maxime Ripard
2021-06-28 12:42 ` [PATCH v5 10/10] drm/vc4: Increase the core clock based on HVS load Maxime Ripard
2021-06-28 12:42 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628124257.140453-7-maxime@cerno.tech \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.