Re: [PATCH v2] drm/dbi: Print errors for mipi_dbi_command()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3522 bytes --]

Hi Linus,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Linus-Walleij/drm-dbi-Print-errors-for-mipi_dbi_command/20210702-180745
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3dbdb38e286903ec220aaf1fb29a8d94297da246
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/42d93a52e398adbb1fe2dfbc895c649cc8d42780
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Linus-Walleij/drm-dbi-Print-errors-for-mipi_dbi_command/20210702-180745
        git checkout 42d93a52e398adbb1fe2dfbc895c649cc8d42780
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/gpu/drm/tiny/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/tiny/st7586.c:25:
   drivers/gpu/drm/tiny/st7586.c: In function 'st7586_pipe_disable':
>> include/drm/drm_mipi_dbi.h:186:27: error: invalid type argument of '->' (have 'struct mipi_dbi')
     186 |  struct device *dev = &dbi->spi->dev; \
         |                           ^~
   drivers/gpu/drm/tiny/st7586.c:260:2: note: in expansion of macro 'mipi_dbi_command'
     260 |  mipi_dbi_command(&dbidev->dbi, MIPI_DCS_SET_DISPLAY_OFF);
         |  ^~~~~~~~~~~~~~~~


vim +186 include/drm/drm_mipi_dbi.h

   160	
   161	u32 mipi_dbi_spi_cmd_max_speed(struct spi_device *spi, size_t len);
   162	int mipi_dbi_spi_transfer(struct spi_device *spi, u32 speed_hz,
   163				  u8 bpw, const void *buf, size_t len);
   164	
   165	int mipi_dbi_command_read(struct mipi_dbi *dbi, u8 cmd, u8 *val);
   166	int mipi_dbi_command_buf(struct mipi_dbi *dbi, u8 cmd, u8 *data, size_t len);
   167	int mipi_dbi_command_stackbuf(struct mipi_dbi *dbi, u8 cmd, const u8 *data,
   168				      size_t len);
   169	int mipi_dbi_buf_copy(void *dst, struct drm_framebuffer *fb,
   170			      struct drm_rect *clip, bool swap);
   171	/**
   172	 * mipi_dbi_command - MIPI DCS command with optional parameter(s)
   173	 * @dbi: MIPI DBI structure
   174	 * @cmd: Command
   175	 * @seq: Optional parameter(s)
   176	 *
   177	 * Send MIPI DCS command to the controller. Use mipi_dbi_command_read() for
   178	 * get/read.
   179	 *
   180	 * Returns:
   181	 * Zero on success, negative error code on failure.
   182	 */
   183	#define mipi_dbi_command(dbi, cmd, seq...) \
   184	({ \
   185		const u8 d[] = { seq }; \
 > 186		struct device *dev = &dbi->spi->dev; \
   187		int ret; \
   188		ret = mipi_dbi_command_stackbuf(dbi, cmd, d, ARRAY_SIZE(d)); \
   189		if (ret) \
   190			dev_err_ratelimited(dev, "error %d when sending command\n", ret); \
   191	})
   192	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60501 bytes --]