From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Douglas Anderson" <dianders@chromium.org>,
dri-devel@lists.freedesktop.org,
"Noralf Trønnes" <noralf@tronnes.org>
Subject: Re: [PATCH v2] drm/dbi: Print errors for mipi_dbi_command()
Date: Fri, 2 Jul 2021 12:28:53 +0200 [thread overview]
Message-ID: <YN7qZYNjKCOD0Lim@ravnborg.org> (raw)
In-Reply-To: <YN7qHm9DgHYKvngw@ravnborg.org>
On Fri, Jul 02, 2021 at 12:27:42PM +0200, Sam Ravnborg wrote:
> On Fri, Jul 02, 2021 at 12:04:55PM +0200, Linus Walleij wrote:
> > The macro mipi_dbi_command() does not report errors unless you wrap it
> > in another macro to do the error reporting.
> >
> > Report a rate-limited error so we know what is going on.
> >
> > Drop the only user in DRM using mipi_dbi_command() and actually checking
> > the error explicitly, let it use mipi_dbi_command_buf() directly
> > instead.
> >
> > After this any code wishing to send command arrays can rely on
> > mipi_dbi_command() providing an appropriate error message if something
> > goes wrong.
> >
> > Suggested-by: Noralf Trønnes <noralf@tronnes.org>
> > Suggested-by: Douglas Anderson <dianders@chromium.org>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Too fast send, this should read:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2021-07-02 10:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 10:04 [PATCH v2] drm/dbi: Print errors for mipi_dbi_command() Linus Walleij
2021-07-02 10:27 ` Sam Ravnborg
2021-07-02 10:28 ` Sam Ravnborg [this message]
2021-07-02 11:03 ` Noralf Trønnes
2021-07-02 11:42 ` kernel test robot
2021-07-02 11:42 ` kernel test robot
2021-07-02 13:57 ` kernel test robot
2021-07-02 13:57 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN7qZYNjKCOD0Lim@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=noralf@tronnes.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.