From: DENG Qingfang <dqfext@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
"Eric Woudstra" <ericwouds@gmail.com>,
"René van Dorst" <opensource@vdorst.com>,
"Frank Wunderlich" <frank-w@public-files.de>
Subject: Re: [RFC net-next v2 3/4] net: dsa: mt7530: set STP state also on filter ID 1
Date: Mon, 2 Aug 2021 23:31:29 +0800 [thread overview]
Message-ID: <20210802153129.1817825-1-dqfext@gmail.com> (raw)
In-Reply-To: <20210802134336.gv66le6u2z52kfkh@skbuf>
On Mon, Aug 02, 2021 at 04:43:36PM +0300, Vladimir Oltean wrote:
> On Sun, Aug 01, 2021 at 03:10:21AM +0800, DENG Qingfang wrote:
> > --- a/drivers/net/dsa/mt7530.h
> > +++ b/drivers/net/dsa/mt7530.h
> > @@ -181,7 +181,7 @@ enum mt7530_vlan_egress_attr {
> >
> > /* Register for port STP state control */
> > #define MT7530_SSP_P(x) (0x2000 + ((x) * 0x100))
> > -#define FID_PST(x) ((x) & 0x3)
>
> Shouldn't these macros have _two_ arguments, the FID and the port state?
>
> > +#define FID_PST(x) (((x) & 0x3) * 0x5)
>
> "* 5": explanation?
>
> > #define FID_PST_MASK FID_PST(0x3)
> >
> > enum mt7530_stp_state {
> > --
> > 2.25.1
> >
>
> I don't exactly understand how this patch works, sorry.
> Are you altering port state only on bridged ports, or also on standalone
> ports after this patch? Are standalone ports in the proper STP state
> (FORWARDING)?
The current code only sets FID 0's STP state. This patch sets both 0's and
1's states.
The *5 part is binary magic. [1:0] is FID 0's state, [3:2] is FID 1's state
and so on. Since 5 == 4'b0101, the value in [1:0] is copied to [3:2] after
the multiplication.
Perhaps I should only change FID 1's state.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: DENG Qingfang <dqfext@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
"Eric Woudstra" <ericwouds@gmail.com>,
"René van Dorst" <opensource@vdorst.com>,
"Frank Wunderlich" <frank-w@public-files.de>
Subject: Re: [RFC net-next v2 3/4] net: dsa: mt7530: set STP state also on filter ID 1
Date: Mon, 2 Aug 2021 23:31:29 +0800 [thread overview]
Message-ID: <20210802153129.1817825-1-dqfext@gmail.com> (raw)
In-Reply-To: <20210802134336.gv66le6u2z52kfkh@skbuf>
On Mon, Aug 02, 2021 at 04:43:36PM +0300, Vladimir Oltean wrote:
> On Sun, Aug 01, 2021 at 03:10:21AM +0800, DENG Qingfang wrote:
> > --- a/drivers/net/dsa/mt7530.h
> > +++ b/drivers/net/dsa/mt7530.h
> > @@ -181,7 +181,7 @@ enum mt7530_vlan_egress_attr {
> >
> > /* Register for port STP state control */
> > #define MT7530_SSP_P(x) (0x2000 + ((x) * 0x100))
> > -#define FID_PST(x) ((x) & 0x3)
>
> Shouldn't these macros have _two_ arguments, the FID and the port state?
>
> > +#define FID_PST(x) (((x) & 0x3) * 0x5)
>
> "* 5": explanation?
>
> > #define FID_PST_MASK FID_PST(0x3)
> >
> > enum mt7530_stp_state {
> > --
> > 2.25.1
> >
>
> I don't exactly understand how this patch works, sorry.
> Are you altering port state only on bridged ports, or also on standalone
> ports after this patch? Are standalone ports in the proper STP state
> (FORWARDING)?
The current code only sets FID 0's STP state. This patch sets both 0's and
1's states.
The *5 part is binary magic. [1:0] is FID 0's state, [3:2] is FID 1's state
and so on. Since 5 == 4'b0101, the value in [1:0] is copied to [3:2] after
the multiplication.
Perhaps I should only change FID 1's state.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: DENG Qingfang <dqfext@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
"Eric Woudstra" <ericwouds@gmail.com>,
"René van Dorst" <opensource@vdorst.com>,
"Frank Wunderlich" <frank-w@public-files.de>
Subject: Re: [RFC net-next v2 3/4] net: dsa: mt7530: set STP state also on filter ID 1
Date: Mon, 2 Aug 2021 23:31:29 +0800 [thread overview]
Message-ID: <20210802153129.1817825-1-dqfext@gmail.com> (raw)
In-Reply-To: <20210802134336.gv66le6u2z52kfkh@skbuf>
On Mon, Aug 02, 2021 at 04:43:36PM +0300, Vladimir Oltean wrote:
> On Sun, Aug 01, 2021 at 03:10:21AM +0800, DENG Qingfang wrote:
> > --- a/drivers/net/dsa/mt7530.h
> > +++ b/drivers/net/dsa/mt7530.h
> > @@ -181,7 +181,7 @@ enum mt7530_vlan_egress_attr {
> >
> > /* Register for port STP state control */
> > #define MT7530_SSP_P(x) (0x2000 + ((x) * 0x100))
> > -#define FID_PST(x) ((x) & 0x3)
>
> Shouldn't these macros have _two_ arguments, the FID and the port state?
>
> > +#define FID_PST(x) (((x) & 0x3) * 0x5)
>
> "* 5": explanation?
>
> > #define FID_PST_MASK FID_PST(0x3)
> >
> > enum mt7530_stp_state {
> > --
> > 2.25.1
> >
>
> I don't exactly understand how this patch works, sorry.
> Are you altering port state only on bridged ports, or also on standalone
> ports after this patch? Are standalone ports in the proper STP state
> (FORWARDING)?
The current code only sets FID 0's STP state. This patch sets both 0's and
1's states.
The *5 part is binary magic. [1:0] is FID 0's state, [3:2] is FID 1's state
and so on. Since 5 == 4'b0101, the value in [1:0] is copied to [3:2] after
the multiplication.
Perhaps I should only change FID 1's state.
next prev parent reply other threads:[~2021-08-02 15:32 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 19:10 [RFC net-next v2 0/4] mt7530 software fallback bridging fix DENG Qingfang
2021-07-31 19:10 ` DENG Qingfang
2021-07-31 19:10 ` DENG Qingfang
2021-07-31 19:10 ` [RFC net-next v2 1/4] net: dsa: mt7530: enable assisted learning on CPU port DENG Qingfang
2021-07-31 19:10 ` DENG Qingfang
2021-07-31 19:10 ` DENG Qingfang
2021-08-02 13:07 ` Vladimir Oltean
2021-08-02 13:07 ` Vladimir Oltean
2021-08-02 13:07 ` Vladimir Oltean
2021-07-31 19:10 ` [RFC net-next v2 2/4] net: dsa: mt7530: use independent VLAN learning on VLAN-unaware bridges DENG Qingfang
2021-07-31 19:10 ` DENG Qingfang
2021-07-31 19:10 ` DENG Qingfang
2021-08-02 13:36 ` Vladimir Oltean
2021-08-02 13:36 ` Vladimir Oltean
2021-08-02 13:36 ` Vladimir Oltean
2021-07-31 19:10 ` [RFC net-next v2 3/4] net: dsa: mt7530: set STP state also on filter ID 1 DENG Qingfang
2021-07-31 19:10 ` DENG Qingfang
2021-07-31 19:10 ` DENG Qingfang
2021-08-02 13:43 ` Vladimir Oltean
2021-08-02 13:43 ` Vladimir Oltean
2021-08-02 13:43 ` Vladimir Oltean
2021-08-02 15:31 ` DENG Qingfang [this message]
2021-08-02 15:31 ` DENG Qingfang
2021-08-02 15:31 ` DENG Qingfang
2021-08-02 15:42 ` Vladimir Oltean
2021-08-02 15:42 ` Vladimir Oltean
2021-08-02 15:42 ` Vladimir Oltean
2021-08-02 15:58 ` DENG Qingfang
2021-08-02 15:58 ` DENG Qingfang
2021-08-02 15:58 ` DENG Qingfang
2021-08-02 21:00 ` Vladimir Oltean
2021-08-02 21:00 ` Vladimir Oltean
2021-08-02 21:00 ` Vladimir Oltean
2021-08-03 8:23 ` DENG Qingfang
2021-08-03 8:23 ` DENG Qingfang
2021-08-03 8:23 ` DENG Qingfang
2021-08-03 8:48 ` Vladimir Oltean
2021-08-03 8:48 ` Vladimir Oltean
2021-08-03 8:48 ` Vladimir Oltean
2021-07-31 19:10 ` [RFC net-next v2 4/4] Revert "mt7530 mt7530_fdb_write only set ivl bit vid larger than 1" DENG Qingfang
2021-07-31 19:10 ` DENG Qingfang
2021-07-31 19:10 ` DENG Qingfang
2021-08-02 13:44 ` Vladimir Oltean
2021-08-02 13:44 ` Vladimir Oltean
2021-08-02 13:44 ` Vladimir Oltean
2021-08-02 15:48 ` DENG Qingfang
2021-08-02 15:48 ` DENG Qingfang
2021-08-02 15:48 ` DENG Qingfang
2021-08-02 20:59 ` Vladimir Oltean
2021-08-02 20:59 ` Vladimir Oltean
2021-08-02 20:59 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802153129.1817825-1-dqfext@gmail.com \
--to=dqfext@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ericwouds@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opensource@vdorst.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.