All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wong Vee Khee <vee.khee.wong@linux.intel.com>
To: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>
Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
	joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org,
	mcoquelin.stm32@gmail.com, vee.khee.wong@intel.com,
	weifeng.voon@intel.com, netdev@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/3] net: stmmac: fix INTR TBU status affecting irq count statistic
Date: Mon, 16 Aug 2021 18:47:46 +0800	[thread overview]
Message-ID: <20210816104746.GA9014@linux.intel.com> (raw)
In-Reply-To: <f82f52076841285309a997f849e2786781548538.1629092894.git.vijayakannan.ayyathurai@intel.com>

On Mon, Aug 16, 2021 at 02:15:58PM +0800, Vijayakannan Ayyathurai wrote:
> From: Voon Weifeng <weifeng.voon@intel.com>
> 
> DMA channel status "Transmit buffer unavailable(TBU)" bit is not
> considered as a successful dma tx. Hence, it should not affect
> all the irq count statistic.
>

Acked-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
 
> Fixes: 1103d3a5531c ("net: stmmac: dwmac4: Also use TBU interrupt to clean TX path")
> Signed-off-by: Voon Weifeng <weifeng.voon@intel.com>
> Signed-off-by: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c
> index e63270267578..f83db62938dd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c
> @@ -172,11 +172,12 @@ int dwmac4_dma_interrupt(void __iomem *ioaddr,
>  		x->rx_normal_irq_n++;
>  		ret |= handle_rx;
>  	}
> -	if (likely(intr_status & (DMA_CHAN_STATUS_TI |
> -		DMA_CHAN_STATUS_TBU))) {
> +	if (likely(intr_status & DMA_CHAN_STATUS_TI)) {
>  		x->tx_normal_irq_n++;
>  		ret |= handle_tx;
>  	}
> +	if (unlikely(intr_status & DMA_CHAN_STATUS_TBU))
> +		ret |= handle_tx;
>  	if (unlikely(intr_status & DMA_CHAN_STATUS_ERI))
>  		x->rx_early_irq++;
>  

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Wong Vee Khee <vee.khee.wong@linux.intel.com>
To: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>
Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
	joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org,
	mcoquelin.stm32@gmail.com, vee.khee.wong@intel.com,
	weifeng.voon@intel.com, netdev@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/3] net: stmmac: fix INTR TBU status affecting irq count statistic
Date: Mon, 16 Aug 2021 18:47:46 +0800	[thread overview]
Message-ID: <20210816104746.GA9014@linux.intel.com> (raw)
In-Reply-To: <f82f52076841285309a997f849e2786781548538.1629092894.git.vijayakannan.ayyathurai@intel.com>

On Mon, Aug 16, 2021 at 02:15:58PM +0800, Vijayakannan Ayyathurai wrote:
> From: Voon Weifeng <weifeng.voon@intel.com>
> 
> DMA channel status "Transmit buffer unavailable(TBU)" bit is not
> considered as a successful dma tx. Hence, it should not affect
> all the irq count statistic.
>

Acked-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
 
> Fixes: 1103d3a5531c ("net: stmmac: dwmac4: Also use TBU interrupt to clean TX path")
> Signed-off-by: Voon Weifeng <weifeng.voon@intel.com>
> Signed-off-by: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c
> index e63270267578..f83db62938dd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c
> @@ -172,11 +172,12 @@ int dwmac4_dma_interrupt(void __iomem *ioaddr,
>  		x->rx_normal_irq_n++;
>  		ret |= handle_rx;
>  	}
> -	if (likely(intr_status & (DMA_CHAN_STATUS_TI |
> -		DMA_CHAN_STATUS_TBU))) {
> +	if (likely(intr_status & DMA_CHAN_STATUS_TI)) {
>  		x->tx_normal_irq_n++;
>  		ret |= handle_tx;
>  	}
> +	if (unlikely(intr_status & DMA_CHAN_STATUS_TBU))
> +		ret |= handle_tx;
>  	if (unlikely(intr_status & DMA_CHAN_STATUS_ERI))
>  		x->rx_early_irq++;
>  

  reply	other threads:[~2021-08-16 10:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16  6:15 [PATCH net-next v1 0/3] net: stmmac: Add ethtool per-queue statistic Vijayakannan Ayyathurai
2021-08-16  6:15 ` Vijayakannan Ayyathurai
2021-08-16  6:15 ` [PATCH net-next v1 1/3] net: stmmac: fix INTR TBU status affecting irq count statistic Vijayakannan Ayyathurai
2021-08-16  6:15   ` Vijayakannan Ayyathurai
2021-08-16 10:47   ` Wong Vee Khee [this message]
2021-08-16 10:47     ` Wong Vee Khee
2021-08-16  6:15 ` [PATCH net-next v1 2/3] net: stmmac: add ethtool per-queue statistic framework Vijayakannan Ayyathurai
2021-08-16  6:15   ` Vijayakannan Ayyathurai
2021-08-16 10:50   ` Wong Vee Khee
2021-08-16 10:50     ` Wong Vee Khee
2021-08-16  6:16 ` [PATCH net-next v1 3/3] net: stmmac: add ethtool per-queue irq statistic support Vijayakannan Ayyathurai
2021-08-16  6:16   ` Vijayakannan Ayyathurai
2021-08-16 10:53   ` Wong Vee Khee
2021-08-16 10:53     ` Wong Vee Khee
2021-08-16 12:50 ` [PATCH net-next v1 0/3] net: stmmac: Add ethtool per-queue statistic patchwork-bot+netdevbpf
2021-08-16 12:50   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210816104746.GA9014@linux.intel.com \
    --to=vee.khee.wong@linux.intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=davem@davemloft.net \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=vee.khee.wong@intel.com \
    --cc=vijayakannan.ayyathurai@intel.com \
    --cc=weifeng.voon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.