From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: kernel test robot <lkp@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jens Axboe <axboe@kernel.dk>,
clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 5/7] genirq/affinity: move group_cpus_evenly() into lib/
Date: Tue, 17 Aug 2021 06:52:18 +0200 [thread overview]
Message-ID: <20210817045218.GE3874@lst.de> (raw)
In-Reply-To: <YRm5lXfnukXU8Ebh@T590>
On Mon, Aug 16, 2021 at 09:04:21AM +0800, Ming Lei wrote:
> But the above symbol is exported via EXPORT_SYMBOL_GPL(), in current
> kernel tree, we usually keep such exported symbol as global, or is there
> some change in kernel coding style recently?
This is about prototypes. You need to include group_cpus.h in
group_cpus.c so that the prototype is visible at the implementation site.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 5/7] genirq/affinity: move group_cpus_evenly() into lib/
Date: Tue, 17 Aug 2021 06:52:18 +0200 [thread overview]
Message-ID: <20210817045218.GE3874@lst.de> (raw)
In-Reply-To: <YRm5lXfnukXU8Ebh@T590>
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
On Mon, Aug 16, 2021 at 09:04:21AM +0800, Ming Lei wrote:
> But the above symbol is exported via EXPORT_SYMBOL_GPL(), in current
> kernel tree, we usually keep such exported symbol as global, or is there
> some change in kernel coding style recently?
This is about prototypes. You need to include group_cpus.h in
group_cpus.c so that the prototype is visible at the implementation site.
next prev parent reply other threads:[~2021-08-17 4:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 12:35 [PATCH 0/7] genirq/affinity: abstract new API from managed irq affinity spread Ming Lei
2021-08-14 12:35 ` [PATCH 1/7] genirq/affinity: remove the 'firstvec' parameter from irq_build_affinity_masks Ming Lei
2021-08-17 4:45 ` Christoph Hellwig
2021-08-14 12:35 ` [PATCH 2/7] genirq/affinity: pass affinity managed mask array to irq_build_affinity_masks Ming Lei
2021-08-17 4:46 ` Christoph Hellwig
2021-08-14 12:35 ` [PATCH 3/7] genirq/affinity: don't pass irq_affinity_desc " Ming Lei
2021-08-17 4:49 ` Christoph Hellwig
2021-08-14 12:35 ` [PATCH 4/7] genirq/affinity: rename irq_build_affinity_masks as group_cpus_evenly Ming Lei
2021-08-17 4:50 ` Christoph Hellwig
2021-08-18 8:38 ` Ming Lei
2021-08-14 12:35 ` [PATCH 5/7] genirq/affinity: move group_cpus_evenly() into lib/ Ming Lei
2021-08-14 17:01 ` kernel test robot
2021-08-14 17:01 ` kernel test robot
2021-08-16 1:04 ` Ming Lei
2021-08-16 1:04 ` Ming Lei
2021-08-17 4:52 ` Christoph Hellwig [this message]
2021-08-17 4:52 ` Christoph Hellwig
2021-08-14 17:15 ` kernel test robot
2021-08-14 17:15 ` kernel test robot
2021-08-14 12:35 ` [PATCH 6/7] lib/group_cpus: allow to group cpus in case of !CONFIG_SMP Ming Lei
2021-08-17 4:52 ` Christoph Hellwig
2021-08-14 12:35 ` [PATCH 7/7] blk-mq: build default queue map via group_cpus_evenly() Ming Lei
2021-08-14 16:31 ` kernel test robot
2021-08-14 16:31 ` kernel test robot
2021-08-14 20:49 ` kernel test robot
2021-08-14 20:49 ` kernel test robot
2021-08-16 7:23 ` Ming Lei
2021-08-16 7:23 ` Ming Lei
-- strict thread matches above, loose matches on Subject: below --
2021-08-15 1:49 [PATCH 5/7] genirq/affinity: move group_cpus_evenly() into lib/ kernel test robot
2021-08-16 10:08 ` kernel test robot
2021-08-16 10:08 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817045218.GE3874@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ming.lei@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.