All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	jonathanh@nvidia.com, thierry.reding@gmail.com,
	linux-tegra@vger.kernel.org, will@kernel.org
Subject: Re: [PATCH v6 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs
Date: Tue, 14 Sep 2021 11:49:34 -0700	[thread overview]
Message-ID: <20210914184933.GA32705@Asurada-Nvidia> (raw)
In-Reply-To: <31501a62-3312-9f04-3bb8-790d0481746c@gmail.com>

On Tue, Sep 14, 2021 at 04:29:15PM +0300, Dmitry Osipenko wrote:
> 14.09.2021 04:38, Nicolin Chen пишет:
> > +static unsigned long pd_pt_index_iova(unsigned int pd_index, unsigned int pt_index)
> > +{
> > +	return ((dma_addr_t)pd_index & (SMMU_NUM_PDE - 1)) << SMMU_PDE_SHIFT |
> > +	       ((dma_addr_t)pt_index & (SMMU_NUM_PTE - 1)) << SMMU_PTE_SHIFT;
> > +}
> 
> We know that IOVA is fixed to u32 for this controller. Can we avoid all
> these dma_addr_t castings? It should make code cleaner a tad, IMO.

Tegra210 actually supports 34-bit IOVA...
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: thierry.reding@gmail.com, joro@8bytes.org, will@kernel.org,
	vdumpa@nvidia.com, jonathanh@nvidia.com,
	linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs
Date: Tue, 14 Sep 2021 11:49:34 -0700	[thread overview]
Message-ID: <20210914184933.GA32705@Asurada-Nvidia> (raw)
In-Reply-To: <31501a62-3312-9f04-3bb8-790d0481746c@gmail.com>

On Tue, Sep 14, 2021 at 04:29:15PM +0300, Dmitry Osipenko wrote:
> 14.09.2021 04:38, Nicolin Chen пишет:
> > +static unsigned long pd_pt_index_iova(unsigned int pd_index, unsigned int pt_index)
> > +{
> > +	return ((dma_addr_t)pd_index & (SMMU_NUM_PDE - 1)) << SMMU_PDE_SHIFT |
> > +	       ((dma_addr_t)pt_index & (SMMU_NUM_PTE - 1)) << SMMU_PTE_SHIFT;
> > +}
> 
> We know that IOVA is fixed to u32 for this controller. Can we avoid all
> these dma_addr_t castings? It should make code cleaner a tad, IMO.

Tegra210 actually supports 34-bit IOVA...

  reply	other threads:[~2021-09-14 18:57 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  1:38 [PATCH v6 0/6] iommu/tegra-smmu: Add pagetable mappings to debugfs Nicolin Chen
2021-09-14  1:38 ` Nicolin Chen
2021-09-14  1:38 ` [PATCH v6 1/6] iommu/tegra-smmu: Rename struct iommu_group *group to *grp Nicolin Chen
2021-09-14  1:38   ` Nicolin Chen
2021-10-07 16:43   ` Thierry Reding
2021-10-07 16:43     ` Thierry Reding
2021-09-14  1:38 ` [PATCH v6 2/6] iommu/tegra-smmu: Rename struct tegra_smmu_group_soc *soc to *group_soc Nicolin Chen
2021-09-14  1:38   ` Nicolin Chen
2021-10-07 16:50   ` Thierry Reding
2021-10-07 16:50     ` Thierry Reding
2021-10-07 20:14     ` Nicolin Chen
2021-10-07 20:14       ` Nicolin Chen
2021-09-14  1:38 ` [PATCH v6 3/6] iommu/tegra-smmu: Rename struct tegra_smmu_swgroup *group to *swgrp Nicolin Chen
2021-09-14  1:38   ` Nicolin Chen
2021-10-07 16:57   ` Thierry Reding
2021-10-07 16:57     ` Thierry Reding
2021-10-07 20:29     ` Nicolin Chen
2021-10-07 20:29       ` Nicolin Chen
2021-09-14  1:38 ` [PATCH v6 4/6] iommu/tegra-smmu: Use swgrp pointer instead of swgroup id Nicolin Chen
2021-09-14  1:38   ` Nicolin Chen
2021-10-07 16:59   ` Thierry Reding
2021-10-07 16:59     ` Thierry Reding
2021-09-14  1:38 ` [PATCH v6 5/6] iommu/tegra-smmu: Attach as pointer to tegra_smmu_group Nicolin Chen
2021-09-14  1:38   ` Nicolin Chen
2021-10-07 17:02   ` Thierry Reding
2021-10-07 17:02     ` Thierry Reding
2021-09-14  1:38 ` [PATCH v6 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs Nicolin Chen
2021-09-14  1:38   ` Nicolin Chen
2021-09-14 13:29   ` Dmitry Osipenko
2021-09-14 13:29     ` Dmitry Osipenko
2021-09-14 18:49     ` Nicolin Chen [this message]
2021-09-14 18:49       ` Nicolin Chen
2021-09-14 19:20       ` Dmitry Osipenko
2021-09-14 19:20         ` Dmitry Osipenko
2021-09-15  4:38         ` Nicolin Chen
2021-09-15  4:38           ` Nicolin Chen
2021-09-15 12:09           ` Dmitry Osipenko
2021-09-15 12:09             ` Dmitry Osipenko
2021-09-15 12:18             ` Dmitry Osipenko
2021-09-15 12:18               ` Dmitry Osipenko
2021-09-15 22:19             ` Nicolin Chen
2021-09-15 22:19               ` Nicolin Chen
2021-10-07 17:13   ` Thierry Reding
2021-10-07 17:13     ` Thierry Reding
2021-10-07 20:41     ` Nicolin Chen
2021-10-07 20:41       ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210914184933.GA32705@Asurada-Nvidia \
    --to=nicoleotsuka@gmail.com \
    --cc=digetx@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.