From: Kushal Kothari <kushalkothari285@gmail.com>
To: mike.rapoport@gmail.com, outreachy-kernel@googlegroups.com,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
gregkh@linuxfoundation.org, kushalkothari2850@gmail.com
Cc: Kushal Kothari <kushalkothari285@gmail.com>
Subject: [PATCH] staging : media : atomisp : input_system.c : fixes the error of control reaches end of non-void function [-Werror=return-type]
Date: Fri, 15 Oct 2021 04:00:09 +0530 [thread overview]
Message-ID: <20211014223007.596789-1-kushalkothari285@gmail.com> (raw)
The compiler cannot tell from that code if the function will ever reach
the end and still return something. To make that clear, replaced the last
line with just "else" which fixes the error of "error: control reaches end of non-void function [-Werror=return-type]"
Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
---
.../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
index 8e085dda0c18..91bad8f34efc 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
@@ -1587,6 +1587,7 @@ static input_system_err_t input_system_configure_channel_sensor(
status = set_source_type(&config.source_type, channel.source_type,
&config.source_type_flags);
if (status != INPUT_SYSTEM_ERR_NO_ERROR) return status;
+ else return status;
// Check for conflicts on source (implicitly on multicast, capture unit and input buffer).
--
2.25.1
next reply other threads:[~2021-10-14 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 22:30 Kushal Kothari [this message]
2021-10-15 2:26 ` [Outreachy kernel] [PATCH] staging : media : atomisp : input_system.c : fixes the error of control reaches end of non-void function [-Werror=return-type] Alison Schofield
2021-10-15 8:54 ` Kieran Bingham
2021-10-15 12:04 ` Fabio M. De Francesco
2021-10-15 12:18 ` Fabio M. De Francesco
2021-10-15 14:52 ` Julia Lawall
2021-10-15 15:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014223007.596789-1-kushalkothari285@gmail.com \
--to=kushalkothari285@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kushalkothari2850@gmail.com \
--cc=mchehab@kernel.org \
--cc=mike.rapoport@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.