Re: [Outreachy kernel] [PATCH] staging : media : atomisp : input_system.c : fixes the error of control reaches end of non-void function [-Werror=return-type]

[Alison Schofield <alison.schofield@intel.com>]

On Fri, Oct 15, 2021 at 04:00:09AM +0530, Kushal Kothari wrote:
> The compiler cannot tell from that code if the function will ever reach
> the end and still return something. To make that clear, replaced the last
> line with just "else" which fixes the error of "error: control reaches end of non-void function [-Werror=return-type]"
> 
> Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>

Hi Kushal,

Thanks for the patch and welcome to Outreachy.

Unfortunately we're not accepting patches in this driver this round.
Any other driver within media is OK. See the google-groups welcome
message and the email history since October 8th for more info.
I also updated the first patch tutorial, because you showed me that
this restriction was too easy to miss.

Anyway, just so your patch isn't for nothing, I'll give you feedback
on the commit message. You'll want to write that in the imperative mode,
So, for one like this, maybe something like:

'remove conditional from return in non-void function'

Alison


> ---
>  .../media/atomisp/pci/hive_isp_css_common/host/input_system.c    | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8e085dda0c18..91bad8f34efc 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -1587,6 +1587,7 @@ static input_system_err_t input_system_configure_channel_sensor(
>  	status = set_source_type(&config.source_type, channel.source_type,
>  				 &config.source_type_flags);
>  	if (status != INPUT_SYSTEM_ERR_NO_ERROR) return status;
> +	else return status;
>  
>  	// Check for conflicts on source (implicitly on multicast, capture unit and input buffer).
>  
> -- 
> 2.25.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20211014223007.596789-1-kushalkothari285%40gmail.com.