Re: [Outreachy kernel] [PATCH] staging : media : atomisp : input_system.c : fixes the error of control reaches end of non-void function [-Werror=return-type]

["Fabio M. De Francesco" <fmdefrancesco@gmail.com>]

On Friday, October 15, 2021 2:04:49 PM CEST Fabio M. De Francesco wrote:
> Hi Kushal,
> 
> Aside from what Alison said about not accepting patches in this driver this 
> round, please note that this is not the correct way to address that 
compiler 
> warning.
> 
> Think about it: now, whatever "state" you get from set_source_type(), you 
> always return it to the caller of input_system_configure_channel_sensor().
> 
> By doing so, you change the logic of the function and get dead code. This 
> change makes the rest of the function code unreachable and introduces a 
huge 
> bug.
> 
> While the patch cannot be accepted for Outreachy, think of a better 
solution 
> as you may need to make similar changes in future patches.
> 
> Thanks and welcome,
> 
> Fabio M. De Francesco

I'm sorry, but just now I saw the reply Kieran Bingham. I'm simply restating 
what he wrote, so please disregard my email.

I think that I didn't see his email because you forgot to CC linux-
staging@lists.linux.dev and linux-kernel@vger.kernel.org.

Please read again the Outreachy rules. If I'm not wrong, you should always CC 
the two mailing lists above.

Thanks,

Fabio M. De Francesco