From: Shawn Guo <shawnguo@kernel.org>
To: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: Frieder Schrempf <frieder@fris.de>,
devicetree@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
stable@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH 3/8] arm64: dts: imx8mm-kontron: Set VDD_SNVS to 800 mV
Date: Fri, 15 Oct 2021 12:04:51 +0800 [thread overview]
Message-ID: <20211015040450.GF22881@dragon> (raw)
In-Reply-To: <df454b06-3069-d369-e3c7-f2434d94f4af@kontron.de>
On Tue, Oct 05, 2021 at 03:14:40PM +0200, Frieder Schrempf wrote:
> On 05.10.21 08:56, Shawn Guo wrote:
> > On Thu, Sep 30, 2021 at 05:56:26PM +0200, Frieder Schrempf wrote:
> >> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>
> >> According to the datasheet VDD_SNVS should be 800 mV, so let's
> >> make sure that the voltage won't be different.
> >
> > Could you share the datasheet?
>
> Sure, it's here: https://www.nxp.com/docs/en/data-sheet/IMX8MMIEC.pdf.
> See table 10 for the operating voltages.
Thanks for the link!
But datasheet specifies a voltage range. 800 mV is just the typical one.
The only problem I see is that regulator-min-microvolt should be lowered
to 800 mV. regulator-max-microvolt looks correct to me.
Shawn
>
> >>
> >> Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> >> ---
> >> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> >> index b12fb7ce6686..213014f59b46 100644
> >> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> >> @@ -152,8 +152,8 @@ reg_nvcc_snvs: LDO1 {
> >>
> >> reg_vdd_snvs: LDO2 {
> >> regulator-name = "ldo2";
> >> - regulator-min-microvolt = <850000>;
> >> - regulator-max-microvolt = <900000>;
> >> + regulator-min-microvolt = <800000>;
> >> + regulator-max-microvolt = <800000>;
> >> regulator-boot-on;
> >> regulator-always-on;
> >> };
> >> --
> >> 2.33.0
> >>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: Frieder Schrempf <frieder@fris.de>,
devicetree@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
stable@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH 3/8] arm64: dts: imx8mm-kontron: Set VDD_SNVS to 800 mV
Date: Fri, 15 Oct 2021 12:04:51 +0800 [thread overview]
Message-ID: <20211015040450.GF22881@dragon> (raw)
In-Reply-To: <df454b06-3069-d369-e3c7-f2434d94f4af@kontron.de>
On Tue, Oct 05, 2021 at 03:14:40PM +0200, Frieder Schrempf wrote:
> On 05.10.21 08:56, Shawn Guo wrote:
> > On Thu, Sep 30, 2021 at 05:56:26PM +0200, Frieder Schrempf wrote:
> >> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>
> >> According to the datasheet VDD_SNVS should be 800 mV, so let's
> >> make sure that the voltage won't be different.
> >
> > Could you share the datasheet?
>
> Sure, it's here: https://www.nxp.com/docs/en/data-sheet/IMX8MMIEC.pdf.
> See table 10 for the operating voltages.
Thanks for the link!
But datasheet specifies a voltage range. 800 mV is just the typical one.
The only problem I see is that regulator-min-microvolt should be lowered
to 800 mV. regulator-max-microvolt looks correct to me.
Shawn
>
> >>
> >> Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> >> ---
> >> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> >> index b12fb7ce6686..213014f59b46 100644
> >> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> >> @@ -152,8 +152,8 @@ reg_nvcc_snvs: LDO1 {
> >>
> >> reg_vdd_snvs: LDO2 {
> >> regulator-name = "ldo2";
> >> - regulator-min-microvolt = <850000>;
> >> - regulator-max-microvolt = <900000>;
> >> + regulator-min-microvolt = <800000>;
> >> + regulator-max-microvolt = <800000>;
> >> regulator-boot-on;
> >> regulator-always-on;
> >> };
> >> --
> >> 2.33.0
> >>
next prev parent reply other threads:[~2021-10-15 4:06 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 15:56 [PATCH 0/8] Devicetree fixes and additions for Kontron SL/BL i.MX8MM boards Frieder Schrempf
2021-09-30 15:56 ` Frieder Schrempf
2021-09-30 15:56 ` [PATCH 1/8] arm64: dts: imx8mm-kontron: Add support for ultra high speed modes on SD card Frieder Schrempf
2021-09-30 15:56 ` Frieder Schrempf
2021-10-05 6:45 ` Shawn Guo
2021-10-05 6:45 ` Shawn Guo
2021-10-15 10:44 ` Frieder Schrempf
2021-10-15 10:44 ` Frieder Schrempf
2021-09-30 15:56 ` [PATCH 2/8] arm64: dts: imx8mm-kontron: Make sure SOC and DRAM supply voltages are correct Frieder Schrempf
2021-09-30 15:56 ` Frieder Schrempf
2021-09-30 16:02 ` Frieder Schrempf
2021-09-30 16:02 ` Frieder Schrempf
2021-10-05 6:49 ` Shawn Guo
2021-10-05 6:49 ` Shawn Guo
2021-10-05 6:53 ` Shawn Guo
2021-10-05 6:53 ` Shawn Guo
2021-10-05 13:10 ` Frieder Schrempf
2021-10-05 13:10 ` Frieder Schrempf
2021-10-15 3:51 ` Shawn Guo
2021-10-15 3:51 ` Shawn Guo
2021-09-30 15:56 ` [PATCH 3/8] arm64: dts: imx8mm-kontron: Set VDD_SNVS to 800 mV Frieder Schrempf
2021-09-30 15:56 ` Frieder Schrempf
2021-10-05 6:56 ` Shawn Guo
2021-10-05 6:56 ` Shawn Guo
2021-10-05 13:14 ` Frieder Schrempf
2021-10-05 13:14 ` Frieder Schrempf
2021-10-15 4:04 ` Shawn Guo [this message]
2021-10-15 4:04 ` Shawn Guo
2021-09-30 15:56 ` [PATCH 4/8] arm64: dts: imx8mm-kontron: Fix reg_rst_eth2 and reg_vdd_5v regulators Frieder Schrempf
2021-09-30 15:56 ` Frieder Schrempf
2021-10-05 7:09 ` Shawn Guo
2021-10-05 7:09 ` Shawn Guo
2021-10-05 17:06 ` Frieder Schrempf
2021-10-05 17:06 ` Frieder Schrempf
2021-10-15 4:09 ` Shawn Guo
2021-10-15 4:09 ` Shawn Guo
2021-10-15 11:32 ` Frieder Schrempf
2021-10-15 11:32 ` Frieder Schrempf
2021-09-30 15:56 ` [PATCH 5/8] arm64: dts: imx8mm-kontron: Fix CAN SPI clock frequency Frieder Schrempf
2021-09-30 15:56 ` Frieder Schrempf
2021-10-05 7:12 ` Shawn Guo
2021-10-05 7:12 ` Shawn Guo
2021-10-05 17:17 ` Frieder Schrempf
2021-10-05 17:17 ` Frieder Schrempf
2021-10-15 4:12 ` Shawn Guo
2021-10-15 4:12 ` Shawn Guo
2021-09-30 15:56 ` [PATCH 6/8] arm64: dts: imx8mm-kontron: Fix connection type for VSC8531 RGMII PHY Frieder Schrempf
2021-10-02 18:14 ` Heiko Thiery
2021-10-02 18:08 ` Heiko Thiery
2021-09-30 15:56 ` Frieder Schrempf
2021-10-05 7:20 ` Shawn Guo
2021-10-05 7:20 ` Shawn Guo
2021-09-30 15:56 ` [PATCH 7/8] arm64: dts: imx8mm-kontron: Fix reset delays for ethernet PHY Frieder Schrempf
2021-09-30 15:56 ` Frieder Schrempf
2021-09-30 15:56 ` [PATCH 8/8] arm64: dts: imx8mm-kontron: Leave reg_vdd_arm always powered on Frieder Schrempf
2021-09-30 15:56 ` Frieder Schrempf
2021-09-30 18:52 ` Heiko Thiery
2021-09-30 18:52 ` Heiko Thiery
2021-10-05 7:27 ` Shawn Guo
2021-10-05 7:27 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015040450.GF22881@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=frieder@fris.de \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.