All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Herve Codina <herve.codina@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 1/4] mtd: rawnand: Fix nand_erase_op delay
Date: Fri, 19 Nov 2021 09:18:06 +0100	[thread overview]
Message-ID: <20211119091806.76900103@xps13> (raw)
In-Reply-To: <20211119073909.1492538-2-herve.codina@bootlin.com>

Hi Herve,

herve.codina@bootlin.com wrote on Fri, 19 Nov 2021 08:39:06 +0100:

> NAND_OP_CMD() expect a delay parameter in nanoseconds.

expects

> The delay value is wrongly given in milliseconds.
> 
> Fix the conversion macro used in order to set this
> delay in nanoseconds.
> 

I believe you still miss the Fixes: tag here :)

> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
> Changes v1 -> v2:
> - Commit log reword
> 
>  drivers/mtd/nand/raw/nand_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index 3d6c6e880520..5c6b065837ef 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -1837,7 +1837,7 @@ int nand_erase_op(struct nand_chip *chip, unsigned int eraseblock)
>  			NAND_OP_CMD(NAND_CMD_ERASE1, 0),
>  			NAND_OP_ADDR(2, addrs, 0),
>  			NAND_OP_CMD(NAND_CMD_ERASE2,
> -				    NAND_COMMON_TIMING_MS(conf, tWB_max)),
> +				    NAND_COMMON_TIMING_NS(conf, tWB_max)),
>  			NAND_OP_WAIT_RDY(NAND_COMMON_TIMING_MS(conf, tBERS_max),
>  					 0),
>  		};

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Herve Codina <herve.codina@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 1/4] mtd: rawnand: Fix nand_erase_op delay
Date: Fri, 19 Nov 2021 09:18:06 +0100	[thread overview]
Message-ID: <20211119091806.76900103@xps13> (raw)
In-Reply-To: <20211119073909.1492538-2-herve.codina@bootlin.com>

Hi Herve,

herve.codina@bootlin.com wrote on Fri, 19 Nov 2021 08:39:06 +0100:

> NAND_OP_CMD() expect a delay parameter in nanoseconds.

expects

> The delay value is wrongly given in milliseconds.
> 
> Fix the conversion macro used in order to set this
> delay in nanoseconds.
> 

I believe you still miss the Fixes: tag here :)

> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
> Changes v1 -> v2:
> - Commit log reword
> 
>  drivers/mtd/nand/raw/nand_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index 3d6c6e880520..5c6b065837ef 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -1837,7 +1837,7 @@ int nand_erase_op(struct nand_chip *chip, unsigned int eraseblock)
>  			NAND_OP_CMD(NAND_CMD_ERASE1, 0),
>  			NAND_OP_ADDR(2, addrs, 0),
>  			NAND_OP_CMD(NAND_CMD_ERASE2,
> -				    NAND_COMMON_TIMING_MS(conf, tWB_max)),
> +				    NAND_COMMON_TIMING_NS(conf, tWB_max)),
>  			NAND_OP_WAIT_RDY(NAND_COMMON_TIMING_MS(conf, tBERS_max),
>  					 0),
>  		};

Thanks,
Miquèl

  reply	other threads:[~2021-11-19  8:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  7:39 [PATCH v2 0/4] mtd: rawnand: Fixes nand infra delay setting and FSMC nand controller Herve Codina
2021-11-19  7:39 ` Herve Codina
2021-11-19  7:39 ` [PATCH v2 1/4] mtd: rawnand: Fix nand_erase_op delay Herve Codina
2021-11-19  7:39   ` Herve Codina
2021-11-19  8:18   ` Miquel Raynal [this message]
2021-11-19  8:18     ` Miquel Raynal
2021-11-19  7:39 ` [PATCH v2 2/4] mtd: rawnand: Fix nand_choose_best_timings() on unsupported interface Herve Codina
2021-11-19  7:39   ` Herve Codina
2021-11-19  9:08   ` Miquel Raynal
2021-11-19  9:08     ` Miquel Raynal
2021-11-19  7:39 ` [PATCH v2 3/4] mtd: rawnand: fsmc: Take instruction delay into account Herve Codina
2021-11-19  7:39   ` Herve Codina
2021-11-19  7:39 ` [PATCH v2 4/4] mtd: rawnand: fsmc: Fix timing computation Herve Codina
2021-11-19  7:39   ` Herve Codina
2021-11-19  8:32   ` Miquel Raynal
2021-11-19  8:32     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211119091806.76900103@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=herve.codina@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.