* [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
@ 2021-11-18 9:59 Fabio Estevam
2021-11-22 1:23 ` Shawn Guo
0 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2021-11-18 9:59 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, linux-arm-kernel, georgemakarov1, peter.chen, otavio,
Fabio Estevam
According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may
have the ESAI_TX0 functionality, not ESAI_T0.
Also, NXP's i.MX Config Tools 10.0 generates dtsi with the
MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming.
Add an entry for the correct name and still keep the old one to
avoid potential breakage.
Fixes: c201369d4aa5 ("ARM: dts: imx6ull: add imx6ull support")
Reported-by: George Makarov <georgemakarov1@gmail.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6ull-pinfunc.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/imx6ull-pinfunc.h b/arch/arm/boot/dts/imx6ull-pinfunc.h
index eb025a9d4759..b492164e8cfb 100644
--- a/arch/arm/boot/dts/imx6ull-pinfunc.h
+++ b/arch/arm/boot/dts/imx6ull-pinfunc.h
@@ -82,6 +82,11 @@
#define MX6ULL_PAD_CSI_DATA04__ESAI_TX_FS 0x01F4 0x0480 0x0000 0x9 0x0
#define MX6ULL_PAD_CSI_DATA05__ESAI_TX_CLK 0x01F8 0x0484 0x0000 0x9 0x0
#define MX6ULL_PAD_CSI_DATA06__ESAI_TX5_RX0 0x01FC 0x0488 0x0000 0x9 0x0
+/*
+ * As per the Reference Manual the correct name is ESAI_TX0.
+ * Keep the old name here to avoid breakage.
+ */
#define MX6ULL_PAD_CSI_DATA07__ESAI_T0 0x0200 0x048C 0x0000 0x9 0x0
+#define MX6ULL_PAD_CSI_DATA07__ESAI_TX0 0x0200 0x048C 0x0000 0x9 0x0
#endif /* __DTS_IMX6ULL_PINFUNC_H */
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
2021-11-18 9:59 [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0 Fabio Estevam
@ 2021-11-22 1:23 ` Shawn Guo
2021-11-22 1:46 ` Fabio Estevam
0 siblings, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2021-11-22 1:23 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh+dt, linux-arm-kernel, georgemakarov1, peter.chen, otavio
On Thu, Nov 18, 2021 at 06:59:34AM -0300, Fabio Estevam wrote:
> According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may
> have the ESAI_TX0 functionality, not ESAI_T0.
>
> Also, NXP's i.MX Config Tools 10.0 generates dtsi with the
> MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming.
>
> Add an entry for the correct name and still keep the old one to
> avoid potential breakage.
>
> Fixes: c201369d4aa5 ("ARM: dts: imx6ull: add imx6ull support")
> Reported-by: George Makarov <georgemakarov1@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm/boot/dts/imx6ull-pinfunc.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6ull-pinfunc.h b/arch/arm/boot/dts/imx6ull-pinfunc.h
> index eb025a9d4759..b492164e8cfb 100644
> --- a/arch/arm/boot/dts/imx6ull-pinfunc.h
> +++ b/arch/arm/boot/dts/imx6ull-pinfunc.h
> @@ -82,6 +82,11 @@
> #define MX6ULL_PAD_CSI_DATA04__ESAI_TX_FS 0x01F4 0x0480 0x0000 0x9 0x0
> #define MX6ULL_PAD_CSI_DATA05__ESAI_TX_CLK 0x01F8 0x0484 0x0000 0x9 0x0
> #define MX6ULL_PAD_CSI_DATA06__ESAI_TX5_RX0 0x01FC 0x0488 0x0000 0x9 0x0
> +/*
> + * As per the Reference Manual the correct name is ESAI_TX0.
> + * Keep the old name here to avoid breakage.
> + */
> #define MX6ULL_PAD_CSI_DATA07__ESAI_T0 0x0200 0x048C 0x0000 0x9 0x0
I don't see any user of it, so should be be safe just to remove it, no?
Shawn
> +#define MX6ULL_PAD_CSI_DATA07__ESAI_TX0 0x0200 0x048C 0x0000 0x9 0x0
>
> #endif /* __DTS_IMX6ULL_PINFUNC_H */
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
2021-11-22 1:23 ` Shawn Guo
@ 2021-11-22 1:46 ` Fabio Estevam
2021-11-22 11:11 ` Otavio Salvador
0 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2021-11-22 1:46 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
georgemakarov1, peter.chen, Otavio Salvador
Hi Shawn,
On Sun, Nov 21, 2021 at 10:23 PM Shawn Guo <shawnguo@kernel.org> wrote:
> I don't see any user of it, so should be be safe just to remove it, no?
Devicetrees are used in other projects, like U-Boot, for example.
There are developers that keep their devicetree out-of-tree as well,
so I prefer to keep the old name to avoid potential breakage.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
2021-11-22 1:46 ` Fabio Estevam
@ 2021-11-22 11:11 ` Otavio Salvador
0 siblings, 0 replies; 8+ messages in thread
From: Otavio Salvador @ 2021-11-22 11:11 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Rob Herring,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
georgemakarov1, peter.chen, Otavio Salvador
Em dom., 21 de nov. de 2021 às 22:46, Fabio Estevam
<festevam@gmail.com> escreveu:
> On Sun, Nov 21, 2021 at 10:23 PM Shawn Guo <shawnguo@kernel.org> wrote:
> > I don't see any user of it, so should be be safe just to remove it, no?
>
> Devicetrees are used in other projects, like U-Boot, for example.
>
> There are developers that keep their devicetree out-of-tree as well,
> so I prefer to keep the old name to avoid potential breakage.
I'd be in favor of removing it; if there are out-of-tree uses that's a
consequence of it not being sent upstream. I fail to see reasons to
keep the old name.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
@ 2021-11-18 10:06 Fabio Estevam
2021-11-18 11:33 ` Otavio Salvador
0 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2021-11-18 10:06 UTC (permalink / raw)
To: sbabic; +Cc: uboot-imx, u-boot, georgemakarov1, otavio, Fabio Estevam
According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may
have the ESAI_TX0 functionality, not ESAI_T0.
Also, NXP's i.MX Config Tools 10.0 generates dtsi with the
MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming.
Add an entry for the correct name and still keep the old one to
avoid potential breakage.
Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines")
Reported-by: George Makarov <georgemakarov1@gmail.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Hi,
I have also sent this patch to the Linux upstream dts:
http://lists.infradead.org/pipermail/linux-arm-kernel/2021-November/697319.html
arch/arm/dts/imx6ull-pinfunc.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/dts/imx6ull-pinfunc.h b/arch/arm/dts/imx6ull-pinfunc.h
index eb025a9d4759..b492164e8cfb 100644
--- a/arch/arm/dts/imx6ull-pinfunc.h
+++ b/arch/arm/dts/imx6ull-pinfunc.h
@@ -82,6 +82,11 @@
#define MX6ULL_PAD_CSI_DATA04__ESAI_TX_FS 0x01F4 0x0480 0x0000 0x9 0x0
#define MX6ULL_PAD_CSI_DATA05__ESAI_TX_CLK 0x01F8 0x0484 0x0000 0x9 0x0
#define MX6ULL_PAD_CSI_DATA06__ESAI_TX5_RX0 0x01FC 0x0488 0x0000 0x9 0x0
+/*
+ * As per the Reference Manual the correct name is ESAI_TX0.
+ * Keep the old name here to avoid breakage.
+ */
#define MX6ULL_PAD_CSI_DATA07__ESAI_T0 0x0200 0x048C 0x0000 0x9 0x0
+#define MX6ULL_PAD_CSI_DATA07__ESAI_TX0 0x0200 0x048C 0x0000 0x9 0x0
#endif /* __DTS_IMX6ULL_PINFUNC_H */
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
2021-11-18 10:06 Fabio Estevam
@ 2021-11-18 11:33 ` Otavio Salvador
2021-11-18 11:35 ` Fabio Estevam
0 siblings, 1 reply; 8+ messages in thread
From: Otavio Salvador @ 2021-11-18 11:33 UTC (permalink / raw)
To: Fabio Estevam
Cc: Stefano Babic, uboot-imx, U-Boot Mailing List, georgemakarov1,
Otavio Salvador
Em qui., 18 de nov. de 2021 às 07:06, Fabio Estevam
<festevam@gmail.com> escreveu:
> According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may
> have the ESAI_TX0 functionality, not ESAI_T0.
>
> Also, NXP's i.MX Config Tools 10.0 generates dtsi with the
> MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming.
>
> Add an entry for the correct name and still keep the old one to
> avoid potential breakage.
>
> Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines")
> Reported-by: George Makarov <georgemakarov1@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Have you verified if there is any use of the old name in the three? if
so, a patch converting it would be good.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
2021-11-18 11:33 ` Otavio Salvador
@ 2021-11-18 11:35 ` Fabio Estevam
2021-11-18 11:54 ` Otavio Salvador
0 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2021-11-18 11:35 UTC (permalink / raw)
To: Otavio Salvador
Cc: Stefano Babic, dl-uboot-imx, U-Boot Mailing List, georgemakarov1,
Otavio Salvador
Hi Otavio,
On Thu, Nov 18, 2021 at 8:33 AM Otavio Salvador
<otavio.salvador@ossystems.com.br> wrote:
>
> Em qui., 18 de nov. de 2021 às 07:06, Fabio Estevam
> <festevam@gmail.com> escreveu:
> > According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may
> > have the ESAI_TX0 functionality, not ESAI_T0.
> >
> > Also, NXP's i.MX Config Tools 10.0 generates dtsi with the
> > MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming.
> >
> > Add an entry for the correct name and still keep the old one to
> > avoid potential breakage.
> >
> > Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines")
> > Reported-by: George Makarov <georgemakarov1@gmail.com>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Have you verified if there is any use of the old name in the three? if
> so, a patch converting it would be good.
There is no in-tree user of MX6ULL_PAD_CSI_DATA07__ESAI_T0 in U-Boot
and in the kernel.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0
2021-11-18 11:35 ` Fabio Estevam
@ 2021-11-18 11:54 ` Otavio Salvador
0 siblings, 0 replies; 8+ messages in thread
From: Otavio Salvador @ 2021-11-18 11:54 UTC (permalink / raw)
To: Fabio Estevam
Cc: Stefano Babic, dl-uboot-imx, U-Boot Mailing List, georgemakarov1,
Otavio Salvador
Hello Fabio,
Em qui., 18 de nov. de 2021 às 08:36, Fabio Estevam
<festevam@gmail.com> escreveu:
> On Thu, Nov 18, 2021 at 8:33 AM Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
> >
> > Em qui., 18 de nov. de 2021 às 07:06, Fabio Estevam
> > <festevam@gmail.com> escreveu:
> > > According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may
> > > have the ESAI_TX0 functionality, not ESAI_T0.
> > >
> > > Also, NXP's i.MX Config Tools 10.0 generates dtsi with the
> > > MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming.
> > >
> > > Add an entry for the correct name and still keep the old one to
> > > avoid potential breakage.
> > >
> > > Fixes: f8ca22b8de32 ("arm: dts: imx6ull: add pinctrl defines")
> > > Reported-by: George Makarov <georgemakarov1@gmail.com>
> > > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> >
> > Have you verified if there is any use of the old name in the three? if
> > so, a patch converting it would be good.
>
> There is no in-tree user of MX6ULL_PAD_CSI_DATA07__ESAI_T0 in U-Boot
> and in the kernel.
Awesome.
Reviewed-by: Otavio Salvador <otavio@ossystems.com.br>
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-11-22 12:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-18 9:59 [PATCH] ARM: dts: imx6ull: Use the correct name for ESAI_TX0 Fabio Estevam
2021-11-22 1:23 ` Shawn Guo
2021-11-22 1:46 ` Fabio Estevam
2021-11-22 11:11 ` Otavio Salvador
-- strict thread matches above, loose matches on Subject: below --
2021-11-18 10:06 Fabio Estevam
2021-11-18 11:33 ` Otavio Salvador
2021-11-18 11:35 ` Fabio Estevam
2021-11-18 11:54 ` Otavio Salvador
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.