All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt
Date: Thu,  9 Dec 2021 16:59:37 +0200	[thread overview]
Message-ID: <20211209145937.77719-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20211209145937.77719-1-andriy.shevchenko@linux.intel.com>

If 64-bit mask attempt fails, the 32-bit will fail by the very same reason.
Don't even try the latter. It's a continuation of the changes that contains,
e.g. dcc02c19cc06 ("sata_sil24: use dma_set_mask_and_coherent").

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/ata/libahci_platform.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index 1af642c84e7b..972f5ec86a27 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -637,13 +637,8 @@ int ahci_platform_init_host(struct platform_device *pdev,
 	if (hpriv->cap & HOST_CAP_64) {
 		rc = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64));
 		if (rc) {
-			rc = dma_coerce_mask_and_coherent(dev,
-							  DMA_BIT_MASK(32));
-			if (rc) {
-				dev_err(dev, "Failed to enable 64-bit DMA.\n");
-				return rc;
-			}
-			dev_warn(dev, "Enable 32-bit DMA instead of 64-bit.\n");
+			dev_err(dev, "Failed to enable 64-bit DMA.\n");
+			return rc;
 		}
 	}
 
-- 
2.33.0


  reply	other threads:[~2021-12-09 14:59 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 14:59 [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Andy Shevchenko
2021-12-09 14:59 ` Andy Shevchenko [this message]
2021-12-10 19:34   ` [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt Andy Shevchenko
2021-12-11  0:04     ` Damien Le Moal
2021-12-17  0:58   ` Damien Le Moal
2021-12-17 11:57     ` Andy Shevchenko
2021-12-09 15:21 ` [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Hans de Goede
2021-12-09 17:24 ` Sergey Shtylyov
2021-12-09 17:42   ` Andy Shevchenko
2021-12-09 18:22     ` Sergey Shtylyov
2021-12-09 19:22       ` Andy Shevchenko
2021-12-09 19:27         ` Andy Shevchenko
2021-12-09 20:31           ` Sergey Shtylyov
2021-12-09 20:29         ` Sergey Shtylyov
2021-12-10 10:44           ` Andy Shevchenko
2021-12-10 11:14             ` Sergey Shtylyov
2021-12-10 11:28               ` Andy Shevchenko
2021-12-10 17:39                 ` Sergey Shtylyov
2021-12-10 17:51                   ` Andy Shevchenko
2021-12-09 22:49 ` Damien Le Moal
2021-12-09 22:57   ` Damien Le Moal
2021-12-10  8:47   ` Andy Shevchenko
2021-12-10 16:38     ` Sergey Shtylyov
2021-12-10 17:57       ` Andy Shevchenko
2021-12-10  8:59   ` Sergey Shtylyov
2021-12-10 10:46     ` Andy Shevchenko
2021-12-10 11:19       ` Sergey Shtylyov
2021-12-10 11:36         ` Andy Shevchenko
2021-12-10 17:15           ` Sergei Shtylyov
2021-12-10 17:59             ` Andy Shevchenko
2021-12-10 19:01               ` Sergey Shtylyov
2021-12-10 19:25                 ` Andy Shevchenko
2021-12-10 19:30                   ` Sergey Shtylyov
2021-12-10 19:35                     ` Sergei Shtylyov
2021-12-11 10:13                       ` Sergey Shtylyov
2021-12-13 11:26                         ` Andy Shevchenko
2021-12-10 23:45     ` Damien Le Moal
2021-12-11 10:25       ` Sergey Shtylyov
2021-12-12 22:39         ` Damien Le Moal
2021-12-13 11:52           ` Andy Shevchenko
2021-12-13 21:36             ` Damien Le Moal
2021-12-13 22:02               ` Andy Shevchenko
2021-12-13 11:49         ` Andy Shevchenko
2021-12-13 11:46       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211209145937.77719-2-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.