From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved
Date: Mon, 13 Dec 2021 13:26:33 +0200 [thread overview]
Message-ID: <Ybct6XoeJ1/9ai03@smile.fi.intel.com> (raw)
In-Reply-To: <8ec4a971-29ba-77f7-7c48-ad88decea70f@omp.ru>
On Sat, Dec 11, 2021 at 01:13:52PM +0300, Sergey Shtylyov wrote:
> On 10.12.2021 22:35, Sergei Shtylyov wrote:
...
> Also, your commit log is wrong in the description of how to handle the result:
>
> <<
> Now:
> ret = platform_get_irq_optional(...);
> if (ret != -ENXIO)
> return ret; // respect deferred probe
> if (ret > 0)
> ...we get an IRQ...
> >>
>
> The (ret != -ENXIO) check also succeeds on the (positive) IRQ #s, so the
> following code becomes unreachable. :-/
Indeed, thanks!
Should be
if (ret < 0 && ret != -ENXIO)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-13 11:27 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 14:59 [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Andy Shevchenko
2021-12-09 14:59 ` [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt Andy Shevchenko
2021-12-10 19:34 ` Andy Shevchenko
2021-12-11 0:04 ` Damien Le Moal
2021-12-17 0:58 ` Damien Le Moal
2021-12-17 11:57 ` Andy Shevchenko
2021-12-09 15:21 ` [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Hans de Goede
2021-12-09 17:24 ` Sergey Shtylyov
2021-12-09 17:42 ` Andy Shevchenko
2021-12-09 18:22 ` Sergey Shtylyov
2021-12-09 19:22 ` Andy Shevchenko
2021-12-09 19:27 ` Andy Shevchenko
2021-12-09 20:31 ` Sergey Shtylyov
2021-12-09 20:29 ` Sergey Shtylyov
2021-12-10 10:44 ` Andy Shevchenko
2021-12-10 11:14 ` Sergey Shtylyov
2021-12-10 11:28 ` Andy Shevchenko
2021-12-10 17:39 ` Sergey Shtylyov
2021-12-10 17:51 ` Andy Shevchenko
2021-12-09 22:49 ` Damien Le Moal
2021-12-09 22:57 ` Damien Le Moal
2021-12-10 8:47 ` Andy Shevchenko
2021-12-10 16:38 ` Sergey Shtylyov
2021-12-10 17:57 ` Andy Shevchenko
2021-12-10 8:59 ` Sergey Shtylyov
2021-12-10 10:46 ` Andy Shevchenko
2021-12-10 11:19 ` Sergey Shtylyov
2021-12-10 11:36 ` Andy Shevchenko
2021-12-10 17:15 ` Sergei Shtylyov
2021-12-10 17:59 ` Andy Shevchenko
2021-12-10 19:01 ` Sergey Shtylyov
2021-12-10 19:25 ` Andy Shevchenko
2021-12-10 19:30 ` Sergey Shtylyov
2021-12-10 19:35 ` Sergei Shtylyov
2021-12-11 10:13 ` Sergey Shtylyov
2021-12-13 11:26 ` Andy Shevchenko [this message]
2021-12-10 23:45 ` Damien Le Moal
2021-12-11 10:25 ` Sergey Shtylyov
2021-12-12 22:39 ` Damien Le Moal
2021-12-13 11:52 ` Andy Shevchenko
2021-12-13 21:36 ` Damien Le Moal
2021-12-13 22:02 ` Andy Shevchenko
2021-12-13 11:49 ` Andy Shevchenko
2021-12-13 11:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybct6XoeJ1/9ai03@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.